cerxes/openmaptiles
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix negative feature IDs (#1185)

Browse Source 
This PR removes the possibility of negative feature IDs for the `aerodrome_label` layer by defining the feature as the absolute value of the OSM id (imposm maps relations with negative numbers).  There is a very unlikely  scenario in which a relation and a way have the same ID (and are also in the same tile), however, unique IDs are not a strict requirement of MVT.

Noted in:
https://github.com/openmaptiles/openmaptiles/pull/1176#issuecomment-902503655

Positive feature ID for Quonset State Airport, which is mapped as a relation:
![image](https://user-images.githubusercontent.com/3254090/130232322-c797d491-ece9-4889-9695-ffb6f3ac011f.png)
This commit is contained in:
Brian Sperlongano 2021-08-20 10:40:02 -04:00 committed by GitHub
parent 36bd917e05
commit 6ef138635d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
layers/aerodrome_label/aerodrome_label.sql
View File

@ -5,7 +5,7 @@ CREATE OR REPLACE FUNCTION layer_aerodrome_label(bbox geometry,
zoom_level integer) zoom_level integer)
RETURNS TABLE RETURNS TABLE
( (
osm_id bigint, id bigint,
geometry geometry, geometry geometry,
name text, name text,
name_en text, name_en text,
@ -21,7 +21,7 @@ AS
$$ $$
SELECT SELECT
-- etldoc: osm_aerodrome_label_point -> layer_aerodrome_label:z10_ -- etldoc: osm_aerodrome_label_point -> layer_aerodrome_label:z10_
osm_id, ABS(osm_id) AS id, -- mvt feature IDs can't be negative
geometry, geometry,
name, name,
COALESCE(NULLIF(name_en, ''), name) AS name_en, COALESCE(NULLIF(name_en, ''), name) AS name_en,

4
layers/aerodrome_label/aerodrome_label.yaml
View File

@ -38,10 +38,10 @@ layer:
ele_ft: Elevation (`ele`) in feets. ele_ft: Elevation (`ele`) in feets.
datasource: datasource:
geometry_field: geometry geometry_field: geometry
key_field: osm_id key_field: id
key_field_as_attribute: no key_field_as_attribute: no
srid: 900913 srid: 900913
query: (SELECT osm_id, geometry, name, name_en, name_de, {name_languages}, class, iata, icao, ele, ele_ft FROM layer_aerodrome_label(!bbox!, z(!scale_denominator!))) AS t query: (SELECT id, geometry, name, name_en, name_de, {name_languages}, class, iata, icao, ele, ele_ft FROM layer_aerodrome_label(!bbox!, z(!scale_denominator!))) AS t
schema: schema:
- ./update_aerodrome_label_point.sql - ./update_aerodrome_label_point.sql
- ./aerodrome_label.sql - ./aerodrome_label.sql