miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(core): fix windows native build (#30990)

Browse Source 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

Native build is broken on Windows.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Native build is fixed on windows.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
This commit is contained in:
Jason Jean 2025-05-01 22:35:56 -04:00 committed by GitHub
parent 54cbbb9135
commit 110614da07
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/nx/src/native/pseudo_terminal/process_killer/windows.rs
View File

@ -15,7 +15,7 @@ impl ProcessKiller {
}
// windows doesn't have different signals to kill with
pub fn kill(&self, _: Option<String>) -> anyhow::Result<()> {
pub fn kill(&self, _: Option<&str>) -> anyhow::Result<()> {
let pc = WinProcess::open(self.pid as DWORD).expect("!open");
pc.kill()
.map_err(|e| anyhow::anyhow!("Failed to kill process {}: {}", self.pid, e))?;