miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

chore(repo): only valid latest publish when not local (#22131)

Browse Source
This commit is contained in:
James Henry 2024-03-04 17:23:00 +04:00 committed by GitHub
parent 80ae3971ff
commit 1d6e0f8c67
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 21 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
scripts/nx-release.ts
View File

@ -129,17 +129,6 @@ const VALID_AUTHORS_FOR_LATEST = [
}); });
const distTag = determineDistTag(options.version); const distTag = determineDistTag(options.version);
if (!distTag || distTag === 'latest') {
// We are only expecting latest releases to be performed within publish.yml on GitHub
const author = process.env.GITHUB_ACTOR ?? '';
if (!VALID_AUTHORS_FOR_LATEST.includes(author)) {
throw new Error(
`The GitHub user "${author}" is not allowed to publish to "latest". Please request one of the following users to carry out the release: ${VALID_AUTHORS_FOR_LATEST.join(
', '
)}`
);
}
}
if (options.dryRun) { if (options.dryRun) {
console.warn('Not Publishing because --dryRun was passed'); console.warn('Not Publishing because --dryRun was passed');
@ -174,6 +163,18 @@ const VALID_AUTHORS_FOR_LATEST = [
} }
} }
if (!options.local && (!distTag || distTag === 'latest')) {
// We are only expecting non-local latest releases to be performed within publish.yml on GitHub
const author = process.env.GITHUB_ACTOR ?? '';
if (!VALID_AUTHORS_FOR_LATEST.includes(author)) {
throw new Error(
`The GitHub user "${author}" is not allowed to publish to "latest". Please request one of the following users to carry out the release: ${VALID_AUTHORS_FOR_LATEST.join(
', '
)}`
);
}
}
// Run with dynamic output-style so that we have more minimal logs by default but still always see errors // Run with dynamic output-style so that we have more minimal logs by default but still always see errors
let publishCommand = `pnpm nx release publish --registry=${getRegistry()} --tag=${distTag} --output-style=dynamic --parallel=8`; let publishCommand = `pnpm nx release publish --registry=${getRegistry()} --tag=${distTag} --output-style=dynamic --parallel=8`;
if (options.dryRun) { if (options.dryRun) {
@ -184,17 +185,17 @@ const VALID_AUTHORS_FOR_LATEST = [
stdio: [0, 1, 2], stdio: [0, 1, 2],
maxBuffer: LARGE_BUFFER, maxBuffer: LARGE_BUFFER,
}); });
}
let version; let version;
if (['minor', 'major', 'patch'].includes(options.version)) { if (['minor', 'major', 'patch'].includes(options.version)) {
version = execSync(`npm view nx@${distTag} version`).toString().trim(); version = execSync(`npm view nx@${distTag} version`).toString().trim();
} else { } else {
version = options.version; version = options.version;
} }
console.log(chalk.green` > Published version: ` + version); console.log(chalk.green` > Published version: ` + version);
console.log(chalk.dim` Use: npx create-nx-workspace@${version}\n`); console.log(chalk.dim` Use: npx create-nx-workspace@${version}\n`);
}
process.exit(0); process.exit(0);
})(); })();