fix(core): add conditional compilation for WASM build compatibility (#31491)

## Current Behavior

The `pnpm build:wasm` command fails with compilation errors due to
missing dependencies and system-dependent features being included in
WASM builds.

## Expected Behavior

WASM builds should compile successfully by excluding features that
require system access (IPC, terminals, file locking, etc.) while
maintaining these features for native builds.

## Related Issue(s)

Fixes WASM build compatibility issues

## Changes Made

### Core Changes
- Added conditional compilation flags (`#[cfg(not(target_arch =
"wasm32"))]`) to IDE console modules
- Made `socket_path` module conditional for non-WASM targets only
- Fixed unused import warnings for WASM builds in `file_lock.rs` and
`walker.rs`

### Generated File Updates  
- Updated TypeScript definitions and JavaScript bindings to reflect
conditional compilation
- WASM builds now exclude system-dependent features like terminal UI and
database connections

### Technical Details
The IDE console functionality depends on:
- `interprocess` crate for IPC communication
- `jsonrpsee` crate for JSON-RPC messaging  
- Terminal and file system features not available in WASM

These features are now properly isolated for native targets only while
maintaining full functionality for standard Node.js builds.

## Testing
-  `pnpm build:wasm` now passes successfully
-  Generated bindings properly exclude WASM-incompatible features
-  Native builds retain all existing functionality
This commit is contained in:
Jason Jean 2025-06-09 09:43:22 -04:00 committed by GitHub
parent e68d884d63
commit 25dc8b64ae
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
8 changed files with 121 additions and 93 deletions

View File

@ -1,13 +1,16 @@
When responding to queries about this repository:
1. Use the `nx_workspace` mcp tool for understanding the workspace architecture when appropriate
2. When working in projects, use the `nx_project` mcp tool to analyze and understand the specific project structure and dependencies
2. When working in projects, use the `nx_project` mcp tool to analyze and understand the specific project structure and
dependencies
3. Suggest relevant commands from the "Essential Commands" section when applicable
4. Highlight Nx's focus on monorepos and its key features like smart task execution, code generation, and project graph analysis
4. Highlight Nx's focus on monorepos and its key features like smart task execution, code generation, and project graph
analysis
5. Mention the plugin ecosystem and support for various frameworks when relevant
6. Emphasize the importance of running the full validation suite before committing changes
Always strive to provide accurate, helpful responses that align with the best practices and workflows described in this file.
Always strive to provide accurate, helpful responses that align with the best practices and workflows described in this
file.
## GitHub Issue Response Mode
@ -41,7 +44,8 @@ In this mode:
3. Make all necessary code changes. Please make multiple commits so that the changes are easier to review.
4. Run appropriate tests and validation
5. If the tests, are not passing, please fix the issues and continue doing this up to 3 more times until the tests pass
6. Once the tests pass, push a branch and then suggest opening a PR which has a description of the changes made, and that
6. Once the tests pass, push a branch and then suggest opening a PR which has a description of the changes made, and
that
it make sure that it explicitly says "Fixes #ISSUE_NUMBER" to automatically close the issue when the PR is merged.
## Avoid making changes to generated files
@ -62,7 +66,9 @@ After code changes are made, please make sure to format the files with prettier
nx prepush
```
If the prepush validation suite fails, please fix the issues before proceeding with your work. This ensures that all code adheres to the project's standards and passes all tests.
If the prepush validation suite fails, please fix the issues before proceeding with your work. This ensures that all
code adheres to the project's standards and passes all tests. DO NOT make a new commit to fix these issues. Instead,
amend the current commit.
### Testing Changes
@ -104,9 +110,11 @@ gh issue list --label "bug" --state "open" --json number,title,body,labels --jq
gh issue list --assignee "@me" --json number,title,body,state --jq '.[]'
```
**Tip**: Instead of running `gh issue view` multiple times, use `gh issue list` with JSON output and filtering to gather information about multiple issues in a single command. This is much more efficient than viewing issues one at a time.
**Tip**: Instead of running `gh issue view` multiple times, use `gh issue list` with JSON output and filtering to gather
information about multiple issues in a single command. This is much more efficient than viewing issues one at a time.
**Always provide clickable links**: When discussing GitHub issues or PRs, always include the full GitHub URL so the user can easily open them in their browser. For example:
**Always provide clickable links**: When discussing GitHub issues or PRs, always include the full GitHub URL so the user
can easily open them in their browser. For example:
- Issue #12345: https://github.com/nrwl/nx/issues/12345
- PR #67890: https://github.com/nrwl/nx/pull/67890
@ -139,7 +147,8 @@ Use the testing workflow from the "Essential Commands" section.
## Pull Request Template
**IMPORTANT**: When creating a pull request, you MUST fill in the template found in `.github/PULL_REQUEST_TEMPLATE.md`. Do not leave the template sections empty. The template includes:
**IMPORTANT**: When creating a pull request, you MUST fill in the template found in `.github/PULL_REQUEST_TEMPLATE.md`.
Do not leave the template sections empty. The template includes:
### Required Sections

View File

@ -1,4 +1,5 @@
pub mod detection;
pub mod install;
#[cfg(not(target_arch = "wasm32"))]
pub mod nx_console;
mod preferences;

View File

@ -1,4 +1,6 @@
#[cfg(not(target_arch = "wasm32"))]
mod ipc_transport;
#[cfg(not(target_arch = "wasm32"))]
pub mod messaging;
// Re-export from ide/detection for backward compatibility

View File

@ -59,51 +59,57 @@ function __napi_rs_initialize_modules(__napiInstance) {
__napiInstance.exports['__napi_register__get_transformable_outputs_5']?.()
__napiInstance.exports['__napi_register__hash_array_6']?.()
__napiInstance.exports['__napi_register__hash_file_7']?.()
__napiInstance.exports['__napi_register__log_info_8']?.()
__napiInstance.exports['__napi_register__log_error_9']?.()
__napiInstance.exports['__napi_register__IS_WASM_10']?.()
__napiInstance.exports['__napi_register__get_binary_target_11']?.()
__napiInstance.exports['__napi_register__ImportResult_struct_12']?.()
__napiInstance.exports['__napi_register__find_imports_13']?.()
__napiInstance.exports['__napi_register__transfer_project_graph_14']?.()
__napiInstance.exports['__napi_register__ExternalNode_struct_15']?.()
__napiInstance.exports['__napi_register__Target_struct_16']?.()
__napiInstance.exports['__napi_register__Project_struct_17']?.()
__napiInstance.exports['__napi_register__ProjectGraph_struct_18']?.()
__napiInstance.exports['__napi_register__HashPlanner_struct_19']?.()
__napiInstance.exports['__napi_register__HashPlanner_impl_23']?.()
__napiInstance.exports['__napi_register__HashDetails_struct_24']?.()
__napiInstance.exports['__napi_register__HasherOptions_struct_25']?.()
__napiInstance.exports['__napi_register__TaskHasher_struct_26']?.()
__napiInstance.exports['__napi_register__TaskHasher_impl_29']?.()
__napiInstance.exports['__napi_register__Task_struct_30']?.()
__napiInstance.exports['__napi_register__TaskTarget_struct_31']?.()
__napiInstance.exports['__napi_register__TaskResult_struct_32']?.()
__napiInstance.exports['__napi_register__TaskGraph_struct_33']?.()
__napiInstance.exports['__napi_register__FileData_struct_34']?.()
__napiInstance.exports['__napi_register__InputsInput_struct_35']?.()
__napiInstance.exports['__napi_register__FileSetInput_struct_36']?.()
__napiInstance.exports['__napi_register__RuntimeInput_struct_37']?.()
__napiInstance.exports['__napi_register__EnvironmentInput_struct_38']?.()
__napiInstance.exports['__napi_register__ExternalDependenciesInput_struct_39']?.()
__napiInstance.exports['__napi_register__DepsOutputsInput_struct_40']?.()
__napiInstance.exports['__napi_register__NxJson_struct_41']?.()
__napiInstance.exports['__napi_register__FileLock_struct_42']?.()
__napiInstance.exports['__napi_register__FileLock_impl_44']?.()
__napiInstance.exports['__napi_register__WorkspaceContext_struct_45']?.()
__napiInstance.exports['__napi_register__WorkspaceContext_impl_56']?.()
__napiInstance.exports['__napi_register__WorkspaceErrors_57']?.()
__napiInstance.exports['__napi_register__NxWorkspaceFiles_struct_58']?.()
__napiInstance.exports['__napi_register__NxWorkspaceFilesExternals_struct_59']?.()
__napiInstance.exports['__napi_register__UpdatedWorkspaceFiles_struct_60']?.()
__napiInstance.exports['__napi_register__FileMap_struct_61']?.()
__napiInstance.exports['__napi_register____test_only_transfer_file_map_62']?.()
__napiInstance.exports['__napi_register__can_install_nx_console_8']?.()
__napiInstance.exports['__napi_register__install_nx_console_9']?.()
__napiInstance.exports['__napi_register__NxConsolePreferences_struct_10']?.()
__napiInstance.exports['__napi_register__NxConsolePreferences_impl_14']?.()
__napiInstance.exports['__napi_register__log_debug_15']?.()
__napiInstance.exports['__napi_register__log_error_16']?.()
__napiInstance.exports['__napi_register__IS_WASM_17']?.()
__napiInstance.exports['__napi_register__get_binary_target_18']?.()
__napiInstance.exports['__napi_register__ImportResult_struct_19']?.()
__napiInstance.exports['__napi_register__find_imports_20']?.()
__napiInstance.exports['__napi_register__transfer_project_graph_21']?.()
__napiInstance.exports['__napi_register__ExternalNode_struct_22']?.()
__napiInstance.exports['__napi_register__Target_struct_23']?.()
__napiInstance.exports['__napi_register__Project_struct_24']?.()
__napiInstance.exports['__napi_register__ProjectGraph_struct_25']?.()
__napiInstance.exports['__napi_register__HashPlanner_struct_26']?.()
__napiInstance.exports['__napi_register__HashPlanner_impl_30']?.()
__napiInstance.exports['__napi_register__HashDetails_struct_31']?.()
__napiInstance.exports['__napi_register__HasherOptions_struct_32']?.()
__napiInstance.exports['__napi_register__TaskHasher_struct_33']?.()
__napiInstance.exports['__napi_register__TaskHasher_impl_36']?.()
__napiInstance.exports['__napi_register__Task_struct_37']?.()
__napiInstance.exports['__napi_register__TaskTarget_struct_38']?.()
__napiInstance.exports['__napi_register__TaskResult_struct_39']?.()
__napiInstance.exports['__napi_register__TaskGraph_struct_40']?.()
__napiInstance.exports['__napi_register__FileData_struct_41']?.()
__napiInstance.exports['__napi_register__InputsInput_struct_42']?.()
__napiInstance.exports['__napi_register__FileSetInput_struct_43']?.()
__napiInstance.exports['__napi_register__RuntimeInput_struct_44']?.()
__napiInstance.exports['__napi_register__EnvironmentInput_struct_45']?.()
__napiInstance.exports['__napi_register__ExternalDependenciesInput_struct_46']?.()
__napiInstance.exports['__napi_register__DepsOutputsInput_struct_47']?.()
__napiInstance.exports['__napi_register__NxJson_struct_48']?.()
__napiInstance.exports['__napi_register__FileLock_struct_49']?.()
__napiInstance.exports['__napi_register__FileLock_impl_51']?.()
__napiInstance.exports['__napi_register__WorkspaceContext_struct_52']?.()
__napiInstance.exports['__napi_register__WorkspaceContext_impl_63']?.()
__napiInstance.exports['__napi_register__WorkspaceErrors_64']?.()
__napiInstance.exports['__napi_register__NxWorkspaceFiles_struct_65']?.()
__napiInstance.exports['__napi_register__NxWorkspaceFilesExternals_struct_66']?.()
__napiInstance.exports['__napi_register__UpdatedWorkspaceFiles_struct_67']?.()
__napiInstance.exports['__napi_register__FileMap_struct_68']?.()
__napiInstance.exports['__napi_register____test_only_transfer_file_map_69']?.()
}
export const FileLock = __napiModule.exports.FileLock
export const HashPlanner = __napiModule.exports.HashPlanner
export const ImportResult = __napiModule.exports.ImportResult
export const NxConsolePreferences = __napiModule.exports.NxConsolePreferences
export const TaskHasher = __napiModule.exports.TaskHasher
export const WorkspaceContext = __napiModule.exports.WorkspaceContext
export const canInstallNxConsole = __napiModule.exports.canInstallNxConsole
export const copy = __napiModule.exports.copy
export const expandOutputs = __napiModule.exports.expandOutputs
export const findImports = __napiModule.exports.findImports
@ -112,9 +118,10 @@ export const getFilesForOutputs = __napiModule.exports.getFilesForOutputs
export const getTransformableOutputs = __napiModule.exports.getTransformableOutputs
export const hashArray = __napiModule.exports.hashArray
export const hashFile = __napiModule.exports.hashFile
export const installNxConsole = __napiModule.exports.installNxConsole
export const IS_WASM = __napiModule.exports.IS_WASM
export const logDebug = __napiModule.exports.logDebug
export const logError = __napiModule.exports.logError
export const logInfo = __napiModule.exports.logInfo
export const remove = __napiModule.exports.remove
export const testOnlyTransferFileMap = __napiModule.exports.testOnlyTransferFileMap
export const transferProjectGraph = __napiModule.exports.transferProjectGraph

View File

@ -90,51 +90,57 @@ function __napi_rs_initialize_modules(__napiInstance) {
__napiInstance.exports['__napi_register__get_transformable_outputs_5']?.()
__napiInstance.exports['__napi_register__hash_array_6']?.()
__napiInstance.exports['__napi_register__hash_file_7']?.()
__napiInstance.exports['__napi_register__log_info_8']?.()
__napiInstance.exports['__napi_register__log_error_9']?.()
__napiInstance.exports['__napi_register__IS_WASM_10']?.()
__napiInstance.exports['__napi_register__get_binary_target_11']?.()
__napiInstance.exports['__napi_register__ImportResult_struct_12']?.()
__napiInstance.exports['__napi_register__find_imports_13']?.()
__napiInstance.exports['__napi_register__transfer_project_graph_14']?.()
__napiInstance.exports['__napi_register__ExternalNode_struct_15']?.()
__napiInstance.exports['__napi_register__Target_struct_16']?.()
__napiInstance.exports['__napi_register__Project_struct_17']?.()
__napiInstance.exports['__napi_register__ProjectGraph_struct_18']?.()
__napiInstance.exports['__napi_register__HashPlanner_struct_19']?.()
__napiInstance.exports['__napi_register__HashPlanner_impl_23']?.()
__napiInstance.exports['__napi_register__HashDetails_struct_24']?.()
__napiInstance.exports['__napi_register__HasherOptions_struct_25']?.()
__napiInstance.exports['__napi_register__TaskHasher_struct_26']?.()
__napiInstance.exports['__napi_register__TaskHasher_impl_29']?.()
__napiInstance.exports['__napi_register__Task_struct_30']?.()
__napiInstance.exports['__napi_register__TaskTarget_struct_31']?.()
__napiInstance.exports['__napi_register__TaskResult_struct_32']?.()
__napiInstance.exports['__napi_register__TaskGraph_struct_33']?.()
__napiInstance.exports['__napi_register__FileData_struct_34']?.()
__napiInstance.exports['__napi_register__InputsInput_struct_35']?.()
__napiInstance.exports['__napi_register__FileSetInput_struct_36']?.()
__napiInstance.exports['__napi_register__RuntimeInput_struct_37']?.()
__napiInstance.exports['__napi_register__EnvironmentInput_struct_38']?.()
__napiInstance.exports['__napi_register__ExternalDependenciesInput_struct_39']?.()
__napiInstance.exports['__napi_register__DepsOutputsInput_struct_40']?.()
__napiInstance.exports['__napi_register__NxJson_struct_41']?.()
__napiInstance.exports['__napi_register__FileLock_struct_42']?.()
__napiInstance.exports['__napi_register__FileLock_impl_44']?.()
__napiInstance.exports['__napi_register__WorkspaceContext_struct_45']?.()
__napiInstance.exports['__napi_register__WorkspaceContext_impl_56']?.()
__napiInstance.exports['__napi_register__WorkspaceErrors_57']?.()
__napiInstance.exports['__napi_register__NxWorkspaceFiles_struct_58']?.()
__napiInstance.exports['__napi_register__NxWorkspaceFilesExternals_struct_59']?.()
__napiInstance.exports['__napi_register__UpdatedWorkspaceFiles_struct_60']?.()
__napiInstance.exports['__napi_register__FileMap_struct_61']?.()
__napiInstance.exports['__napi_register____test_only_transfer_file_map_62']?.()
__napiInstance.exports['__napi_register__can_install_nx_console_8']?.()
__napiInstance.exports['__napi_register__install_nx_console_9']?.()
__napiInstance.exports['__napi_register__NxConsolePreferences_struct_10']?.()
__napiInstance.exports['__napi_register__NxConsolePreferences_impl_14']?.()
__napiInstance.exports['__napi_register__log_debug_15']?.()
__napiInstance.exports['__napi_register__log_error_16']?.()
__napiInstance.exports['__napi_register__IS_WASM_17']?.()
__napiInstance.exports['__napi_register__get_binary_target_18']?.()
__napiInstance.exports['__napi_register__ImportResult_struct_19']?.()
__napiInstance.exports['__napi_register__find_imports_20']?.()
__napiInstance.exports['__napi_register__transfer_project_graph_21']?.()
__napiInstance.exports['__napi_register__ExternalNode_struct_22']?.()
__napiInstance.exports['__napi_register__Target_struct_23']?.()
__napiInstance.exports['__napi_register__Project_struct_24']?.()
__napiInstance.exports['__napi_register__ProjectGraph_struct_25']?.()
__napiInstance.exports['__napi_register__HashPlanner_struct_26']?.()
__napiInstance.exports['__napi_register__HashPlanner_impl_30']?.()
__napiInstance.exports['__napi_register__HashDetails_struct_31']?.()
__napiInstance.exports['__napi_register__HasherOptions_struct_32']?.()
__napiInstance.exports['__napi_register__TaskHasher_struct_33']?.()
__napiInstance.exports['__napi_register__TaskHasher_impl_36']?.()
__napiInstance.exports['__napi_register__Task_struct_37']?.()
__napiInstance.exports['__napi_register__TaskTarget_struct_38']?.()
__napiInstance.exports['__napi_register__TaskResult_struct_39']?.()
__napiInstance.exports['__napi_register__TaskGraph_struct_40']?.()
__napiInstance.exports['__napi_register__FileData_struct_41']?.()
__napiInstance.exports['__napi_register__InputsInput_struct_42']?.()
__napiInstance.exports['__napi_register__FileSetInput_struct_43']?.()
__napiInstance.exports['__napi_register__RuntimeInput_struct_44']?.()
__napiInstance.exports['__napi_register__EnvironmentInput_struct_45']?.()
__napiInstance.exports['__napi_register__ExternalDependenciesInput_struct_46']?.()
__napiInstance.exports['__napi_register__DepsOutputsInput_struct_47']?.()
__napiInstance.exports['__napi_register__NxJson_struct_48']?.()
__napiInstance.exports['__napi_register__FileLock_struct_49']?.()
__napiInstance.exports['__napi_register__FileLock_impl_51']?.()
__napiInstance.exports['__napi_register__WorkspaceContext_struct_52']?.()
__napiInstance.exports['__napi_register__WorkspaceContext_impl_63']?.()
__napiInstance.exports['__napi_register__WorkspaceErrors_64']?.()
__napiInstance.exports['__napi_register__NxWorkspaceFiles_struct_65']?.()
__napiInstance.exports['__napi_register__NxWorkspaceFilesExternals_struct_66']?.()
__napiInstance.exports['__napi_register__UpdatedWorkspaceFiles_struct_67']?.()
__napiInstance.exports['__napi_register__FileMap_struct_68']?.()
__napiInstance.exports['__napi_register____test_only_transfer_file_map_69']?.()
}
module.exports.FileLock = __napiModule.exports.FileLock
module.exports.HashPlanner = __napiModule.exports.HashPlanner
module.exports.ImportResult = __napiModule.exports.ImportResult
module.exports.NxConsolePreferences = __napiModule.exports.NxConsolePreferences
module.exports.TaskHasher = __napiModule.exports.TaskHasher
module.exports.WorkspaceContext = __napiModule.exports.WorkspaceContext
module.exports.canInstallNxConsole = __napiModule.exports.canInstallNxConsole
module.exports.copy = __napiModule.exports.copy
module.exports.expandOutputs = __napiModule.exports.expandOutputs
module.exports.findImports = __napiModule.exports.findImports
@ -143,9 +149,10 @@ module.exports.getFilesForOutputs = __napiModule.exports.getFilesForOutputs
module.exports.getTransformableOutputs = __napiModule.exports.getTransformableOutputs
module.exports.hashArray = __napiModule.exports.hashArray
module.exports.hashFile = __napiModule.exports.hashFile
module.exports.installNxConsole = __napiModule.exports.installNxConsole
module.exports.IS_WASM = __napiModule.exports.IS_WASM
module.exports.logDebug = __napiModule.exports.logDebug
module.exports.logError = __napiModule.exports.logError
module.exports.logInfo = __napiModule.exports.logInfo
module.exports.remove = __napiModule.exports.remove
module.exports.testOnlyTransferFileMap = __napiModule.exports.testOnlyTransferFileMap
module.exports.transferProjectGraph = __napiModule.exports.transferProjectGraph

View File

@ -1,8 +1,8 @@
use napi::bindgen_prelude::*;
use std::{
fs::{self, OpenOptions},
path::Path,
};
use std::fs;
#[cfg(not(target_arch = "wasm32"))]
use std::{fs::OpenOptions, path::Path};
#[cfg(not(target_arch = "wasm32"))]
use tracing::trace;
#[cfg(not(target_arch = "wasm32"))]
@ -53,7 +53,7 @@ impl FileLock {
}
Ok(Self {
file: file,
file,
locked: file_lock.is_err(),
lock_file_path,
})

View File

@ -3,6 +3,7 @@ mod get_mod_time;
pub mod json;
mod normalize_trait;
pub mod path;
#[cfg(not(target_arch = "wasm32"))]
pub mod socket_path;
pub use find_matching_projects::*;

View File

@ -4,6 +4,7 @@ use std::path::{Path, PathBuf};
use crate::native::glob::build_glob_set;
#[cfg(not(target_arch = "wasm32"))]
use crate::native::logger::enable_logger;
use crate::native::utils::{Normalize, get_mod_time};
use walkdir::WalkDir;