miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(rspack): ensure baseHref is set when provided #28455 (#28660)

Browse Source 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
The `@nx/rspack:rspack` executor supports `baseHref` as an option, but
we do not set it in the `rspack.HtmlRspackPlugin`.


## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Ensure if `baseHref` is set, we pass it to `rspack.HtmlRspackPlugin`

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #28455
This commit is contained in:
Colum Ferry 2024-10-28 13:43:43 +00:00 committed by GitHub
parent 0d2a696443
commit 2936bdcb3d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/rspack/src/utils/with-web.ts
View File

@ -116,6 +116,7 @@ export function withWeb(opts: WithWebOptions = {}) {
template: options.indexHtml template: options.indexHtml
? path.join(context.root, options.indexHtml) ? path.join(context.root, options.indexHtml)
: path.join(projectRoot, 'src/index.html'), : path.join(projectRoot, 'src/index.html'),
...(options.baseHref ? { base: { href: options.baseHref } } : {}),
}), }),
new rspack.EnvironmentPlugin({ new rspack.EnvironmentPlugin({
NODE_ENV: 'development', NODE_ENV: 'development',