miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(core): prevent duplicate nx cloud logs from global and local nx invocations (#31641)

Browse Source 
## Current Behavior

When Nx is invoked from a global install, both the global and local
versions register process exit handlers that flush captured logs. This
causes Nx Cloud logs to be displayed twice - once from the global
installation and once from the local installation.

## Expected Behavior

Only the local Nx installation should handle log flushing, preventing
duplicate log output. The process exit handler is moved from the global
entry point (nx.ts) to the local entry point (init-local.ts) so that log
flushing only occurs once.

## Related Issue(s)

This change requires users to update their globally installed Nx to
fully resolve the duplicate logging issue, as the fix is now in the
local version that gets invoked.
This commit is contained in:
Jason Jean 2025-06-18 14:23:43 -04:00 committed by GitHub
parent 1c8f964c33
commit 29b14b1bd3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/nx/bin/init-local.ts
View File

@ -14,6 +14,12 @@ export async function initLocal(workspace: WorkspaceTypeAndRoot) {
process.env.NX_CLI_SET = 'true'; process.env.NX_CLI_SET = 'true';
try { try {
// In case Nx Cloud forcibly exits while the TUI is running, ensure the terminal is restored etc.
process.on('exit', (...args) => {
if (typeof globalThis.tuiOnProcessExit === 'function') {
globalThis.tuiOnProcessExit(...args);
}
});
performance.mark('init-local'); performance.mark('init-local');
if (workspace.type !== 'nx' && shouldDelegateToAngularCLI()) { if (workspace.type !== 'nx' && shouldDelegateToAngularCLI()) {

7
packages/nx/bin/nx.ts
View File

@ -22,13 +22,6 @@ import { setupWorkspaceContext } from '../src/utils/workspace-context';
import { daemonClient } from '../src/daemon/client/client'; import { daemonClient } from '../src/daemon/client/client';
import { removeDbConnections } from '../src/utils/db-connection'; import { removeDbConnections } from '../src/utils/db-connection';
// In case Nx Cloud forcibly exits while the TUI is running, ensure the terminal is restored etc.
process.on('exit', (...args) => {
if (typeof globalThis.tuiOnProcessExit === 'function') {
globalThis.tuiOnProcessExit(...args);
}
});
async function main() { async function main() {
if ( if (
process.argv[2] !== 'report' && process.argv[2] !== 'report' &&