miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(bundling): support additionalEntryPoints properly (#14773)

Browse Source
This commit is contained in:
Jack Hsu 2023-02-02 13:20:18 -05:00 committed by GitHub
parent 0d33bb076b
commit 2d566593c0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
e2e/esbuild/src/esbuild.test.ts
View File

@ -172,4 +172,22 @@ describe('EsBuild Plugin', () => {
// Check that the build is correct
expect(runCommand(`node dist/libs/${myPkg}`)).toMatch(/new API/);
}, 120_000);
it('should support additional entry points', () => {
const myPkg = uniq('my-pkg');
runCLI(`generate @nrwl/js:lib ${myPkg} --bundler=esbuild`);
updateFile(`libs/${myPkg}/src/index.ts`, `console.log('main');\n`);
updateFile(`libs/${myPkg}/src/extra.ts`, `console.log('extra');\n`);
updateProjectConfig(myPkg, (json) => {
json.targets.build.options.additionalEntryPoints = [
`libs/${myPkg}/src/extra.ts`,
];
return json;
});
runCommand(`build ${myPkg}`);
expect(runCommand(`node dist/libs/${myPkg}/main.js`)).toMatch(/main/);
expect(runCommand(`node dist/libs/${myPkg}/extra.js`)).toMatch(/extra/);
});
});

2
packages/esbuild/src/executors/esbuild/esbuild.impl.ts
View File

@ -179,6 +179,7 @@ export async function* esbuildExecutor(
yield {
success: buildResult.errors.length === 0,
// Need to call getOutfile directly in the case of bundle=false and outfile is not set for esbuild.
// This field is needed for `@nrwl/js:node` executor to work.
outfile: join(context.root, getOutfile(format, options, context)),
};
}
@ -223,6 +224,7 @@ export async function* esbuildExecutor(
next({
success,
// Need to call getOutfile directly in the case of bundle=false and outfile is not set for esbuild.
// This field is needed for `@nrwl/js:node` executor to work.
outfile: join(
context.root,
getOutfile(format, options, context)

1
packages/esbuild/src/executors/esbuild/lib/normalize.spec.ts
View File

@ -38,6 +38,7 @@ describe('normalizeOptions', () => {
tsConfig: 'apps/myapp/tsconfig.app.json',
project: 'apps/myapp/package.json',
assets: [],
outputFileName: 'index.js',
additionalEntryPoints: ['apps/myapp/src/extra-entry.ts'],
singleEntry: false,
external: [],

5
packages/esbuild/src/executors/esbuild/lib/normalize.ts
View File

@ -18,6 +18,10 @@ export function normalizeOptions(
...rest,
external: options.external ?? [],
singleEntry: false,
// Use the `main` file name as the output file name.
// This is needed for `@nrwl/js:node` to know the main file to execute.
// NOTE: The .js default extension may be replaced later in getOutfile() call.
outputFileName: `${parse(options.main).name}.js`,
};
} else {
return {
@ -25,6 +29,7 @@ export function normalizeOptions(
external: options.external ?? [],
singleEntry: true,
outputFileName:
// NOTE: The .js default extension may be replaced later in getOutfile() call.
options.outputFileName ?? `${parse(options.main).name}.js`,
};
}