From 2d9ecfd1fcf2a32c123e80c1d7527d3ff99bf973 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Leosvel=20P=C3=A9rez=20Espinosa?= Date: Mon, 4 Mar 2024 19:11:01 +0100 Subject: [PATCH] fix(testing): close cypress web server correctly on windows (#22125) --- packages/cypress/plugins/cypress-preset.ts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/cypress/plugins/cypress-preset.ts b/packages/cypress/plugins/cypress-preset.ts index 7a77496abd..640a7100c7 100644 --- a/packages/cypress/plugins/cypress-preset.ts +++ b/packages/cypress/plugins/cypress-preset.ts @@ -75,9 +75,13 @@ function startWebServer(webServerCommand: string) { }); return () => { - // child.kill() does not work on linux - // process.kill will kill the whole process group on unix - process.kill(-serverProcess.pid, 'SIGKILL'); + if (process.platform === 'win32') { + serverProcess.kill(); + } else { + // child.kill() does not work on linux + // process.kill will kill the whole process group on unix + process.kill(-serverProcess.pid, 'SIGKILL'); + } }; }