miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(rspack): allow typechecking during serve #29267 (#30558)

Browse Source 
## Current Behavior
The `NxRspackAppPlugin` and `NxWebpackAppPlugin` will not provide
typechecking if using TS Solution setup because it already has a
typecheck target.
However, this means that typechecking will not be run during serve.

## Expected Behavior
Allow typechecking to run during serve even with TS Solution setup

## Related Issue(s)

Fixes #29267
This commit is contained in:
Colum Ferry 2025-04-02 09:26:35 +01:00 committed by GitHub
parent 8dceb6c17d
commit 2dbff35de9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/rspack/src/plugins/utils/apply-base-config.ts
View File

@ -240,8 +240,13 @@ function applyNxDependentConfig(
plugins.push(new NxTsconfigPathsRspackPlugin({ ...options, tsConfig })); plugins.push(new NxTsconfigPathsRspackPlugin({ ...options, tsConfig }));
} }
// New TS Solution already has a typecheck target // New TS Solution already has a typecheck target but allow it to run during serve
if (!options?.skipTypeChecking && !isUsingTsSolution) { if (
(!options?.skipTypeChecking && !isUsingTsSolution) ||
(isUsingTsSolution &&
options?.skipTypeChecking === false &&
process.env['WEBPACK_SERVE'])
) {
const { TsCheckerRspackPlugin } = require('ts-checker-rspack-plugin'); const { TsCheckerRspackPlugin } = require('ts-checker-rspack-plugin');
plugins.push( plugins.push(
new TsCheckerRspackPlugin({ new TsCheckerRspackPlugin({

9
packages/webpack/src/plugins/nx-webpack-plugin/lib/apply-base-config.ts
View File

@ -243,8 +243,13 @@ function applyNxDependentConfig(
plugins.push(new NxTsconfigPathsWebpackPlugin({ ...options, tsConfig })); plugins.push(new NxTsconfigPathsWebpackPlugin({ ...options, tsConfig }));
} }
// New TS Solution already has a typecheck target // New TS Solution already has a typecheck target but allow it to run during serve
if (!options?.skipTypeChecking && !isUsingTsSolution) { if (
(!options?.skipTypeChecking && !isUsingTsSolution) ||
(isUsingTsSolution &&
options?.skipTypeChecking === false &&
process.env['WEBPACK_SERVE'])
) {
const ForkTsCheckerWebpackPlugin = require('fork-ts-checker-webpack-plugin'); const ForkTsCheckerWebpackPlugin = require('fork-ts-checker-webpack-plugin');
plugins.push( plugins.push(
new ForkTsCheckerWebpackPlugin({ new ForkTsCheckerWebpackPlugin({