miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(graph): enable action on the ViewOnGraph button regardless of the… (#28863)

Browse Source 
## Current Behavior
ViewOnGraph button doesn't work until you open the accordion

## Expected Behavior
ViewOnGraph button should direct to graph without the need to open the
accordion first.

I believe it's better from the UX prespective that user shouldn't click
twice on the same button to fire its action.
This commit is contained in:
Ahmed Hakeem 2024-11-11 02:50:53 -08:00 committed by GitHub
parent f56e0a30bf
commit 3643f66b61
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
graph/ui-project-details/src/lib/target-configuration-details-header/target-configuration-details-header.tsx
View File

@ -166,9 +166,6 @@ export const TargetConfigurationDetailsHeader = ({
data-tooltip={isCollasped ? false : 'View in Task Graph'} data-tooltip={isCollasped ? false : 'View in Task Graph'}
data-tooltip-align-right data-tooltip-align-right
onClick={(e) => { onClick={(e) => {
if (isCollasped) {
return;
}
e.stopPropagation(); e.stopPropagation();
onViewInTaskGraph({ projectName, targetName }); onViewInTaskGraph({ projectName, targetName });
}} }}