diff --git a/packages/js/src/utils/code-frames/identifiers.ts b/packages/js/src/utils/code-frames/identifiers.ts index 6a31b6c5f9..db0b75aab3 100644 --- a/packages/js/src/utils/code-frames/identifiers.ts +++ b/packages/js/src/utils/code-frames/identifiers.ts @@ -1,169 +1,41 @@ -// Adapted from https://raw.githubusercontent.com/babel/babel/6a00cbe/packages/babel-helper-validator-identifier/src/identifier.js - -// ## Character codes -const uppercaseA = 65; -const lowercaseA = 97; -const dollarSign = 36; -const lowercaseZ = 122; -const uppercaseZ = 90; -const underscore = 95; -const digit0 = 48; -const colon = 58; - -// ## Character categories - -// Big ugly regular expressions that match characters in the -// whitespace, identifier, and identifier-start categories. These -// are only applied when a character is found to actually have a -// code point between 0x80 and 0xffff. -// Generated by `scripts/generate-identifier-regex.js`. - -/* prettier-ignore */ -let nonASCIIidentifierStartChars = '\xaa\xb5\xba\xc0-\xd6\xd8-\xf6\xf8-\u02c1\u02c6-\u02d1\u02e0-\u02e4\u02ec\u02ee\u0370-\u0374\u0376\u0377\u037a-\u037d\u037f\u0386\u0388-\u038a\u038c\u038e-\u03a1\u03a3-\u03f5\u03f7-\u0481\u048a-\u052f\u0531-\u0556\u0559\u0560-\u0588\u05d0-\u05ea\u05ef-\u05f2\u0620-\u064a\u066e\u066f\u0671-\u06d3\u06d5\u06e5\u06e6\u06ee\u06ef\u06fa-\u06fc\u06ff\u0710\u0712-\u072f\u074d-\u07a5\u07b1\u07ca-\u07ea\u07f4\u07f5\u07fa\u0800-\u0815\u081a\u0824\u0828\u0840-\u0858\u0860-\u086a\u08a0-\u08b4\u08b6-\u08c7\u0904-\u0939\u093d\u0950\u0958-\u0961\u0971-\u0980\u0985-\u098c\u098f\u0990\u0993-\u09a8\u09aa-\u09b0\u09b2\u09b6-\u09b9\u09bd\u09ce\u09dc\u09dd\u09df-\u09e1\u09f0\u09f1\u09fc\u0a05-\u0a0a\u0a0f\u0a10\u0a13-\u0a28\u0a2a-\u0a30\u0a32\u0a33\u0a35\u0a36\u0a38\u0a39\u0a59-\u0a5c\u0a5e\u0a72-\u0a74\u0a85-\u0a8d\u0a8f-\u0a91\u0a93-\u0aa8\u0aaa-\u0ab0\u0ab2\u0ab3\u0ab5-\u0ab9\u0abd\u0ad0\u0ae0\u0ae1\u0af9\u0b05-\u0b0c\u0b0f\u0b10\u0b13-\u0b28\u0b2a-\u0b30\u0b32\u0b33\u0b35-\u0b39\u0b3d\u0b5c\u0b5d\u0b5f-\u0b61\u0b71\u0b83\u0b85-\u0b8a\u0b8e-\u0b90\u0b92-\u0b95\u0b99\u0b9a\u0b9c\u0b9e\u0b9f\u0ba3\u0ba4\u0ba8-\u0baa\u0bae-\u0bb9\u0bd0\u0c05-\u0c0c\u0c0e-\u0c10\u0c12-\u0c28\u0c2a-\u0c39\u0c3d\u0c58-\u0c5a\u0c60\u0c61\u0c80\u0c85-\u0c8c\u0c8e-\u0c90\u0c92-\u0ca8\u0caa-\u0cb3\u0cb5-\u0cb9\u0cbd\u0cde\u0ce0\u0ce1\u0cf1\u0cf2\u0d04-\u0d0c\u0d0e-\u0d10\u0d12-\u0d3a\u0d3d\u0d4e\u0d54-\u0d56\u0d5f-\u0d61\u0d7a-\u0d7f\u0d85-\u0d96\u0d9a-\u0db1\u0db3-\u0dbb\u0dbd\u0dc0-\u0dc6\u0e01-\u0e30\u0e32\u0e33\u0e40-\u0e46\u0e81\u0e82\u0e84\u0e86-\u0e8a\u0e8c-\u0ea3\u0ea5\u0ea7-\u0eb0\u0eb2\u0eb3\u0ebd\u0ec0-\u0ec4\u0ec6\u0edc-\u0edf\u0f00\u0f40-\u0f47\u0f49-\u0f6c\u0f88-\u0f8c\u1000-\u102a\u103f\u1050-\u1055\u105a-\u105d\u1061\u1065\u1066\u106e-\u1070\u1075-\u1081\u108e\u10a0-\u10c5\u10c7\u10cd\u10d0-\u10fa\u10fc-\u1248\u124a-\u124d\u1250-\u1256\u1258\u125a-\u125d\u1260-\u1288\u128a-\u128d\u1290-\u12b0\u12b2-\u12b5\u12b8-\u12be\u12c0\u12c2-\u12c5\u12c8-\u12d6\u12d8-\u1310\u1312-\u1315\u1318-\u135a\u1380-\u138f\u13a0-\u13f5\u13f8-\u13fd\u1401-\u166c\u166f-\u167f\u1681-\u169a\u16a0-\u16ea\u16ee-\u16f8\u1700-\u170c\u170e-\u1711\u1720-\u1731\u1740-\u1751\u1760-\u176c\u176e-\u1770\u1780-\u17b3\u17d7\u17dc\u1820-\u1878\u1880-\u18a8\u18aa\u18b0-\u18f5\u1900-\u191e\u1950-\u196d\u1970-\u1974\u1980-\u19ab\u19b0-\u19c9\u1a00-\u1a16\u1a20-\u1a54\u1aa7\u1b05-\u1b33\u1b45-\u1b4b\u1b83-\u1ba0\u1bae\u1baf\u1bba-\u1be5\u1c00-\u1c23\u1c4d-\u1c4f\u1c5a-\u1c7d\u1c80-\u1c88\u1c90-\u1cba\u1cbd-\u1cbf\u1ce9-\u1cec\u1cee-\u1cf3\u1cf5\u1cf6\u1cfa\u1d00-\u1dbf\u1e00-\u1f15\u1f18-\u1f1d\u1f20-\u1f45\u1f48-\u1f4d\u1f50-\u1f57\u1f59\u1f5b\u1f5d\u1f5f-\u1f7d\u1f80-\u1fb4\u1fb6-\u1fbc\u1fbe\u1fc2-\u1fc4\u1fc6-\u1fcc\u1fd0-\u1fd3\u1fd6-\u1fdb\u1fe0-\u1fec\u1ff2-\u1ff4\u1ff6-\u1ffc\u2071\u207f\u2090-\u209c\u2102\u2107\u210a-\u2113\u2115\u2118-\u211d\u2124\u2126\u2128\u212a-\u2139\u213c-\u213f\u2145-\u2149\u214e\u2160-\u2188\u2c00-\u2c2e\u2c30-\u2c5e\u2c60-\u2ce4\u2ceb-\u2cee\u2cf2\u2cf3\u2d00-\u2d25\u2d27\u2d2d\u2d30-\u2d67\u2d6f\u2d80-\u2d96\u2da0-\u2da6\u2da8-\u2dae\u2db0-\u2db6\u2db8-\u2dbe\u2dc0-\u2dc6\u2dc8-\u2dce\u2dd0-\u2dd6\u2dd8-\u2dde\u3005-\u3007\u3021-\u3029\u3031-\u3035\u3038-\u303c\u3041-\u3096\u309b-\u309f\u30a1-\u30fa\u30fc-\u30ff\u3105-\u312f\u3131-\u318e\u31a0-\u31bf\u31f0-\u31ff\u3400-\u4dbf\u4e00-\u9ffc\ua000-\ua48c\ua4d0-\ua4fd\ua500-\ua60c\ua610-\ua61f\ua62a\ua62b\ua640-\ua66e\ua67f-\ua69d\ua6a0-\ua6ef\ua717-\ua71f\ua722-\ua788\ua78b-\ua7bf\ua7c2-\ua7ca\ua7f5-\ua801\ua803-\ua805\ua807-\ua80a\ua80c-\ua822\ua840-\ua873\ua882-\ua8b3\ua8f2-\ua8f7\ua8fb\ua8fd\ua8fe\ua90a-\ua925\ua930-\ua946\ua960-\ua97c\ua984-\ua9b2\ua9cf\ua9e0-\ua9e4\ua9e6-\ua9ef\ua9fa-\ua9fe\uaa00-\uaa28\uaa40-\uaa42\uaa44-\uaa4b\uaa60-\uaa76\uaa7a\uaa7e-\uaaaf\uaab1\uaab5\uaab6\uaab9-\uaabd\uaac0\uaac2\uaadb-\uaadd\uaae0-\uaaea\uaaf2-\uaaf4\uab01-\uab06\uab09-\uab0e\uab11-\uab16\uab20-\uab26\uab28-\uab2e\uab30-\uab5a\uab5c-\uab69\uab70-\uabe2\uac00-\ud7a3\ud7b0-\ud7c6\ud7cb-\ud7fb\uf900-\ufa6d\ufa70-\ufad9\ufb00-\ufb06\ufb13-\ufb17\ufb1d\ufb1f-\ufb28\ufb2a-\ufb36\ufb38-\ufb3c\ufb3e\ufb40\ufb41\ufb43\ufb44\ufb46-\ufbb1\ufbd3-\ufd3d\ufd50-\ufd8f\ufd92-\ufdc7\ufdf0-\ufdfb\ufe70-\ufe74\ufe76-\ufefc\uff21-\uff3a\uff41-\uff5a\uff66-\uffbe\uffc2-\uffc7\uffca-\uffcf\uffd2-\uffd7\uffda-\uffdc'; -/* prettier-ignore */ -let nonASCIIidentifierChars = '\u200c\u200d\xb7\u0300-\u036f\u0387\u0483-\u0487\u0591-\u05bd\u05bf\u05c1\u05c2\u05c4\u05c5\u05c7\u0610-\u061a\u064b-\u0669\u0670\u06d6-\u06dc\u06df-\u06e4\u06e7\u06e8\u06ea-\u06ed\u06f0-\u06f9\u0711\u0730-\u074a\u07a6-\u07b0\u07c0-\u07c9\u07eb-\u07f3\u07fd\u0816-\u0819\u081b-\u0823\u0825-\u0827\u0829-\u082d\u0859-\u085b\u08d3-\u08e1\u08e3-\u0903\u093a-\u093c\u093e-\u094f\u0951-\u0957\u0962\u0963\u0966-\u096f\u0981-\u0983\u09bc\u09be-\u09c4\u09c7\u09c8\u09cb-\u09cd\u09d7\u09e2\u09e3\u09e6-\u09ef\u09fe\u0a01-\u0a03\u0a3c\u0a3e-\u0a42\u0a47\u0a48\u0a4b-\u0a4d\u0a51\u0a66-\u0a71\u0a75\u0a81-\u0a83\u0abc\u0abe-\u0ac5\u0ac7-\u0ac9\u0acb-\u0acd\u0ae2\u0ae3\u0ae6-\u0aef\u0afa-\u0aff\u0b01-\u0b03\u0b3c\u0b3e-\u0b44\u0b47\u0b48\u0b4b-\u0b4d\u0b55-\u0b57\u0b62\u0b63\u0b66-\u0b6f\u0b82\u0bbe-\u0bc2\u0bc6-\u0bc8\u0bca-\u0bcd\u0bd7\u0be6-\u0bef\u0c00-\u0c04\u0c3e-\u0c44\u0c46-\u0c48\u0c4a-\u0c4d\u0c55\u0c56\u0c62\u0c63\u0c66-\u0c6f\u0c81-\u0c83\u0cbc\u0cbe-\u0cc4\u0cc6-\u0cc8\u0cca-\u0ccd\u0cd5\u0cd6\u0ce2\u0ce3\u0ce6-\u0cef\u0d00-\u0d03\u0d3b\u0d3c\u0d3e-\u0d44\u0d46-\u0d48\u0d4a-\u0d4d\u0d57\u0d62\u0d63\u0d66-\u0d6f\u0d81-\u0d83\u0dca\u0dcf-\u0dd4\u0dd6\u0dd8-\u0ddf\u0de6-\u0def\u0df2\u0df3\u0e31\u0e34-\u0e3a\u0e47-\u0e4e\u0e50-\u0e59\u0eb1\u0eb4-\u0ebc\u0ec8-\u0ecd\u0ed0-\u0ed9\u0f18\u0f19\u0f20-\u0f29\u0f35\u0f37\u0f39\u0f3e\u0f3f\u0f71-\u0f84\u0f86\u0f87\u0f8d-\u0f97\u0f99-\u0fbc\u0fc6\u102b-\u103e\u1040-\u1049\u1056-\u1059\u105e-\u1060\u1062-\u1064\u1067-\u106d\u1071-\u1074\u1082-\u108d\u108f-\u109d\u135d-\u135f\u1369-\u1371\u1712-\u1714\u1732-\u1734\u1752\u1753\u1772\u1773\u17b4-\u17d3\u17dd\u17e0-\u17e9\u180b-\u180d\u1810-\u1819\u18a9\u1920-\u192b\u1930-\u193b\u1946-\u194f\u19d0-\u19da\u1a17-\u1a1b\u1a55-\u1a5e\u1a60-\u1a7c\u1a7f-\u1a89\u1a90-\u1a99\u1ab0-\u1abd\u1abf\u1ac0\u1b00-\u1b04\u1b34-\u1b44\u1b50-\u1b59\u1b6b-\u1b73\u1b80-\u1b82\u1ba1-\u1bad\u1bb0-\u1bb9\u1be6-\u1bf3\u1c24-\u1c37\u1c40-\u1c49\u1c50-\u1c59\u1cd0-\u1cd2\u1cd4-\u1ce8\u1ced\u1cf4\u1cf7-\u1cf9\u1dc0-\u1df9\u1dfb-\u1dff\u203f\u2040\u2054\u20d0-\u20dc\u20e1\u20e5-\u20f0\u2cef-\u2cf1\u2d7f\u2de0-\u2dff\u302a-\u302f\u3099\u309a\ua620-\ua629\ua66f\ua674-\ua67d\ua69e\ua69f\ua6f0\ua6f1\ua802\ua806\ua80b\ua823-\ua827\ua82c\ua880\ua881\ua8b4-\ua8c5\ua8d0-\ua8d9\ua8e0-\ua8f1\ua8ff-\ua909\ua926-\ua92d\ua947-\ua953\ua980-\ua983\ua9b3-\ua9c0\ua9d0-\ua9d9\ua9e5\ua9f0-\ua9f9\uaa29-\uaa36\uaa43\uaa4c\uaa4d\uaa50-\uaa59\uaa7b-\uaa7d\uaab0\uaab2-\uaab4\uaab7\uaab8\uaabe\uaabf\uaac1\uaaeb-\uaaef\uaaf5\uaaf6\uabe3-\uabea\uabec\uabed\uabf0-\uabf9\ufb1e\ufe00-\ufe0f\ufe20-\ufe2f\ufe33\ufe34\ufe4d-\ufe4f\uff10-\uff19\uff3f'; - -const nonASCIIidentifierStart = new RegExp( - '[' + nonASCIIidentifierStartChars + ']' -); -const nonASCIIidentifier = new RegExp( - '[' + nonASCIIidentifierStartChars + nonASCIIidentifierChars + ']' -); - -nonASCIIidentifierStartChars = nonASCIIidentifierChars = null; - -// These are a run-length and offset-encoded representation of the -// >0xffff code points that are a valid part of identifiers. The -// offset starts at 0x10000, and each pair of numbers represents an -// offset to the next range, and then a size of the range. They were -// generated by `scripts/generate-identifier-regex.js`. -/* prettier-ignore */ -/* prettier-ignore */ -const astralIdentifierStartCodes = [0, 11, 2, 25, 2, 18, 2, 1, 2, 14, 3, 13, 35, 122, 70, 52, 268, 28, 4, 48, 48, 31, 14, 29, 6, 37, 11, 29, 3, 35, 5, 7, 2, 4, 43, 157, 19, 35, 5, 35, 5, 39, 9, 51, 157, 310, 10, 21, 11, 7, 153, 5, 3, 0, 2, 43, 2, 1, 4, 0, 3, 22, 11, 22, 10, 30, 66, 18, 2, 1, 11, 21, 11, 25, 71, 55, 7, 1, 65, 0, 16, 3, 2, 2, 2, 28, 43, 28, 4, 28, 36, 7, 2, 27, 28, 53, 11, 21, 11, 18, 14, 17, 111, 72, 56, 50, 14, 50, 14, 35, 349, 41, 7, 1, 79, 28, 11, 0, 9, 21, 107, 20, 28, 22, 13, 52, 76, 44, 33, 24, 27, 35, 30, 0, 3, 0, 9, 34, 4, 0, 13, 47, 15, 3, 22, 0, 2, 0, 36, 17, 2, 24, 85, 6, 2, 0, 2, 3, 2, 14, 2, 9, 8, 46, 39, 7, 3, 1, 3, 21, 2, 6, 2, 1, 2, 4, 4, 0, 19, 0, 13, 4, 159, 52, 19, 3, 21, 2, 31, 47, 21, 1, 2, 0, 185, 46, 42, 3, 37, 47, 21, 0, 60, 42, 14, 0, 72, 26, 230, 43, 117, 63, 32, 7, 3, 0, 3, 7, 2, 1, 2, 23, 16, 0, 2, 0, 95, 7, 3, 38, 17, 0, 2, 0, 29, 0, 11, 39, 8, 0, 22, 0, 12, 45, 20, 0, 35, 56, 264, 8, 2, 36, 18, 0, 50, 29, 113, 6, 2, 1, 2, 37, 22, 0, 26, 5, 2, 1, 2, 31, 15, 0, 328, 18, 190, 0, 80, 921, 103, 110, 18, 195, 2749, 1070, 4050, 582, 8634, 568, 8, 30, 114, 29, 19, 47, 17, 3, 32, 20, 6, 18, 689, 63, 129, 74, 6, 0, 67, 12, 65, 1, 2, 0, 29, 6135, 9, 1237, 43, 8, 8952, 286, 50, 2, 18, 3, 9, 395, 2309, 106, 6, 12, 4, 8, 8, 9, 5991, 84, 2, 70, 2, 1, 3, 0, 3, 1, 3, 3, 2, 11, 2, 0, 2, 6, 2, 64, 2, 3, 3, 7, 2, 6, 2, 27, 2, 3, 2, 4, 2, 0, 4, 6, 2, 339, 3, 24, 2, 24, 2, 30, 2, 24, 2, 30, 2, 24, 2, 30, 2, 24, 2, 30, 2, 24, 2, 7, 2357, 44, 11, 6, 17, 0, 370, 43, 1301, 196, 60, 67, 8, 0, 1205, 3, 2, 26, 2, 1, 2, 0, 3, 0, 2, 9, 2, 3, 2, 0, 2, 0, 7, 0, 5, 0, 2, 0, 2, 0, 2, 2, 2, 1, 2, 0, 3, 0, 2, 0, 2, 0, 2, 0, 2, 0, 2, 1, 2, 0, 3, 3, 2, 6, 2, 3, 2, 3, 2, 0, 2, 9, 2, 16, 6, 2, 2, 4, 2, 16, 4421, 42717, 35, 4148, 12, 221, 3, 5761, 15, 7472, 3104, 541, 1507, 4938]; -/* prettier-ignore */ -const astralIdentifierCodes = [509, 0, 227, 0, 150, 4, 294, 9, 1368, 2, 2, 1, 6, 3, 41, 2, 5, 0, 166, 1, 574, 3, 9, 9, 370, 1, 154, 10, 176, 2, 54, 14, 32, 9, 16, 3, 46, 10, 54, 9, 7, 2, 37, 13, 2, 9, 6, 1, 45, 0, 13, 2, 49, 13, 9, 3, 2, 11, 83, 11, 7, 0, 161, 11, 6, 9, 7, 3, 56, 1, 2, 6, 3, 1, 3, 2, 10, 0, 11, 1, 3, 6, 4, 4, 193, 17, 10, 9, 5, 0, 82, 19, 13, 9, 214, 6, 3, 8, 28, 1, 83, 16, 16, 9, 82, 12, 9, 9, 84, 14, 5, 9, 243, 14, 166, 9, 71, 5, 2, 1, 3, 3, 2, 0, 2, 1, 13, 9, 120, 6, 3, 6, 4, 0, 29, 9, 41, 6, 2, 3, 9, 0, 10, 10, 47, 15, 406, 7, 2, 7, 17, 9, 57, 21, 2, 13, 123, 5, 4, 0, 2, 1, 2, 6, 2, 0, 9, 9, 49, 4, 2, 1, 2, 4, 9, 9, 330, 3, 19306, 9, 135, 4, 60, 6, 26, 9, 1014, 0, 2, 54, 8, 3, 82, 0, 12, 1, 19628, 1, 5319, 4, 4, 5, 9, 7, 3, 6, 31, 3, 149, 2, 1418, 49, 513, 54, 5, 49, 9, 0, 15, 0, 23, 4, 2, 14, 1361, 6, 2, 16, 3, 6, 2, 1, 2, 4, 262, 6, 10, 9, 419, 13, 1495, 6, 110, 6, 6, 9, 4759, 9, 787719, 239]; - -// This has a complexity linear to the value of the code. The -// assumption is that looking up astral identifier characters is -// rare. -function isInAstralSet(code: number, set: Array): boolean { - let pos = 0x10000; - for (let i = 0, length = set.length; i < length; i += 2) { - pos += set[i]; - if (pos > code) return false; - - pos += set[i + 1]; - if (pos >= code) return true; - } - return false; -} - -// Test whether a given character code starts an identifier. - -export function isIdentifierStart(code: number): boolean { - if (code < uppercaseA) return code === dollarSign; - if (code <= uppercaseZ) return true; - if (code < lowercaseA) return code === underscore; - if (code <= lowercaseZ) return true; - if (code <= 0xffff) { - return ( - code >= 0xaa && nonASCIIidentifierStart.test(String.fromCharCode(code)) - ); - } - return isInAstralSet(code, astralIdentifierStartCodes); -} - -// Test whether a given character is part of an identifier. - -export function isIdentifierChar(code: number): boolean { - if (code < digit0) return code === dollarSign; - if (code < colon) return true; - if (code < uppercaseA) return false; - if (code <= uppercaseZ) return true; - if (code < lowercaseA) return code === underscore; - if (code <= lowercaseZ) return true; - if (code <= 0xffff) { - return code >= 0xaa && nonASCIIidentifier.test(String.fromCharCode(code)); - } - return ( - isInAstralSet(code, astralIdentifierStartCodes) || - isInAstralSet(code, astralIdentifierCodes) - ); -} - -// Test whether a given string is a valid identifier name - -export function isIdentifierName(name: string): boolean { - let isFirst = true; - for (const char of Array.from(name)) { - const cp = char.codePointAt(0); - if (isFirst) { - if (!isIdentifierStart(cp)) { - return false; - } - isFirst = false; - } else if (!isIdentifierChar(cp)) { - return false; - } - } - return !isFirst; -} - // Adapted from https://raw.githubusercontent.com/babel/babel/e39b508030a9f696584d21b0eb9677498e3ca231/packages/babel-helper-validator-identifier/src/keyword.js -const reservedWords = { - keyword: [ - 'break', - 'case', - 'catch', - 'continue', - 'debugger', - 'default', - 'do', - 'else', - 'finally', - 'for', - 'function', - 'if', - 'return', - 'switch', - 'throw', - 'try', - 'var', - 'const', - 'while', - 'with', - 'new', - 'this', - 'super', - 'class', - 'extends', - 'export', - 'import', - 'null', - 'true', - 'false', - 'in', - 'instanceof', - 'typeof', - 'void', - 'delete', - ], - strict: [ - 'implements', - 'interface', - 'let', - 'package', - 'private', - 'protected', - 'public', - 'static', - 'yield', - ], - strictBind: ['eval', 'arguments'], -}; -const keywords = new Set(reservedWords.keyword); -const reservedWordsStrictSet = new Set(reservedWords.strict); -const reservedWordsStrictBindSet = new Set(reservedWords.strictBind); +const keywords = new Set([ + 'break', + 'case', + 'catch', + 'continue', + 'debugger', + 'default', + 'do', + 'else', + 'finally', + 'for', + 'function', + 'if', + 'return', + 'switch', + 'throw', + 'try', + 'var', + 'const', + 'while', + 'with', + 'new', + 'this', + 'super', + 'class', + 'extends', + 'export', + 'import', + 'null', + 'true', + 'false', + 'in', + 'instanceof', + 'typeof', + 'void', + 'delete', +]); /** * Checks if word is a reserved word in non-strict mode @@ -172,37 +44,6 @@ export function isReservedWord(word: string, inModule?: boolean): boolean { return (inModule && word === 'await') || word === 'enum'; } -/** - * Checks if word is a reserved word in non-binding strict mode - * - * Includes non-strict reserved words - */ -export function isStrictReservedWord(word: string, inModule: boolean): boolean { - return isReservedWord(word, inModule) || reservedWordsStrictSet.has(word); -} - -/** - * Checks if word is a reserved word in binding strict mode, but it is allowed as - * a normal identifier. - */ -export function isStrictBindOnlyReservedWord(word: string): boolean { - return reservedWordsStrictBindSet.has(word); -} - -/** - * Checks if word is a reserved word in binding strict mode - * - * Includes non-strict reserved words and non-binding strict reserved words - */ -export function isStrictBindReservedWord( - word: string, - inModule: boolean -): boolean { - return ( - isStrictReservedWord(word, inModule) || isStrictBindOnlyReservedWord(word) - ); -} - export function isKeyword(word: string): boolean { return keywords.has(word); } diff --git a/packages/js/src/utils/typescript/run-type-check.ts b/packages/js/src/utils/typescript/run-type-check.ts index 6ebb695ac5..7636027f5b 100644 --- a/packages/js/src/utils/typescript/run-type-check.ts +++ b/packages/js/src/utils/typescript/run-type-check.ts @@ -2,7 +2,8 @@ import { readTsConfig } from '@nrwl/workspace/src/utilities/typescript'; import * as chalk from 'chalk'; import * as path from 'path'; import type { BuilderProgram, Diagnostic, Program } from 'typescript'; -import { codeFrameColumns } from '../code-frames/code-frames'; +import { codeFrameColumns } from 'nx/src/utils/code-frames'; +import { highlight } from '../code-frames/highlight'; export interface TypeCheckResult { warnings?: string[]; @@ -208,13 +209,16 @@ export function getFormattedDiagnostic( message = `${chalk.underline.blue(`${fileName}:${line}:${column}`)} - ` + message; + const code = diagnostic.file.getFullText(diagnostic.file.getSourceFile()); + message += '\n' + codeFrameColumns( - diagnostic.file.getFullText(diagnostic.file.getSourceFile()), + code, { start: { line: line, column }, - } + }, + { highlight } ); } diff --git a/packages/nx/src/project-graph/build-project-graph.spec.ts b/packages/nx/src/project-graph/build-project-graph.spec.ts index 5350594f70..fb98f90202 100644 --- a/packages/nx/src/project-graph/build-project-graph.spec.ts +++ b/packages/nx/src/project-graph/build-project-graph.spec.ts @@ -215,8 +215,8 @@ describe('project graph', () => { } catch (e) { expect(e.message).toMatchInlineSnapshot(` "InvalidSymbol in /root/tsconfig.base.json at 1:248 - 1: {\\"compilerOptions\\":{\\"baseUrl\\":\\".\\",\\"paths\\":{\\"@nrwl/shared/util\\":[\\"libs/shared/util/src/index.ts\\"],\\"@nrwl/shared-util-data\\":[\\"libs/shared/util/data/src/index.ts\\"],\\"@nrwl/ui\\":[\\"libs/ui/src/index.ts\\"],\\"@nrwl/lazy-lib\\":[\\"libs/lazy-lib/src/index.ts\\"]}}}invalid - ^^^^^^^ InvalidSymbol + > 1 | {\\"compilerOptions\\":{\\"baseUrl\\":\\".\\",\\"paths\\":{\\"@nrwl/shared/util\\":[\\"libs/shared/util/src/index.ts\\"],\\"@nrwl/shared-util-data\\":[\\"libs/shared/util/data/src/index.ts\\"],\\"@nrwl/ui\\":[\\"libs/ui/src/index.ts\\"],\\"@nrwl/lazy-lib\\":[\\"libs/lazy-lib/src/index.ts\\"]}}}invalid +   |  ^^^^^^^ " `); } diff --git a/packages/js/src/utils/code-frames/code-frames.ts b/packages/nx/src/utils/code-frames.ts similarity index 85% rename from packages/js/src/utils/code-frames/code-frames.ts rename to packages/nx/src/utils/code-frames.ts index a79a5aa349..377efdf963 100644 --- a/packages/js/src/utils/code-frames/code-frames.ts +++ b/packages/nx/src/utils/code-frames.ts @@ -1,5 +1,4 @@ // Adapted from https://raw.githubusercontent.com/babel/babel/4108524/packages/babel-code-frame/src/index.js -import { highlight } from './highlight'; import * as chalk from 'chalk'; type Location = { @@ -32,11 +31,10 @@ const NEWLINE = /\r\n|[\n\r\u2028\u2029]/; /** * Extract what lines should be marked and highlighted. */ - function getMarkerLines( loc: NodeLocation, source: Array, - opts: { linesAbove?: number; linesBelow?: number } + opts: { linesAbove?: number; linesBelow?: number } = {} ): { start: number; end: number; markerLines: Object } { const startLoc: Location = { column: 0, @@ -103,14 +101,18 @@ function getMarkerLines( export function codeFrameColumns( rawLines: string, loc: NodeLocation, - opts: Object = {} + opts: { + linesAbove?: number; + linesBelow?: number; + highlight?: (rawLines: string) => string; + } = {} ): string { const defs = getDefs(chalk); const lines = rawLines.split(NEWLINE); const { start, end, markerLines } = getMarkerLines(loc, lines, opts); const numberMaxWidth = String(end).length; - const highlightedLines = highlight(rawLines); + const highlightedLines = opts.highlight ? opts.highlight(rawLines) : rawLines; let frame = highlightedLines .split(NEWLINE) @@ -146,22 +148,3 @@ export function codeFrameColumns( return chalk.reset(frame); } - -/** - * Create a code frame, adding line numbers, code highlighting, and pointing to a given position. - */ - -export default function ( - rawLines: string, - lineNumber: number, - colNumber?: number, - opts: Object = {} -): string { - colNumber = Math.max(colNumber, 0); - - const location: NodeLocation = { - start: { column: colNumber, line: lineNumber }, - }; - - return codeFrameColumns(rawLines, location, opts); -} diff --git a/packages/nx/src/utils/json.spec.ts b/packages/nx/src/utils/json.spec.ts index 796bf14d02..3b5ad0813a 100644 --- a/packages/nx/src/utils/json.spec.ts +++ b/packages/nx/src/utils/json.spec.ts @@ -60,13 +60,12 @@ describe('parseJson', () => { ) ).toThrowErrorMatchingInlineSnapshot(` "InvalidCommentToken in JSON at 2:7 - 1: { - 2: //\\"test\\": 123, - ^^^^^^^^^^^^^^ InvalidCommentToken - 3: \\"nested\\": { - 4: \\"test\\": 123 - 5: /* - ... +   1 | { + > 2 |  //\\"test\\": 123, +   |  ^^^^^^^^^^^^^^ +   3 |  \\"nested\\": { +   4 |  \\"test\\": 123 +   5 |  /* " `); }); @@ -89,13 +88,12 @@ describe('parseJson', () => { ) ).toThrowErrorMatchingInlineSnapshot(` "InvalidCommentToken in JSON at 2:7 - 1: { - 2: //\\"test\\": 123, - ^^^^^^^^^^^^^^ InvalidCommentToken - 3: \\"nested\\": { - 4: \\"test\\": 123 - 5: /* - ... +   1 | { + > 2 |  //\\"test\\": 123, +   |  ^^^^^^^^^^^^^^ +   3 |  \\"nested\\": { +   4 |  \\"test\\": 123 +   5 |  /* " `); }); @@ -130,14 +128,12 @@ describe('parseJson', () => { ) ).toThrowErrorMatchingInlineSnapshot(` "PropertyNameExpected in JSON at 6:6 - ... - 3: \\"nested\\": { - 4: \\"test\\": 123, - 5: \\"more\\": 456, - 6: }, - ^ PropertyNameExpected - 7: \\"array\\": [1, 2, 3,] - 8: } +   4 |  \\"test\\": 123, +   5 |  \\"more\\": 456, + > 6 |  }, +   |  ^ +   7 |  \\"array\\": [1, 2, 3,] +   8 |  } " `); }); diff --git a/packages/nx/src/utils/json.ts b/packages/nx/src/utils/json.ts index 4c453c23a0..64e4fe1f64 100644 --- a/packages/nx/src/utils/json.ts +++ b/packages/nx/src/utils/json.ts @@ -1,6 +1,7 @@ import { parse, printParseErrorCode, stripComments } from 'jsonc-parser'; import type { ParseError, ParseOptions } from 'jsonc-parser'; import { LinesAndColumns } from 'lines-and-columns'; +import { codeFrameColumns } from './code-frames'; export { stripComments as stripJsonComments }; @@ -52,7 +53,7 @@ export function parseJson( const result: T = parse(input, errors, options); if (errors.length > 0) { - throw new Error(formatParseError(input, errors[0], 3)); + throw new Error(formatParseError(input, errors[0])); } return result; @@ -63,48 +64,22 @@ export function parseJson( * * @param input JSON content as string * @param parseError jsonc ParseError - * @param numContextLine Number of context lines to show before and after * @returns */ -function formatParseError( - input: string, - parseError: ParseError, - numContextLine: number -) { +function formatParseError(input: string, parseError: ParseError) { const { error, offset, length } = parseError; - const { line, column } = new LinesAndColumns(input).locationForIndex(offset); + let { line, column } = new LinesAndColumns(input).locationForIndex(offset); + line++; + column++; - const errorLines = [ - `${printParseErrorCode(error)} in JSON at ${line + 1}:${column + 1}`, - ]; - - const inputLines = input.split(/\r?\n/); - const firstLine = Math.max(0, line - numContextLine); - const lastLine = Math.min(inputLines.length - 1, line + numContextLine); - - if (firstLine > 0) { - errorLines.push('...'); - } - - for (let currentLine = firstLine; currentLine <= lastLine; currentLine++) { - const lineNumber = `${currentLine + 1}: `; - errorLines.push(`${lineNumber}${inputLines[currentLine]}`); - if (line == currentLine) { - errorLines.push( - `${' '.repeat(column + lineNumber.length)}${'^'.repeat( - length - )} ${printParseErrorCode(error)}` - ); - } - } - - if (lastLine < inputLines.length - 1) { - errorLines.push('...'); - } - - errorLines.push(''); - - return errorLines.join('\n'); + return ( + `${printParseErrorCode(error)} in JSON at ${line}:${column}\n` + + codeFrameColumns(input, { + start: { line, column }, + end: { line, column: column + length }, + }) + + '\n' + ); } /** diff --git a/packages/workspace/src/utils/ast-utils.spec.ts b/packages/workspace/src/utils/ast-utils.spec.ts index 6afbe8683f..e8e5c801f8 100644 --- a/packages/workspace/src/utils/ast-utils.spec.ts +++ b/packages/workspace/src/utils/ast-utils.spec.ts @@ -51,8 +51,8 @@ describe('readJsonInTree', () => { expect(() => readJsonInTree(tree, 'data.json')) .toThrowErrorMatchingInlineSnapshot(` "Cannot parse data.json: InvalidSymbol in JSON at 1:3 - 1: { data: 'data' - ^^^^ InvalidSymbol + > 1 | { data: 'data' +   |  ^^^^ " `); });