miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(core): Update nightly tests to work with continuous local-registry (#31007)

Browse Source 
Currently, when the Nightly E2E Matrix job is ran it gets stuck at:
```
Waiting for Local registry to start on http://localhost:4873...
Waiting for Local registry to start on http://localhost:4873...
Waiting for Local registry to start on http://localhost:4873...
Waiting for Local registry to start on http://localhost:4873...
Waiting for Local registry to start on http://localhost:4873...
Waiting for Local registry to start on http://localhost:4873...
```

Which blocks other jobs and they will be queued for an unnecessary long
period.

![image](https://github.com/user-attachments/assets/bc9e0993-423b-4fb6-9fa0-4e4a1d0a5bb7)

This change should ensure that the local-registry is ran first before
attempting to run the test suite.

Results:
https://github.com/nrwl/nx/actions/runs/14799474928/job/41554727471
No longer hanging.
This commit is contained in:
Nicholas Cunningham 2025-05-02 15:30:12 -06:00 committed by GitHub
parent e30b5fa7d4
commit 516febf436
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/ci.yml vendored
View File

@ -137,7 +137,7 @@ jobs:
uses: actions/cache@v4 uses: actions/cache@v4
with: with:
path: | path: |
/opt/Homebrew /opt/homebrew
~/Library/Caches/Homebrew ~/Library/Caches/Homebrew
key: nrwl-nx-homebrew-packages key: nrwl-nx-homebrew-packages
@ -152,7 +152,7 @@ jobs:
uses: actions/cache@v4 uses: actions/cache@v4
with: with:
path: | path: |
/opt/Homebrew /opt/homebrew
~/Library/Caches/Homebrew ~/Library/Caches/Homebrew
key: nrwl-nx-homebrew-packages key: nrwl-nx-homebrew-packages

9
e2e/utils/global-setup.ts
View File

@ -12,12 +12,13 @@ export default async function (globalConfig: Config.ConfigGlobals) {
process.env.NX_VERBOSE_LOGGING === 'true' || !!globalConfig.verbose; process.env.NX_VERBOSE_LOGGING === 'true' || !!globalConfig.verbose;
/** /**
* For e2e-ci & macos-local-e2e we populate the verdaccio storage up front, but for other workflows we need * For e2e-ci, e2e-local and macos-local-e2e we populate the verdaccio storage up front, but for other workflows we need
* to run the full local release process before running tests. * to run the full local release process before running tests.
*/ */
const requiresLocalRelease = const prefixes = ['e2e-ci', 'e2e-macos-local', 'e2e-local'];
!process.env.NX_TASK_TARGET_TARGET?.startsWith('e2e-ci') && const requiresLocalRelease = !prefixes.some((prefix) =>
!process.env.NX_TASK_TARGET_TARGET?.startsWith('e2e-macos-local'); process.env.NX_TASK_TARGET_TARGET?.startsWith(prefix)
);
const listenAddress = 'localhost'; const listenAddress = 'localhost';
const port = process.env.NX_LOCAL_REGISTRY_PORT ?? '4873'; const port = process.env.NX_LOCAL_REGISTRY_PORT ?? '4873';

6
nx.json
View File

@ -127,7 +127,11 @@
}, },
"e2e-local": { "e2e-local": {
"cache": true, "cache": true,
"inputs": ["e2eInputs", "^production"] "inputs": ["e2eInputs", "^production"],
"dependsOn": [
"@nx/nx-source:populate-local-registry-storage",
"@nx/nx-source:local-registry"
]
}, },
"e2e-ci": { "e2e-ci": {
"inputs": ["e2eInputs", "^production"] "inputs": ["e2eInputs", "^production"]