From 57247e0b81e032fcdfac6e53e02ccd0bc29e9140 Mon Sep 17 00:00:00 2001 From: Jason Jean Date: Thu, 12 Oct 2023 17:54:56 -0400 Subject: [PATCH] chore(repo): temporarily allow linking to vue (#19591) --- nx-dev/nx-dev/next-sitemap.config.js | 2 +- scripts/documentation/internal-link-checker.ts | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/nx-dev/nx-dev/next-sitemap.config.js b/nx-dev/nx-dev/next-sitemap.config.js index 34b985c514..2815b1a32e 100644 --- a/nx-dev/nx-dev/next-sitemap.config.js +++ b/nx-dev/nx-dev/next-sitemap.config.js @@ -3,7 +3,7 @@ const path = require('path'); module.exports = { siteUrl: process.env.SITE_URL || 'https://nx.dev', generateRobotsTxt: true, - exclude: ['/ai'], + exclude: [], sourceDir: path.resolve(__dirname, '../../dist/nx-dev/nx-dev/.next'), outDir: path.resolve(__dirname, '../../dist/nx-dev/nx-dev/public'), }; diff --git a/scripts/documentation/internal-link-checker.ts b/scripts/documentation/internal-link-checker.ts index c25a6f5061..3571a6713c 100644 --- a/scripts/documentation/internal-link-checker.ts +++ b/scripts/documentation/internal-link-checker.ts @@ -97,6 +97,11 @@ function checkLinkIsForPrivatePackage(link: string) { } const pathSegments = link.split('/').filter(Boolean); if (pathSegments[0] === 'nx-api') { + // TODO(v17): Remove this once vue is public or once this logic is fixed + if (pathSegments[1] === 'vue') { + return true; + } + const packageJsonPath = join( workspaceRoot, 'packages', @@ -119,6 +124,7 @@ const sitemapLinks = readSiteMapIndex( const errors: Array<{ file: string; link: string }> = []; for (let file in documentLinks) { for (let link of documentLinks[file]) { + // TODO(@isaacplmann): This ignores errors which are links TO private packages. It allows links FROM public packages (public docs) TO private packages (404 links) if ( !sitemapLinks.includes(['https://nx.dev', link].join('')) && !checkLinkIsForPrivatePackage(link)