From 5c3379704010b4448343f5ae23360baefa2577bb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Leosvel=20P=C3=A9rez=20Espinosa?= Date: Fri, 31 Mar 2023 15:45:28 +0100 Subject: [PATCH] fix(misc): filter shared libraries by import name in module federation helpers (#15980) --- packages/angular/src/utils/mf/utils.ts | 2 +- packages/react/src/module-federation/utils.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/angular/src/utils/mf/utils.ts b/packages/angular/src/utils/mf/utils.ts index f2ea36cd91..ffbcac4017 100644 --- a/packages/angular/src/utils/mf/utils.ts +++ b/packages/angular/src/utils/mf/utils.ts @@ -60,7 +60,7 @@ export async function getModuleFederationConfig( if (mfConfig.shared) { dependencies.workspaceLibraries = dependencies.workspaceLibraries.filter( - (lib) => mfConfig.shared(lib.name, {}) + (lib) => mfConfig.shared(lib.importKey, {}) ); dependencies.npmPackages = dependencies.npmPackages.filter((pkg) => mfConfig.shared(pkg, {}) diff --git a/packages/react/src/module-federation/utils.ts b/packages/react/src/module-federation/utils.ts index c2c76b9934..35b8f7f6dd 100644 --- a/packages/react/src/module-federation/utils.ts +++ b/packages/react/src/module-federation/utils.ts @@ -40,7 +40,7 @@ export async function getModuleFederationConfig( if (mfConfig.shared) { dependencies.workspaceLibraries = dependencies.workspaceLibraries.filter( - (lib) => mfConfig.shared(lib.name, {}) + (lib) => mfConfig.shared(lib.importKey, {}) ); dependencies.npmPackages = dependencies.npmPackages.filter((pkg) => mfConfig.shared(pkg, {})