fix(misc): properly add extra dependencies to packages (#19334)

packages/angular/project.json

@@ -63,13 +63,13 @@
       "outputs": ["{workspaceRoot}/build/packages/angular"],
       "dependsOn": ["build-ng", "build-base", "^build"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js angular",
-          "node ./scripts/copy-readme.js angular",
-          "node ./scripts/add-dependency-to-build.js angular @nrwl/angular"
-        ],
         "parallel": false
       }
     },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js angular @nrwl/angular"
+    },
     "lint": {}
   },
   "implicitDependencies": []

packages/cypress/project.json

@@ -48,12 +48,12 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/cypress"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js cypress"
-          "node ./scripts/copy-readme.js cypress",
-          "node ./scripts/add-dependency-to-build.js cypress @nrwl/cypress"
-        ]
       }
     },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js cypress @nrwl/cypress"
+    },
     "lint": {}
   }
 }

packages/detox/project.json

@@ -48,11 +48,11 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/detox"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js detox"
-          "node ./scripts/copy-readme.js detox",
-          "node ./scripts/add-dependency-to-build.js detox @nrwl/detox"
-        ]
       }
+    },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js detox @nrwl/detox"
     }
   }
 }

packages/devkit/project.json

@@ -48,12 +48,12 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/devkit"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js devkit"
-          "node ./scripts/copy-readme.js devkit",
-          "node ./scripts/add-dependency-to-build.js devkit @nrwl/devkit"
-        ]
       }
     },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js devkit @nrwl/devkit"
+    },
     "lint": {}
   }
 }

packages/esbuild/project.json

@@ -54,6 +54,9 @@
         ]
       }
     },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js esbuild @nrwl/esbuild"
+    },
     "lint": {}
   }
 }

packages/eslint-plugin/project.json

@@ -49,12 +49,12 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/eslint-plugin"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js eslint-plugin"
-          "node ./scripts/copy-readme.js eslint-plugin",
-          "node ./scripts/add-dependency-to-build.js eslint-plugin @nrwl/eslint-plugin-nx"
-        ]
       }
     },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js eslint-plugin @nrwl/eslint-plugin-nx"
+    },
     "lint": {}
   }
 }

packages/expo/project.json

@@ -50,11 +50,11 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/expo"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js expo"
-          "node ./scripts/copy-readme.js expo",
-          "node ./scripts/add-dependency-to-build.js expo @nrwl/expo"
-        ]
       }
+    },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js expo @nrwl/expo"
     }
   },
   "tags": []

packages/express/project.json

@@ -48,12 +48,12 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/express"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js express"
-          "node ./scripts/copy-readme.js express",
-          "node ./scripts/add-dependency-to-build.js express @nrwl/express"
-        ]
       }
     },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js express @nrwl/express"
+    },
     "lint": {}
   },
   "implicitDependencies": ["node"]

packages/jest/project.json

@@ -48,12 +48,12 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/jest"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js jest"
-          "node ./scripts/copy-readme.js jest",
-          "node ./scripts/add-dependency-to-build.js jest @nrwl/jest"
-        ]
       }
     },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js jest @nrwl/jest"
+    },
     "lint": {}
   }
 }

packages/js/project.json

@@ -50,11 +50,11 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/js"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js js"
-          "node ./scripts/copy-readme.js js",
-          "node ./scripts/add-dependency-to-build.js js @nrwl/js"
-        ]
       }
+    },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js js @nrwl/js"
     }
   },
   "tags": []

packages/linter/project.json

@@ -48,12 +48,12 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/linter"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js linter"
-          "node ./scripts/copy-readme.js linter",
-          "node ./scripts/add-dependency-to-build.js linter @nrwl/linter"
-        ]
       }
     },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js linter @nrwl/linter"
+    },
     "lint": {}
   },
   "implicitDependencies": ["eslint-plugin"]

packages/nest/project.json

@@ -48,12 +48,12 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/nest"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js nest"
-          "node ./scripts/copy-readme.js nest",
-          "node ./scripts/add-dependency-to-build.js nest @nrwl/nest"
-        ]
       }
     },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js nest @nrwl/nest"
+    },
     "lint": {}
   },
   "implicitDependencies": ["node", "linter"]

packages/next/project.json

@@ -53,12 +53,12 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/next"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js next"
-          "node ./scripts/copy-readme.js next",
-          "node ./scripts/add-dependency-to-build.js next @nrwl/next"
-        ]
       }
     },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js next @nrwl/next"
+    },
     "lint": {}
   }
 }

packages/node/project.json

@@ -48,12 +48,12 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/node"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js node"
-          "node ./scripts/copy-readme.js node",
-          "node ./scripts/add-dependency-to-build.js node @nrwl/node"
-        ]
       }
     },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js node @nrwl/node"
+    },
     "lint": {}
   }
 }

packages/nx/project.json

@@ -95,14 +95,14 @@
           },
           {
             "command": "node ./scripts/copy-readme.js nx"
-          },
-          {
-            "command": "node ./scripts/add-dependency-to-build.js nx @nrwl/tao"
           }
         ],
         "parallel": false
       }
     },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js nx @nrwl/tao"
+    },
     "lint": {},
     "test": {},
     "test-native": {}

packages/plugin/project.json

@@ -48,12 +48,12 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/plugin"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js plugin"
-          "node ./scripts/copy-readme.js plugin",
-          "node ./scripts/add-dependency-to-build.js plugin @nrwl/nx-plugin"
-        ]
       }
     },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js plugin @nrwl/nx-plugin"
+    },
     "lint": {}
   }
 }

packages/react-native/project.json

@@ -44,11 +44,11 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/react-native"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js react-native"
-          "node ./scripts/copy-readme.js react-native",
-          "node ./scripts/add-dependency-to-build.js react-native @nrwl/react-native"
-        ]
       }
+    },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js react-native @nrwl/react-native"
     }
   }
 }

packages/react/project.json

@@ -58,12 +58,12 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/react"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js react"
-          "node ./scripts/copy-readme.js react",
-          "node ./scripts/add-dependency-to-build.js react @nrwl/react"
-        ]
       }
     },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js react @nrwl/react"
+    },
     "lint": {}
   }
 }

packages/rollup/project.json

@@ -48,12 +48,12 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/rollup"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js rollup"
-          "node ./scripts/copy-readme.js rollup",
-          "node ./scripts/add-dependency-to-build.js rollup @nrwl/rollup"
-        ]
       }
     },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js rollup @nrwl/rollup"
+    },
     "lint": {}
   }
 }

packages/storybook/project.json

@@ -58,12 +58,12 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/storybook"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js storybook"
-          "node ./scripts/copy-readme.js storybook",
-          "node ./scripts/add-dependency-to-build.js storybook @nrwl/storybook"
-        ]
       }
     },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js storybook @nrwl/storybook"
+    },
     "lint": {}
   }
 }

packages/vite/project.json

@@ -59,12 +59,12 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/vite"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js vite"
-          "node ./scripts/copy-readme.js vite",
-          "node ./scripts/add-dependency-to-build.js vite @nrwl/vite"
-        ]
       }
     },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js vite @nrwl/vite"
+    },
     "lint": {
       "executor": "@nx/linter:eslint",
       "options": {

packages/web/project.json

@@ -53,12 +53,12 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/web"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js web"
-          "node ./scripts/copy-readme.js web",
-          "node ./scripts/add-dependency-to-build.js web @nrwl/web"
-        ]
       }
     },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js web @nrwl/web"
+    },
     "lint": {}
   }
 }

packages/webpack/project.json

@@ -48,12 +48,12 @@
       "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/webpack"],
       "options": {
-        "commands": [
+        "command": "node ./scripts/copy-readme.js webpack"
-          "node ./scripts/copy-readme.js webpack",
-          "node ./scripts/add-dependency-to-build.js webpack @nrwl/webpack"
-        ]
       }
     },
+    "add-extra-dependencies": {
+      "command": "node ./scripts/add-dependency-to-build.js webpack @nrwl/webpack"
+    },
     "lint": {}
   }
 }

packages/workspace/project.json

@@ -75,16 +75,14 @@
       }
     },
     "build": {
-      "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/build/packages/workspace"],
-      "options": {
-        "commands": [
-          {
       "command": "node ./scripts/copy-readme.js workspace"
     },
-          {
+    "add-extra-dependencies": {
-            "command": "node ./scripts/add-dependency-to-build.js workspace nx"
+      "executor": "nx:run-commands",
-          },
+      "options": {
+        "commands": [
+          "node ./scripts/add-dependency-to-build.js workspace nx",
           "node ./scripts/add-dependency-to-build.js workspace @nrwl/workspace"
         ],
         "parallel": false

scripts/add-dependency-to-build.js

@@ -5,6 +5,7 @@ const [package, dependency] = process.argv.slice(2);
 
 const pkgPath = join(__dirname, '../build/packages', package, 'package.json');
 const packageJson = readJsonSync(pkgPath);
-packageJson.dependencies[dependency] = '*';
+const version = packageJson.version;
+packageJson.dependencies[dependency] = version;
 
 writeJsonSync(pkgPath, packageJson, { spaces: 2 });

scripts/nx-release.ts

@@ -79,6 +79,11 @@ const LARGE_BUFFER = 1024 * 1000000;
 
     runNxReleaseVersion();
 
+    execSync(`pnpm nx run-many -t add-extra-dependencies --parallel 8`, {
+      stdio: isVerboseLogging ? [0, 1, 2] : 'ignore',
+      maxBuffer: LARGE_BUFFER,
+    });
+
     let changelogCommand = `pnpm nx release changelog ${options.version} --tagVersionPrefix="" --interactive`;
     if (options.from) {
       changelogCommand += ` --from ${options.from}`;
@@ -103,6 +108,11 @@ const LARGE_BUFFER = 1024 * 1000000;
 
   runNxReleaseVersion();
 
+  execSync(`pnpm nx run-many -t add-extra-dependencies --parallel 8`, {
+    stdio: isVerboseLogging ? [0, 1, 2] : 'ignore',
+    maxBuffer: LARGE_BUFFER,
+  });
+
   if (options.dryRun) {
     console.warn('Not Publishing because --dryRun was passed');
   } else {