From 5e022951dafb4ccbbbf3689ea60776f94e173773 Mon Sep 17 00:00:00 2001
From: Emily Xiong <xiongemi@gmail.com>
Date: Thu, 27 Jun 2024 08:51:43 -0700
Subject: [PATCH] fix(graph): fix empty target group (#26704)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
![Screenshot 2024-06-26 at 2 56
04 PM](https://github.com/nrwl/nx/assets/16211801/d9cc93db-06a2-4c30-b88a-3054edfb619a)

when the others group are empty, it shows the container.
move the check to
graph/ui-project-details/src/lib/target-configuration-details-group-container/target-configuration-details-group-container.tsx.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
---
 .../target-configuration-details-group-container.tsx           | 3 +++
 .../target-configuration-details-group-list.tsx                | 3 ---
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/graph/ui-project-details/src/lib/target-configuration-details-group-container/target-configuration-details-group-container.tsx b/graph/ui-project-details/src/lib/target-configuration-details-group-container/target-configuration-details-group-container.tsx
index 6de9568be5..5d46556112 100644
--- a/graph/ui-project-details/src/lib/target-configuration-details-group-container/target-configuration-details-group-container.tsx
+++ b/graph/ui-project-details/src/lib/target-configuration-details-group-container/target-configuration-details-group-container.tsx
@@ -17,6 +17,9 @@ export function TargetConfigurationGroupContainer({
   nxConnectCallback,
   children,
 }: TargetConfigurationGroupContainerProps) {
+  if (targetsNumber === 0) {
+    return null;
+  }
   return (
     <div className="mb-4 w-full">
       <TargetConfigurationGroupHeader
diff --git a/graph/ui-project-details/src/lib/target-configuration-details-group-list/target-configuration-details-group-list.tsx b/graph/ui-project-details/src/lib/target-configuration-details-group-list/target-configuration-details-group-list.tsx
index 3a69998748..7f1fcf298d 100644
--- a/graph/ui-project-details/src/lib/target-configuration-details-group-list/target-configuration-details-group-list.tsx
+++ b/graph/ui-project-details/src/lib/target-configuration-details-group-list/target-configuration-details-group-list.tsx
@@ -47,9 +47,6 @@ export function TargetConfigurationGroupList({
       <>
         {Object.entries(targetsGroup.groups).map(
           ([targetGroupName, targets]) => {
-            if (targets.length === 0) {
-              return null;
-            }
             return (
               <TargetConfigurationGroupContainer
                 targetGroupName={targetGroupName}