From 648129fc4865c0e5d7dbaa1a2e3d04af914966fc Mon Sep 17 00:00:00 2001
From: Colum Ferry <cferry09@gmail.com>
Date: Wed, 5 Mar 2025 19:12:33 +0000
Subject: [PATCH] fix(bundling): remove migration always adding sass-embedded
 (#30276)

## Current Behavior
There is a migration that always adds `sass-embedded` for Rspack and
Webpack for 20.5

## Expected Behavior
`sass-embedded` is already a dependency of Rspack and Webpack and
therefore does not need to be added to users package.json - especially
as they may not be using it.
---
 .../packages/rspack/migrations/20.5.0-package-updates.json  | 3 +--
 .../packages/webpack/migrations/20.5.0-package-updates.json | 3 +--
 packages/rspack/migrations.json                             | 6 +-----
 packages/webpack/migrations.json                            | 4 ----
 4 files changed, 3 insertions(+), 13 deletions(-)

diff --git a/docs/generated/packages/rspack/migrations/20.5.0-package-updates.json b/docs/generated/packages/rspack/migrations/20.5.0-package-updates.json
index 1dabd5706d..226957294d 100644
--- a/docs/generated/packages/rspack/migrations/20.5.0-package-updates.json
+++ b/docs/generated/packages/rspack/migrations/20.5.0-package-updates.json
@@ -2,8 +2,7 @@
   "name": "20.5.0-package-updates",
   "version": "20.5.0-beta.4",
   "packages": {
-    "sass-embedded": { "version": "^1.83.4", "alwaysAddToPackageJson": true },
-    "sass-loader": { "version": "^16.0.4", "alwaysAddToPackageJson": true },
+    "sass-loader": { "version": "^16.0.4", "alwaysAddToPackageJson": false },
     "@rspack/core": { "version": "^1.2.2", "alwaysAddToPackageJson": false }
   },
   "aliases": [],
diff --git a/docs/generated/packages/webpack/migrations/20.5.0-package-updates.json b/docs/generated/packages/webpack/migrations/20.5.0-package-updates.json
index edc8be16e6..f3e975de88 100644
--- a/docs/generated/packages/webpack/migrations/20.5.0-package-updates.json
+++ b/docs/generated/packages/webpack/migrations/20.5.0-package-updates.json
@@ -2,8 +2,7 @@
   "name": "20.5.0-package-updates",
   "version": "20.5.0-beta.3",
   "packages": {
-    "sass-loader": { "version": "^16.0.4", "alwaysAddToPackageJson": false },
-    "sass-embedded": { "version": "^1.83.4", "alwaysAddToPackageJson": true }
+    "sass-loader": { "version": "^16.0.4", "alwaysAddToPackageJson": false }
   },
   "aliases": [],
   "description": "",
diff --git a/packages/rspack/migrations.json b/packages/rspack/migrations.json
index b9ead2bd05..0438a6efcb 100644
--- a/packages/rspack/migrations.json
+++ b/packages/rspack/migrations.json
@@ -98,13 +98,9 @@
     "20.5.0": {
       "version": "20.5.0-beta.4",
       "packages": {
-        "sass-embedded": {
-          "version": "^1.83.4",
-          "alwaysAddToPackageJson": true
-        },
         "sass-loader": {
           "version": "^16.0.4",
-          "alwaysAddToPackageJson": true
+          "alwaysAddToPackageJson": false
         },
         "@rspack/core": {
           "version": "^1.2.2",
diff --git a/packages/webpack/migrations.json b/packages/webpack/migrations.json
index 9431a00ede..dca26e03a9 100644
--- a/packages/webpack/migrations.json
+++ b/packages/webpack/migrations.json
@@ -42,10 +42,6 @@
         "sass-loader": {
           "version": "^16.0.4",
           "alwaysAddToPackageJson": false
-        },
-        "sass-embedded": {
-          "version": "^1.83.4",
-          "alwaysAddToPackageJson": true
         }
       }
     }