miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(rspack): do not reuse existing ts-node compiler options when inferring tasks (#30703)

Browse Source 
## Current Behavior

The `@nx/rspack` graph plugin reuses the potentially existing
`TS_NODE_COMPILER_OPTIONS` to set the `env` property of the inferred
tasks for a TS config file. This is not correct since the env var could
have a different value (or not exist at all) when running tasks compared
to when the graph plugin runs.

## Expected Behavior

The `@nx/rspack` graph plugin should not reuse any existing
`TS_NODE_COMPILER_OPTIONS` when inferring tasks for a TS config file.

## Related Issue(s)

Fixes #
This commit is contained in:
Leosvel Pérez Espinosa 2025-04-14 14:36:20 +02:00 committed by GitHub
parent 4cc3a39794
commit 70f1e660c8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/rspack/src/plugins/plugin.spec.ts
View File

@ -88,7 +88,7 @@ describe('@nx/rspack', () => {
], ],
"cwd": "my-app", "cwd": "my-app",
"env": { "env": {
"TS_NODE_COMPILER_OPTIONS": "{"moduleResolution":"Node10","module":"CommonJS","customConditions":null}", "TS_NODE_COMPILER_OPTIONS": "{"module":"CommonJS","moduleResolution":"Node10","customConditions":null}",
}, },
}, },
"outputs": [], "outputs": [],
@ -106,7 +106,7 @@ describe('@nx/rspack', () => {
], ],
"cwd": "my-app", "cwd": "my-app",
"env": { "env": {
"TS_NODE_COMPILER_OPTIONS": "{"moduleResolution":"Node10","module":"CommonJS","customConditions":null}", "TS_NODE_COMPILER_OPTIONS": "{"module":"CommonJS","moduleResolution":"Node10","customConditions":null}",
}, },
}, },
}, },
@ -118,7 +118,7 @@ describe('@nx/rspack', () => {
], ],
"cwd": "my-app", "cwd": "my-app",
"env": { "env": {
"TS_NODE_COMPILER_OPTIONS": "{"moduleResolution":"Node10","module":"CommonJS","customConditions":null}", "TS_NODE_COMPILER_OPTIONS": "{"module":"CommonJS","moduleResolution":"Node10","customConditions":null}",
}, },
}, },
}, },

2
packages/rspack/src/plugins/plugin.ts
View File

@ -182,9 +182,7 @@ async function createRspackTargets(
const isTsConfig = ['.ts', '.cts', '.mts'].includes(extname(configFilePath)); const isTsConfig = ['.ts', '.cts', '.mts'].includes(extname(configFilePath));
if (isTsConfig) { if (isTsConfig) {
// https://rspack.dev/config/#using-ts-node // https://rspack.dev/config/#using-ts-node
const existingValue = process.env['TS_NODE_COMPILER_OPTIONS'];
env['TS_NODE_COMPILER_OPTIONS'] = JSON.stringify({ env['TS_NODE_COMPILER_OPTIONS'] = JSON.stringify({
...(existingValue ? JSON.parse(existingValue) : {}),
module: 'CommonJS', module: 'CommonJS',
moduleResolution: 'Node10', moduleResolution: 'Node10',
customConditions: null, customConditions: null,