miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(angular): normalize prerender and appShell options of the application executor correctly (#29281)

Browse Source 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #29276
This commit is contained in:
Leosvel Pérez Espinosa 2024-12-10 15:12:51 +01:00 committed by GitHub
parent df77fde81f
commit 7fca6e236a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
packages/angular/src/executors/application/utils/normalize-options.ts
View File

@ -28,11 +28,12 @@ export function normalizeOptions(
} }
} }
return { let appShell = options.appShell;
...options, let prerender = options.prerender;
appShell: angularMajorVersion < 19 ? options.appShell ?? false : undefined, if (angularMajorVersion < 19) {
prerender: appShell ??= false;
angularMajorVersion < 19 ? options.prerender ?? false : undefined, prerender ??= false;
security, }
};
return { ...options, appShell, prerender, security };
} }