chore(repo): assign proper outputs to build targets (#30865)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

`nx:build` cannot be run in parallel with any other tasks. It was an
improper fix for an issue we were facing in our task graph. This is also
not workable if any continuous tasks are running.. which I want
`local-registry` to be running while things are built.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

The proper outputs are set on `build` targets. Most of them only need
`README.md` as the output. `nx`, `create-nx-workspace`, and
`create-nx-plugin` are different and need a few more files.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
This commit is contained in:
Jason Jean 2025-04-25 13:23:44 -04:00 committed by GitHub
parent 840aef802f
commit 8214ab49f2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
34 changed files with 70 additions and 136 deletions

View File

@ -58,13 +58,9 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands",
"outputs": ["{workspaceRoot}/build/packages/angular"],
"dependsOn": ["build-ng", "build-base", "^build"], "dependsOn": ["build-ng", "build-base", "^build"],
"options": { "outputs": ["{workspaceRoot}/build/packages/angular/README.md"],
"command": "node ./scripts/copy-readme.js angular", "command": "node ./scripts/copy-readme.js angular"
"parallel": false
}
} }
}, },
"implicitDependencies": [] "implicitDependencies": []

View File

@ -46,7 +46,10 @@
}, },
"build": { "build": {
"executor": "nx:run-commands", "executor": "nx:run-commands",
"outputs": ["{workspaceRoot}/build/packages/create-nx-plugin"], "outputs": [
"{workspaceRoot}/build/packages/create-nx-plugin/bin/create-nx-plugin.js",
"{workspaceRoot}/build/packages/create-nx-plugin/README.md"
],
"options": { "options": {
"commands": [ "commands": [
{ {

View File

@ -46,7 +46,10 @@
}, },
"build": { "build": {
"executor": "nx:run-commands", "executor": "nx:run-commands",
"outputs": ["{workspaceRoot}/build/packages/create-nx-workspace"], "outputs": [
"{workspaceRoot}/build/packages/create-nx-workspace/bin/create-nx-workspace.js",
"{workspaceRoot}/build/packages/create-nx-workspace/README.md"
],
"options": { "options": {
"commands": [ "commands": [
{ {

View File

@ -44,11 +44,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/cypress/README.md"],
"outputs": ["{workspaceRoot}/build/packages/cypress"], "command": "node ./scripts/copy-readme.js cypress"
"options": {
"command": "node ./scripts/copy-readme.js cypress"
}
} }
} }
} }

View File

@ -43,11 +43,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/detox/README.md"],
"outputs": ["{workspaceRoot}/build/packages/detox"], "command": "node ./scripts/copy-readme.js detox"
"options": {
"command": "node ./scripts/copy-readme.js detox"
}
} }
} }
} }

View File

@ -44,11 +44,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/devkit/README.md"],
"outputs": ["{workspaceRoot}/build/packages/devkit"], "command": "node ./scripts/copy-readme.js devkit"
"options": {
"command": "node ./scripts/copy-readme.js devkit"
}
} }
} }
} }

View File

@ -44,11 +44,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/esbuild/README.md"],
"outputs": ["{workspaceRoot}/build/packages/esbuild"], "commands": ["node ./scripts/copy-readme.js esbuild"]
"options": {
"commands": ["node ./scripts/copy-readme.js esbuild"]
}
} }
} }
} }

View File

@ -45,11 +45,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/eslint-plugin/README.md"],
"outputs": ["{workspaceRoot}/build/packages/eslint-plugin"], "command": "node ./scripts/copy-readme.js eslint-plugin"
"options": {
"command": "node ./scripts/copy-readme.js eslint-plugin"
}
} }
} }
} }

View File

@ -44,11 +44,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/eslint/README.md"],
"outputs": ["{workspaceRoot}/build/packages/eslint"], "command": "node ./scripts/copy-readme.js eslint"
"options": {
"command": "node ./scripts/copy-readme.js eslint"
}
} }
}, },
"implicitDependencies": ["eslint-plugin"] "implicitDependencies": ["eslint-plugin"]

View File

@ -45,11 +45,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/expo/README.md"],
"outputs": ["{workspaceRoot}/build/packages/expo"], "command": "node ./scripts/copy-readme.js expo"
"options": {
"command": "node ./scripts/copy-readme.js expo"
}
} }
}, },
"tags": [] "tags": []

View File

@ -44,11 +44,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/express/README.md"],
"outputs": ["{workspaceRoot}/build/packages/express"], "command": "node ./scripts/copy-readme.js express"
"options": {
"command": "node ./scripts/copy-readme.js express"
}
} }
}, },
"implicitDependencies": ["node"] "implicitDependencies": ["node"]

View File

@ -51,11 +51,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/gradle/README.md"],
"outputs": ["{workspaceRoot}/build/packages/gradle"], "command": "node ./scripts/copy-readme.js gradle"
"options": {
"command": "node ./scripts/copy-readme.js gradle"
}
} }
}, },
"tags": [] "tags": []

View File

@ -44,11 +44,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/jest/README.md"],
"outputs": ["{workspaceRoot}/build/packages/jest"], "command": "node ./scripts/copy-readme.js jest"
"options": {
"command": "node ./scripts/copy-readme.js jest"
}
} }
} }
} }

View File

@ -45,11 +45,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/js/README.md"],
"outputs": ["{workspaceRoot}/build/packages/js"], "command": "node ./scripts/copy-readme.js js"
"options": {
"command": "node ./scripts/copy-readme.js js"
}
} }
}, },
"tags": [] "tags": []

View File

@ -49,7 +49,7 @@
}, },
"build": { "build": {
"command": "node ./scripts/copy-readme.js module-federation", "command": "node ./scripts/copy-readme.js module-federation",
"outputs": ["{workspaceRoot}/build/packages/module-federation"] "outputs": ["{workspaceRoot}/build/packages/module-federation/README.md"]
} }
} }
} }

View File

@ -44,11 +44,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/nest/README.md"],
"outputs": ["{workspaceRoot}/build/packages/nest"], "command": "node ./scripts/copy-readme.js nest"
"options": {
"command": "node ./scripts/copy-readme.js nest"
}
} }
}, },
"implicitDependencies": ["node", "eslint"] "implicitDependencies": ["node", "eslint"]

View File

@ -49,11 +49,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/next/README.md"],
"outputs": ["{workspaceRoot}/build/packages/next"], "command": "node ./scripts/copy-readme.js next"
"options": {
"command": "node ./scripts/copy-readme.js next"
}
} }
} }
} }

View File

@ -44,11 +44,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/node/README.md"],
"outputs": ["{workspaceRoot}/build/packages/node"], "command": "node ./scripts/copy-readme.js node"
"options": {
"command": "node ./scripts/copy-readme.js node"
}
} }
} }
} }

View File

@ -54,7 +54,7 @@
}, },
"build": { "build": {
"command": "node ./scripts/copy-readme.js nuxt", "command": "node ./scripts/copy-readme.js nuxt",
"outputs": ["{workspaceRoot}/build/packages/nuxt"] "outputs": ["{workspaceRoot}/build/packages/nuxt/README.md"]
} }
} }
} }

View File

@ -106,7 +106,6 @@
"command": "echo hi" "command": "echo hi"
}, },
"build": { "build": {
"parallelism": false,
"dependsOn": ["^build-client", "build-base", "build-native"], "dependsOn": ["^build-client", "build-base", "build-native"],
"inputs": [ "inputs": [
"production", "production",
@ -116,7 +115,12 @@
} }
], ],
"executor": "nx:run-commands", "executor": "nx:run-commands",
"outputs": ["{workspaceRoot}/build/packages/nx"], "outputs": [
"{workspaceRoot}/build/packages/nx/**/*.{node,wasm,js,mjs,cjs}",
"{workspaceRoot}/build/packages/nx/src/core/graph",
"{workspaceRoot}/build/packages/nx/bin/nx.js",
"{workspaceRoot}/build/packages/nx/README.md"
],
"options": { "options": {
"commands": [ "commands": [
{ {

View File

@ -5,11 +5,8 @@
"projectType": "library", "projectType": "library",
"targets": { "targets": {
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/playwright/README.md"],
"outputs": ["{workspaceRoot}/build/packages/playwright"], "commands": ["node ./scripts/copy-readme.js playwright"]
"options": {
"commands": ["node ./scripts/copy-readme.js playwright"]
}
}, },
"build-base": { "build-base": {
"executor": "@nx/js:tsc", "executor": "@nx/js:tsc",

View File

@ -44,11 +44,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/plugin/README.md"],
"outputs": ["{workspaceRoot}/build/packages/plugin"], "command": "node ./scripts/copy-readme.js plugin"
"options": {
"command": "node ./scripts/copy-readme.js plugin"
}
} }
} }
} }

View File

@ -39,11 +39,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/react-native/README.md"],
"outputs": ["{workspaceRoot}/build/packages/react-native"], "command": "node ./scripts/copy-readme.js react-native"
"options": {
"command": "node ./scripts/copy-readme.js react-native"
}
} }
} }
} }

View File

@ -54,11 +54,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/react/README.md"],
"outputs": ["{workspaceRoot}/build/packages/react"], "command": "node ./scripts/copy-readme.js react"
"options": {
"command": "node ./scripts/copy-readme.js react"
}
} }
} }
} }

View File

@ -6,7 +6,7 @@
"targets": { "targets": {
"build": { "build": {
"command": "node ./scripts/copy-readme.js remix", "command": "node ./scripts/copy-readme.js remix",
"outputs": ["{workspaceRoot}/build/packages/remix"] "outputs": ["{workspaceRoot}/build/packages/remix/README.md"]
}, },
"build-base": { "build-base": {
"executor": "@nx/js:tsc", "executor": "@nx/js:tsc",

View File

@ -44,11 +44,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/rollup/README.md"],
"outputs": ["{workspaceRoot}/build/packages/rollup"], "command": "node ./scripts/copy-readme.js rollup"
"options": {
"command": "node ./scripts/copy-readme.js rollup"
}
} }
} }
} }

View File

@ -49,7 +49,7 @@
}, },
"build": { "build": {
"command": "node ./scripts/copy-readme.js rsbuild", "command": "node ./scripts/copy-readme.js rsbuild",
"outputs": ["{workspaceRoot}/build/packages/rsbuild"] "outputs": ["{workspaceRoot}/build/packages/rsbuild/README.md"]
} }
} }
} }

View File

@ -5,11 +5,8 @@
"projectType": "library", "projectType": "library",
"targets": { "targets": {
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/rspack/README.md"],
"outputs": ["{workspaceRoot}/build/packages/rspack"], "command": "node ./scripts/copy-readme.js rspack"
"options": {
"command": "node ./scripts/copy-readme.js rspack"
}
}, },
"build-base": { "build-base": {
"dependsOn": ["^build-base"], "dependsOn": ["^build-base"],

View File

@ -54,11 +54,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/storybook/README.md"],
"outputs": ["{workspaceRoot}/build/packages/storybook"], "command": "node ./scripts/copy-readme.js storybook"
"options": {
"command": "node ./scripts/copy-readme.js storybook"
}
} }
} }
} }

View File

@ -49,11 +49,8 @@
"outputs": ["{options.outputPath}"] "outputs": ["{options.outputPath}"]
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/vite/README.md"],
"outputs": ["{workspaceRoot}/build/packages/vite"], "command": "node ./scripts/copy-readme.js vite"
"options": {
"command": "node ./scripts/copy-readme.js vite"
}
} }
} }
} }

View File

@ -54,7 +54,7 @@
}, },
"build": { "build": {
"command": "node ./scripts/copy-readme.js vue", "command": "node ./scripts/copy-readme.js vue",
"outputs": ["{workspaceRoot}/build/packages/vue"] "outputs": ["{workspaceRoot}/build/packages/vue/README.md"]
} }
} }
} }

View File

@ -49,11 +49,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/web/README.md"],
"outputs": ["{workspaceRoot}/build/packages/web"], "command": "node ./scripts/copy-readme.js web"
"options": {
"command": "node ./scripts/copy-readme.js web"
}
} }
} }
} }

View File

@ -44,11 +44,8 @@
} }
}, },
"build": { "build": {
"executor": "nx:run-commands", "outputs": ["{workspaceRoot}/build/packages/webpack/README.md"],
"outputs": ["{workspaceRoot}/build/packages/webpack"], "command": "node ./scripts/copy-readme.js webpack"
"options": {
"command": "node ./scripts/copy-readme.js webpack"
}
} }
} }
} }

View File

@ -74,7 +74,7 @@
} }
}, },
"build": { "build": {
"outputs": ["{workspaceRoot}/build/packages/workspace"], "outputs": ["{workspaceRoot}/build/packages/workspace/README.md"],
"command": "node ./scripts/copy-readme.js workspace" "command": "node ./scripts/copy-readme.js workspace"
}, },
"add-extra-dependencies": { "add-extra-dependencies": {