miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(core): make forked-process-task-runner robust to closed processes (#14289)

Browse Source
This commit is contained in:
Scott Bessler 2023-01-12 07:22:19 -08:00 committed by GitHub
parent a5766a86a1
commit 8518f69ff8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/nx/src/tasks-runner/forked-process-task-runner.ts
View File

@ -60,6 +60,7 @@ export class ForkedProcessTaskRunner {
this.processes.add(p); this.processes.add(p);
p.once('exit', (code, signal) => { p.once('exit', (code, signal) => {
this.processes.delete(p);
if (code === null) code = this.signalToCode(signal); if (code === null) code = this.signalToCode(signal);
if (code !== 0) { if (code !== 0) {
const results: BatchResults = {}; const results: BatchResults = {};
@ -171,6 +172,7 @@ export class ForkedProcessTaskRunner {
}); });
p.on('exit', (code, signal) => { p.on('exit', (code, signal) => {
this.processes.delete(p);
if (code === null) code = this.signalToCode(signal); if (code === null) code = this.signalToCode(signal);
// we didn't print any output as we were running the command // we didn't print any output as we were running the command
// print all the collected output| // print all the collected output|
@ -407,28 +409,36 @@ export class ForkedProcessTaskRunner {
// When the nx process gets a message, it will be sent into the task's process // When the nx process gets a message, it will be sent into the task's process
process.on('message', (message: Serializable) => { process.on('message', (message: Serializable) => {
this.processes.forEach((p) => { this.processes.forEach((p) => {
if (p.connected) {
p.send(message); p.send(message);
}
}); });
}); });
// Terminate any task processes on exit // Terminate any task processes on exit
process.on('SIGINT', () => { process.on('SIGINT', () => {
this.processes.forEach((p) => { this.processes.forEach((p) => {
if (p.connected) {
p.kill('SIGTERM'); p.kill('SIGTERM');
}
}); });
// we exit here because we don't need to write anything to cache. // we exit here because we don't need to write anything to cache.
process.exit(); process.exit();
}); });
process.on('SIGTERM', () => { process.on('SIGTERM', () => {
this.processes.forEach((p) => { this.processes.forEach((p) => {
if (p.connected) {
p.kill('SIGTERM'); p.kill('SIGTERM');
}
}); });
// no exit here because we expect child processes to terminate which // no exit here because we expect child processes to terminate which
// will store results to the cache and will terminate this process // will store results to the cache and will terminate this process
}); });
process.on('SIGHUP', () => { process.on('SIGHUP', () => {
this.processes.forEach((p) => { this.processes.forEach((p) => {
if (p.connected) {
p.kill('SIGTERM'); p.kill('SIGTERM');
}
}); });
// no exit here because we expect child processes to terminate which // no exit here because we expect child processes to terminate which
// will store results to the cache and will terminate this process // will store results to the cache and will terminate this process