miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(vite): Only attempt to amend test object if one exists (#26822)

Browse Source 
Test object is assigned using optional chaining but previously did not
check that any value had actually been assigned which would cause the
`getStart` call to fail resulting in a failed migration.

## Current Behavior
Migration fails if no matching test object is found.

## Expected Behavior
Migration should not fail.

## Related Issue(s)
I haven't opened an issue, just the PR. I can open an issue if required
for tracking.
This commit is contained in:
Jasper McCulloch 2024-07-09 14:47:37 +01:00 committed by GitHub
parent 73858a094e
commit 8fd38cba9a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/vite/src/migrations/update-17-3-0/lib/fix-coverage-and-reporters.ts
View File

@ -102,12 +102,15 @@ export function fixCoverageAndRerporters(
configNode, configNode,
`PropertyAssignment:has(Identifier[name="test"])` `PropertyAssignment:has(Identifier[name="test"])`
)?.[0]; )?.[0];
if (testObject) {
changes.push({ changes.push({
type: ChangeType.Insert, type: ChangeType.Insert,
index: testObject.getStart() + `test: {`.length + 1, index: testObject.getStart() + `test: {`.length + 1,
text: `reporters: ['default'],`, text: `reporters: ['default'],`,
}); });
} }
}
if (changes.length > 0) { if (changes.length > 0) {
return applyChangesToString(configContents, changes); return applyChangesToString(configContents, changes);