miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(testing): remove dependency on @nx/vite and @nx/webpack from @nx/playwright (#30023)

Browse Source
This commit is contained in:
Craigory Coppola 2025-02-13 10:16:31 -05:00 committed by GitHub
parent b5df8c25be
commit 9234241570
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/playwright/.eslintrc.json
View File

@ -29,7 +29,13 @@
"error", "error",
{ {
"buildTargets": ["build-base"], "buildTargets": ["build-base"],
"ignoredDependencies": ["nx", "typescript", "@playwright/test"] "ignoredDependencies": [
"nx",
"typescript",
"@playwright/test",
"@nx/webpack",
"@nx/vite"
]
} }
] ]
} }

2
packages/playwright/package.json
View File

@ -37,8 +37,6 @@
"@phenomnomnominal/tsquery": "~5.0.1", "@phenomnomnominal/tsquery": "~5.0.1",
"@nx/devkit": "file:../devkit", "@nx/devkit": "file:../devkit",
"@nx/eslint": "file:../eslint", "@nx/eslint": "file:../eslint",
"@nx/webpack": "file:../webpack",
"@nx/vite": "file:../vite",
"@nx/js": "file:../js", "@nx/js": "file:../js",
"tslib": "^2.3.0", "tslib": "^2.3.0",
"minimatch": "9.0.3" "minimatch": "9.0.3"

9
packages/playwright/src/migrations/update-19-6-0/use-serve-static-preview-for-command.ts
View File

@ -15,8 +15,6 @@ import type { ConfigurationResult } from 'nx/src/project-graph/utils/project-con
import { LoadedNxPlugin } from 'nx/src/project-graph/plugins/loaded-nx-plugin'; import { LoadedNxPlugin } from 'nx/src/project-graph/plugins/loaded-nx-plugin';
import { retrieveProjectConfigurations } from 'nx/src/project-graph/utils/retrieve-workspace-files'; import { retrieveProjectConfigurations } from 'nx/src/project-graph/utils/retrieve-workspace-files';
import { ProjectConfigurationsError } from 'nx/src/project-graph/error-types'; import { ProjectConfigurationsError } from 'nx/src/project-graph/error-types';
import { createNodesV2 as webpackCreateNodesV2 } from '@nx/webpack/src/plugins/plugin';
import { createNodesV2 as viteCreateNodesV2 } from '@nx/vite/plugin';
import type { Node } from 'typescript'; import type { Node } from 'typescript';
export default async function (tree: Tree) { export default async function (tree: Tree) {
@ -129,8 +127,11 @@ export default async function (tree: Tree) {
? 'serveStaticTargetName' ? 'serveStaticTargetName'
: 'previewTargetName', : 'previewTargetName',
projectToMigrate.configFileType === 'webpack' projectToMigrate.configFileType === 'webpack'
? webpackCreateNodesV2 ? (
: viteCreateNodesV2 require('@nx/webpack/plugin') as typeof import('@nx/webpack/plugin')
).createNodesV2
: (require('@nx/vite/plugin') as typeof import('@nx/vite/plugin'))
.createNodesV2
)) ?? )) ??
getServeStaticLikeTarget( getServeStaticLikeTarget(
tree, tree,