miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(js): throw an error when generating a publishable lib with --bundler=none (#28221)

Browse Source 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

Generating a JS publishable library with `--bundler=none` results in the
generator silently switching the `bundler` to `tsc` and generating a
`build` target.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Trying to generate a JS publishable library with `--bundler=none` should
throw an error.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->
<!-- Fixes NXC-1075 -->

Fixes #
This commit is contained in:
Leosvel Pérez Espinosa 2024-10-02 14:24:39 +02:00 committed by GitHub
parent b82ca22d65
commit 942f6fc2ea
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/js/src/generators/library/library.ts
View File

@ -856,7 +856,9 @@ async function normalizeOptions(
}
if (options.bundler === 'none') {
options.bundler = 'tsc';
throw new Error(
`Publishable libraries can't be generated with "--bundler=none". Please select a valid bundler.`
);
}
}

2
packages/nest/src/generators/library/lib/normalize-options.ts
View File

@ -64,7 +64,7 @@ export function toJsLibraryGeneratorOptions(
): JsLibraryGeneratorSchema {
return {
name: options.name,
bundler: options?.buildable ? 'tsc' : 'none',
bundler: options.buildable || options.publishable ? 'tsc' : 'none',
directory: options.directory,
importPath: options.importPath,
linter: options.linter,

2
packages/node/src/generators/library/library.ts
View File

@ -59,7 +59,7 @@ export async function libraryGeneratorInternal(tree: Tree, schema: Schema) {
const libraryInstall = await jsLibraryGenerator(tree, {
...options,
bundler: schema.buildable ? 'tsc' : 'none',
bundler: schema.buildable || schema.publishable ? 'tsc' : 'none',
includeBabelRc: schema.babelJest,
importPath: options.importPath,
testEnvironment: 'node',