From 9faafe5d7d38a865b16b1f33d12dc1dc2ab15a16 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Leosvel=20P=C3=A9rez=20Espinosa?=
 <leosvel.perez.espinosa@gmail.com>
Date: Fri, 28 Feb 2025 12:49:41 +0100
Subject: [PATCH] fix(js): normalize paths correctly in `@nx/js/typescript`
 plugin (#30216)

## Current Behavior

The tsconfig files cache contains invalid relative paths when run on
Windows.

Failure logs (Windows):
https://github.com/nrwl/nx-console/actions/runs/13573129754/job/37942898562?pr=2415#step:11:29

## Expected Behavior

The tsconfig files cache should contain valid Unix-based paths.

Success logs (Windows):
https://github.com/nrwl/nx-console/actions/runs/13586015039/job/37981054104#step:11:49
(the job failed but due to a separate thing, note the project graph was
computed correctly)

## Related Issue(s)

Fixes #
---
 packages/js/src/plugins/typescript/plugin.ts | 29 ++++++++++++--------
 1 file changed, 18 insertions(+), 11 deletions(-)

diff --git a/packages/js/src/plugins/typescript/plugin.ts b/packages/js/src/plugins/typescript/plugin.ts
index 1e88069321..810ebbb219 100644
--- a/packages/js/src/plugins/typescript/plugin.ts
+++ b/packages/js/src/plugins/typescript/plugin.ts
@@ -1032,7 +1032,7 @@ function isExternalProjectReference(
   workspaceRoot: string,
   projectRoot: string
 ): boolean {
-  const relativePath = posix.relative(workspaceRoot, refTsConfigPath);
+  const relativePath = posixRelative(workspaceRoot, refTsConfigPath);
   if (cache.isExternalProjectReference[relativePath] !== undefined) {
     return cache.isExternalProjectReference[relativePath];
   }
@@ -1074,7 +1074,7 @@ function retrieveTsConfigFromCache(
   tsConfigPath: string,
   workspaceRoot: string
 ): ParsedTsconfigData {
-  const relativePath = posix.relative(workspaceRoot, tsConfigPath);
+  const relativePath = posixRelative(workspaceRoot, tsConfigPath);
 
   // we don't need to check the hash if it's in the cache, because we've already
   // checked it when we initially populated the cache
@@ -1103,7 +1103,7 @@ function readTsConfigAndCache(
   tsConfigPath: string,
   workspaceRoot: string
 ): ParsedTsconfigData {
-  const relativePath = posix.relative(workspaceRoot, tsConfigPath);
+  const relativePath = posixRelative(workspaceRoot, tsConfigPath);
   const hash = getFileHash(tsConfigPath, workspaceRoot);
 
   let extendedFilesHash: string;
@@ -1261,7 +1261,7 @@ function resolveExtendedTsConfigPath(
 }
 
 function getFileHash(filePath: string, workspaceRoot: string): string {
-  const relativePath = posix.relative(workspaceRoot, filePath);
+  const relativePath = posixRelative(workspaceRoot, filePath);
   if (!cache.fileHashes[relativePath]) {
     const content = readFile(filePath, workspaceRoot);
     cache.fileHashes[relativePath] = hashArray([content]);
@@ -1271,7 +1271,7 @@ function getFileHash(filePath: string, workspaceRoot: string): string {
 }
 
 function readFile(filePath: string, workspaceRoot: string): string {
-  const relativePath = posix.relative(workspaceRoot, filePath);
+  const relativePath = posixRelative(workspaceRoot, filePath);
   if (!cache.rawFiles[relativePath]) {
     const content = readFileSync(filePath, 'utf8');
     cache.rawFiles[relativePath] = content;
@@ -1353,41 +1353,48 @@ function toRelativePaths(
       hash,
     };
     if (data.options.rootDir) {
-      updatedCache[key].data.options.rootDir = posix.relative(
+      updatedCache[key].data.options.rootDir = posixRelative(
         workspaceRoot,
         data.options.rootDir
       );
     }
     if (data.options.outDir) {
-      updatedCache[key].data.options.outDir = posix.relative(
+      updatedCache[key].data.options.outDir = posixRelative(
         workspaceRoot,
         data.options.outDir
       );
     }
     if (data.options.outFile) {
-      updatedCache[key].data.options.outFile = posix.relative(
+      updatedCache[key].data.options.outFile = posixRelative(
         workspaceRoot,
         data.options.outFile
       );
     }
     if (data.options.tsBuildInfoFile) {
-      updatedCache[key].data.options.tsBuildInfoFile = posix.relative(
+      updatedCache[key].data.options.tsBuildInfoFile = posixRelative(
         workspaceRoot,
         data.options.tsBuildInfoFile
       );
     }
     if (data.extendedConfigFile?.filePath) {
-      updatedCache[key].data.extendedConfigFile.filePath = posix.relative(
+      updatedCache[key].data.extendedConfigFile.filePath = posixRelative(
         workspaceRoot,
         data.extendedConfigFile.filePath
       );
     }
     if (data.projectReferences) {
       updatedCache[key].data.projectReferences = data.projectReferences.map(
-        (ref) => ({ ...ref, path: posix.relative(workspaceRoot, ref.path) })
+        (ref) => ({
+          ...ref,
+          path: posixRelative(workspaceRoot, ref.path),
+        })
       );
     }
   }
 
   return updatedCache;
 }
+
+function posixRelative(workspaceRoot: string, path: string): string {
+  return posix.normalize(relative(workspaceRoot, path));
+}