miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(release): remove duplicate space character in changelog thank you header (#28664)

Browse Source
This commit is contained in:
Thomas Dekiere 2024-11-20 14:14:50 +01:00 committed by GitHub
parent 09a01eb30c
commit a0d760f790
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 46 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/blog/2024-02-09-versioning-and-releasing-packages.md
View File

@ -188,7 +188,7 @@ It also generates a nice `CHANGELOG.md` for us:
- **buttons:** add new background shadow - **buttons:** add new background shadow
### ❤️ Thank You ### ❤️ Thank You
- Juri - Juri

4
e2e/release/src/release.test.ts
View File

@ -133,7 +133,7 @@ describe('nx release', () => {
+ +
+ - an awesome new feature ([{COMMIT_SHA}](https://github.com/nrwl/fake-repo/commit/{COMMIT_SHA})) + - an awesome new feature ([{COMMIT_SHA}](https://github.com/nrwl/fake-repo/commit/{COMMIT_SHA}))
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test @{COMMIT_AUTHOR} + - Test @{COMMIT_AUTHOR}
@ -153,7 +153,7 @@ describe('nx release', () => {
- an awesome new feature ([{COMMIT_SHA}](https://github.com/nrwl/fake-repo/commit/{COMMIT_SHA})) - an awesome new feature ([{COMMIT_SHA}](https://github.com/nrwl/fake-repo/commit/{COMMIT_SHA}))
### ❤️ Thank You ### ❤️ Thank You
- Test @{COMMIT_AUTHOR} - Test @{COMMIT_AUTHOR}
`); `);

40
e2e/release/src/version-plans.test.ts
View File

@ -178,7 +178,7 @@ Here is another line in the message.
+ +
+ - Update the fixed packages with a minor release. + - Update the fixed packages with a minor release.
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test` + - Test`
); );
@ -192,7 +192,7 @@ Here is another line in the message.
+ +
+ - Update the fixed packages with a minor release. + - Update the fixed packages with a minor release.
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test` + - Test`
); );
@ -208,7 +208,7 @@ Here is another line in the message.
+ +
+ Here is another line in the message. + Here is another line in the message.
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test` + - Test`
); );
@ -225,7 +225,7 @@ Here is another line in the message.
+ +
+ Here is another line in the message. + Here is another line in the message.
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test` + - Test`
); );
@ -242,7 +242,7 @@ Here is another line in the message.
+ +
+ Here is another line in the message. + Here is another line in the message.
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test` + - Test`
); );
@ -321,7 +321,7 @@ Update packages in both groups with a mix #2
+ +
+ - Update packages in both groups with a mix #2 + - Update packages in both groups with a mix #2
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test` + - Test`
); );
@ -336,7 +336,7 @@ Update packages in both groups with a mix #2
+ +
+ - Update packages in both groups with a mix #2 + - Update packages in both groups with a mix #2
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test + - Test
` `
@ -352,7 +352,7 @@ Update packages in both groups with a mix #2
+ +
+ - Update packages in both groups with a mix #1 + - Update packages in both groups with a mix #1
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test` + - Test`
); );
@ -368,7 +368,7 @@ Update packages in both groups with a mix #2
+ +
+ - Update packages in both groups with a mix #2 + - Update packages in both groups with a mix #2
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test` + - Test`
); );
@ -384,7 +384,7 @@ Update packages in both groups with a mix #2
+ +
+ - Update packages in both groups with a mix #2 + - Update packages in both groups with a mix #2
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test` + - Test`
); );
@ -549,7 +549,7 @@ const yargs = require('yargs');
+ +
+ - Update the fixed packages with a minor release. + - Update the fixed packages with a minor release.
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test` + - Test`
); );
@ -563,7 +563,7 @@ const yargs = require('yargs');
+ +
+ - Update the fixed packages with a minor release. + - Update the fixed packages with a minor release.
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test` + - Test`
); );
@ -577,7 +577,7 @@ const yargs = require('yargs');
+ +
+ - Update the independent packages with a patch, preminor, and prerelease. + - Update the independent packages with a patch, preminor, and prerelease.
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test` + - Test`
); );
@ -592,7 +592,7 @@ const yargs = require('yargs');
+ +
+ - Update the independent packages with a patch, preminor, and prerelease. + - Update the independent packages with a patch, preminor, and prerelease.
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test` + - Test`
); );
@ -607,7 +607,7 @@ const yargs = require('yargs');
+ +
+ - Update the independent packages with a patch, preminor, and prerelease. + - Update the independent packages with a patch, preminor, and prerelease.
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test` + - Test`
); );
@ -689,7 +689,7 @@ Update packages in both groups with a mix #2
+ +
+ - Update packages in both groups with a mix #2 + - Update packages in both groups with a mix #2
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test` + - Test`
); );
@ -704,7 +704,7 @@ Update packages in both groups with a mix #2
+ +
+ - Update packages in both groups with a mix #2 + - Update packages in both groups with a mix #2
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test + - Test
` `
@ -720,7 +720,7 @@ Update packages in both groups with a mix #2
+ +
+ - Update packages in both groups with a mix #1 + - Update packages in both groups with a mix #1
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test` + - Test`
); );
@ -736,7 +736,7 @@ Update packages in both groups with a mix #2
+ +
+ - Update packages in both groups with a mix #2 + - Update packages in both groups with a mix #2
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test` + - Test`
); );
@ -752,7 +752,7 @@ Update packages in both groups with a mix #2
+ +
+ - Update packages in both groups with a mix #2 + - Update packages in both groups with a mix #2
+ +
+ ### ❤️ Thank You + ### ❤️ Thank You
+ +
+ - Test` + - Test`
); );

20
packages/nx/release/changelog-renderer/index.spec.ts
View File

@ -168,7 +168,7 @@ describe('ChangelogRenderer', () => {
- all packages fixed - all packages fixed
- **pkg-a:** squashing bugs - **pkg-a:** squashing bugs
### ❤️ Thank You ### ❤️ Thank You
- James Henry" - James Henry"
`); `);
@ -235,7 +235,7 @@ describe('ChangelogRenderer', () => {
- all packages fixed - all packages fixed
- **pkg-a:** squashing bugs - **pkg-a:** squashing bugs
### ❤️ Thank You ### ❤️ Thank You
- James Henry" - James Henry"
`); `);
@ -279,7 +279,7 @@ describe('ChangelogRenderer', () => {
- all packages fixed - all packages fixed
### ❤️ Thank You ### ❤️ Thank You
- James Henry" - James Henry"
`); `);
@ -427,7 +427,7 @@ describe('ChangelogRenderer', () => {
- all packages fixed - all packages fixed
- **pkg-a:** squashing bugs - **pkg-a:** squashing bugs
### ❤️ Thank You ### ❤️ Thank You
- Author 1 - Author 1
- Author 3 - Author 3
@ -451,7 +451,7 @@ describe('ChangelogRenderer', () => {
- all packages fixed - all packages fixed
### ❤️ Thank You ### ❤️ Thank You
- Author 1 - Author 1
- Author 2 - Author 2
@ -575,7 +575,7 @@ describe('ChangelogRenderer', () => {
- **release:** Revert "fix(release): do not update dependents when they already use "*" (#20607)" - **release:** Revert "fix(release): do not update dependents when they already use "*" (#20607)"
### ❤️ Thank You ### ❤️ Thank You
- James Henry" - James Henry"
`); `);
@ -699,7 +699,7 @@ describe('ChangelogRenderer', () => {
- ⚠️ **WebSocketSubject:** no longer extends \`Subject\`. - ⚠️ **WebSocketSubject:** no longer extends \`Subject\`.
### ❤️ Thank You ### ❤️ Thank You
- James Henry" - James Henry"
`); `);
@ -752,7 +752,7 @@ describe('ChangelogRenderer', () => {
- **WebSocketSubject:** \`WebSocketSubject\` is no longer \`instanceof Subject\`. Check for \`instanceof WebSocketSubject\` instead. - **WebSocketSubject:** \`WebSocketSubject\` is no longer \`instanceof Subject\`. Check for \`instanceof WebSocketSubject\` instead.
### ❤️ Thank You ### ❤️ Thank You
- James Henry" - James Henry"
`); `);
@ -795,7 +795,7 @@ describe('ChangelogRenderer', () => {
- Updated pkg-b to 2.0.0 - Updated pkg-b to 2.0.0
### ❤️ Thank You ### ❤️ Thank You
- James Henry" - James Henry"
`); `);
@ -867,7 +867,7 @@ describe('ChangelogRenderer', () => {
- all packages fixed - all packages fixed
- **pkg-a:** squashing bugs - **pkg-a:** squashing bugs
### ❤️ Thank You ### ❤️ Thank You
- James Henry" - James Henry"
`); `);

2
packages/nx/release/changelog-renderer/index.ts
View File

@ -403,7 +403,7 @@ export default class DefaultChangelogRenderer {
if (authors.length > 0) { if (authors.length > 0) {
markdownLines.push( markdownLines.push(
'', '',
'### ' + '❤️ Thank You', '### ' + '❤️ Thank You',
'', '',
...authors ...authors
.sort((a, b) => a.name.localeCompare(b.name)) .sort((a, b) => a.name.localeCompare(b.name))

24
packages/nx/src/command-line/release/utils/markdown.spec.ts
View File

@ -11,7 +11,7 @@ describe('markdown utils', () => {
- **baz:** bugfix for baz - **baz:** bugfix for baz
### ❤️ Thank You ### ❤️ Thank You
- James Henry - James Henry
@ -26,7 +26,7 @@ describe('markdown utils', () => {
- **bar:** some bugfix in bar - **bar:** some bugfix in bar
### ❤️ Thank You ### ❤️ Thank You
- James Henry - James Henry
`; `;
@ -38,7 +38,7 @@ describe('markdown utils', () => {
- **baz:** bugfix for baz - **baz:** bugfix for baz
### ❤️ Thank You ### ❤️ Thank You
- James Henry", - James Henry",
"version": "0.0.3", "version": "0.0.3",
@ -52,7 +52,7 @@ describe('markdown utils', () => {
- **bar:** some bugfix in bar - **bar:** some bugfix in bar
### ❤️ Thank You ### ❤️ Thank You
- James Henry", - James Henry",
"version": "0.0.2", "version": "0.0.2",
@ -71,7 +71,7 @@ describe('markdown utils', () => {
- **baz:** bugfix for baz - **baz:** bugfix for baz
### ❤️ Thank You ### ❤️ Thank You
- James Henry - James Henry
@ -86,7 +86,7 @@ describe('markdown utils', () => {
- **bar:** some bugfix in bar - **bar:** some bugfix in bar
### ❤️ Thank You ### ❤️ Thank You
- James Henry - James Henry
`; `;
@ -98,7 +98,7 @@ describe('markdown utils', () => {
- **baz:** bugfix for baz - **baz:** bugfix for baz
### ❤️ Thank You ### ❤️ Thank You
- James Henry", - James Henry",
"version": "0.0.3-alpha.1", "version": "0.0.3-alpha.1",
@ -112,7 +112,7 @@ describe('markdown utils', () => {
- **bar:** some bugfix in bar - **bar:** some bugfix in bar
### ❤️ Thank You ### ❤️ Thank You
- James Henry", - James Henry",
"version": "0.0.2-beta.256", "version": "0.0.2-beta.256",
@ -131,7 +131,7 @@ describe('markdown utils', () => {
- **baz:** bugfix for baz - **baz:** bugfix for baz
### ❤️ Thank You ### ❤️ Thank You
- James Henry - James Henry
@ -146,7 +146,7 @@ describe('markdown utils', () => {
- **bar:** some bugfix in bar - **bar:** some bugfix in bar
### ❤️ Thank You ### ❤️ Thank You
- James Henry - James Henry
`; `;
@ -158,7 +158,7 @@ describe('markdown utils', () => {
- **baz:** bugfix for baz - **baz:** bugfix for baz
### ❤️ Thank You ### ❤️ Thank You
- James Henry", - James Henry",
"version": "1.0.1", "version": "1.0.1",
@ -172,7 +172,7 @@ describe('markdown utils', () => {
- **bar:** some bugfix in bar - **bar:** some bugfix in bar
### ❤️ Thank You ### ❤️ Thank You
- James Henry", - James Henry",
"version": "1.0.0", "version": "1.0.0",