miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(repo): cleanup old plugins promise (#29295)

Browse Source 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

When plugins in `nx.json` are changed, the daemon can no longer
communicate with plugin workers and create the graph. It will just hang
waiting for messages to go through.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Proper cleanup is done when plugins in `nx.json` are changed and the
daemon continues responding properly with project graphs.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
This commit is contained in:
Jason Jean 2024-12-10 15:36:41 -05:00 committed by GitHub
parent f415595508
commit a2670639db
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/nx/src/project-graph/plugins/get-plugins.ts
View File

@ -24,6 +24,7 @@ export async function getPlugins() {
// Cleanup current plugins before loading new ones // Cleanup current plugins before loading new ones
if (cleanup) { if (cleanup) {
pendingPluginsPromise = undefined;
cleanup(); cleanup();
} }
@ -50,6 +51,7 @@ export async function getOnlyDefaultPlugins() {
// Cleanup current plugins before loading new ones // Cleanup current plugins before loading new ones
if (cleanupDefaultPlugins) { if (cleanupDefaultPlugins) {
pendingDefaultPluginPromise = undefined;
cleanupDefaultPlugins(); cleanupDefaultPlugins();
} }