miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

chore(js): re-enable skipped test (#19427)

Browse Source
This commit is contained in:
Jack Hsu 2023-10-03 13:18:12 -04:00 committed by GitHub
parent 2d70eb048f
commit a9230f289f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 31 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
e2e/esbuild/src/esbuild.test.ts
View File

@ -106,8 +106,12 @@ describe('EsBuild Plugin', () => {
readFile(`dist/libs/${myPkg}/assets/a.md`).includes('initial a');
updateFile(`libs/${myPkg}/assets/a.md`, 'updated a');
await expect(
waitUntil(() =>
readFile(`dist/libs/${myPkg}/assets/a.md`).includes('updated a')
waitUntil(
() => readFile(`dist/libs/${myPkg}/assets/a.md`).includes('updated a'),
{
timeout: 20_000,
ms: 500,
}
)
).resolves.not.toThrow();
watchProcess.kill();

31
e2e/js/src/js-executor-tsc.test.ts
View File

@ -27,8 +27,7 @@ describe('js:tsc executor', () => {
beforeAll(() => (scope = newProject()));
afterAll(() => cleanupProject());
// TODO: Re-enable this when it is passing again
xit('should create libs with js executors (--compiler=tsc)', async () => {
it('should create libs with js executors (--compiler=tsc)', async () => {
const lib = uniq('lib');
runCLI(`generate @nx/js:lib ${lib} --bundler=tsc --no-interactive`);
const libPackageJson = readJson(`libs/${lib}/package.json`);
@ -71,20 +70,36 @@ describe('js:tsc executor', () => {
});
updateFile(`libs/${lib}/docs/a/b/nested.md`, 'Nested File');
await expect(
waitUntil(() =>
readFile(`dist/libs/${lib}/README.md`).includes(`Hello, World!`)
waitUntil(
() => readFile(`dist/libs/${lib}/README.md`).includes(`Hello, World!`),
{
timeout: 20_000,
ms: 500,
}
)
).resolves.not.toThrow();
await expect(
waitUntil(() =>
readFile(`dist/libs/${lib}/docs/a/b/nested.md`).includes(`Nested File`)
waitUntil(
() =>
readFile(`dist/libs/${lib}/docs/a/b/nested.md`).includes(
`Nested File`
),
{
timeout: 20_000,
ms: 500,
}
)
).resolves.not.toThrow();
await expect(
waitUntil(() =>
waitUntil(
() =>
readFile(`dist/libs/${lib}/package.json`).includes(
`"version": "999.9.9"`
)
),
{
timeout: 20_000,
ms: 500,
}
)
).resolves.not.toThrow();
libBuildProcess.kill();