miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(core): update fork task runner so it propagates exit signals (#30998)

Browse Source 
This is a fix when using the TUI `forked process-task-runner`. The
`SIGINT` and other signals are not handled, which causes the underlying
process (in this case `run-executor`) to be left hanging.

## Current Behavior
TUI leaves processes hanging when using `forked-process-task-runner`

## Expected Behavior

TUI should kill processes
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
This commit is contained in:
Jack Hsu 2025-05-02 09:52:58 -04:00 committed by GitHub
parent ed3788fd2b
commit aa92b3361c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
packages/nx/src/tasks-runner/fork.ts
View File

@ -1,6 +1,7 @@
import { fork, Serializable } from 'child_process';
import { join } from 'path';
import { PseudoIPCClient } from './pseudo-ipc';
import { signalToCode } from '../utils/exit-codes';
const pseudoIPCPath = process.argv[2];
const forkId = process.argv[3];
@ -35,3 +36,18 @@ childProcess.on('exit', (code) => {
pseudoIPC.close();
process.exit(code);
});
// Terminate the child process when exiting
process.on('exit', () => {
childProcess.kill();
});
process.on('SIGINT', () => {
childProcess.kill('SIGTERM');
process.exit(signalToCode('SIGINT'));
});
process.on('SIGTERM', () => {
childProcess.kill('SIGTERM');
});
process.on('SIGHUP', () => {
childProcess.kill('SIGTERM');
});