miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

docs(core): update outdated info in 'contributing.md' (#12038)

Browse Source 
Signed-off-by: Max Kless <maxk@nrwl.io>

Signed-off-by: Max Kless <maxk@nrwl.io>
This commit is contained in:
MaxKless 2022-09-16 15:22:06 +03:00 committed by GitHub
parent e2bfaa68f7
commit aad6d43cb4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
CONTRIBUTING.md
View File

@ -258,9 +258,8 @@ Please follow the following guidelines:
with `npx jest angular/src/utils/ast-utils` or `npx jest packages/angular/src/utils/ast-utils`
- For more options on running tests - check `npx jest --help` or visit [jestjs.io](https://jestjs.io/)
- Debug with `node --inspect-brk ./node_modules/jest/bin/jest.js build/packages/angular/src/utils/ast-utils.spec.js`
- Make sure e2e tests pass (this can take a while, so you can always let CI check those) (`yarn e2e`)
- Target a specific e2e test (i.e. `/build/e2e/cypress.test.js`) with `yarn e2e cypress`
- Debug with `node --inspect-brk ./node_modules/jest/bin/jest.js build/e2e/cypress.test.js`
- Make sure e2e tests pass (this can take a while, so you can always let CI check those) (`nx affected --target=e2e`)
- Target a specific e2e test with `nx e2e e2e-cypress`
- Make sure you run `yarn format`
- Update documentation with `yarn documentation`. For documentation, check for spelling and grammatical errors.
- Update your commit message to follow the guidelines below (use `yarn commit` to automate compliance)
@ -312,6 +311,7 @@ The scope must be one of the following:
- storybook - anything Storybook specific
- testing - anything testing specific (e.g., Jest or Cypress)
- web - anything Web specific
- webpack - anything Webpack specific
- misc - misc stuff
##### Subject and Body