miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(rspack): withModuleFederationForSSR should use commonjs-module as library (#28944)

Browse Source 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
When navigating directly to a route that renders a portion of a remote
app, SSR was not correctly server rendering the remote portion.
This was because of the output type provided to rspack and MFP

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Ensure commonjs-module is set as output type for MF with SSR

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
This commit is contained in:
Colum Ferry 2024-11-14 20:43:19 +00:00 committed by GitHub
parent 36236776cc
commit ae7a84a47c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/rspack/src/utils/module-federation/with-module-federation/with-module-federation-ssr.ts
View File

@ -22,6 +22,9 @@ export async function withModuleFederationForSSR(
return (config, { context }: NxRspackExecutionContext) => { return (config, { context }: NxRspackExecutionContext) => {
config.target = 'async-node'; config.target = 'async-node';
config.output.uniqueName = options.name; config.output.uniqueName = options.name;
config.output.library = {
type: 'commonjs-module',
};
config.optimization = { config.optimization = {
...(config.optimization ?? {}), ...(config.optimization ?? {}),
runtimeChunk: false, runtimeChunk: false,
@ -39,6 +42,10 @@ export async function withModuleFederationForSSR(
...sharedDependencies, ...sharedDependencies,
}, },
isServer: true, isServer: true,
library: {
type: 'commonjs-module',
},
remoteType: 'script',
/** /**
* Apply user-defined config overrides * Apply user-defined config overrides
*/ */