From b4fc65cdf8075e6f743d3d15bf11b0d5fc8c2caa Mon Sep 17 00:00:00 2001
From: Jonathan Cammisuli <jon@cammisuli.ca>
Date: Mon, 27 Apr 2020 10:09:56 -0400
Subject: [PATCH] fix(react): do not include package.json in libs without
 publishable flag (#2896)

---
 e2e/react.test.ts                                     | 3 +++
 packages/react/src/schematics/library/library.spec.ts | 1 +
 packages/react/src/schematics/library/library.ts      | 2 +-
 3 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/e2e/react.test.ts b/e2e/react.test.ts
index 85a7423ed6..961872e10e 100644
--- a/e2e/react.test.ts
+++ b/e2e/react.test.ts
@@ -28,6 +28,9 @@ forEachCli(currentCLIName => {
       );
       runCLI(`generate @nrwl/react:lib ${libName} --no-interactive`);
 
+      // Libs should not include package.json by default
+      checkFilesDoNotExist(`libs/${libName}/package.json`);
+
       const mainPath = `apps/${appName}/src/main.tsx`;
       updateFile(mainPath, `import '@proj/${libName}';\n` + readFile(mainPath));
 
diff --git a/packages/react/src/schematics/library/library.spec.ts b/packages/react/src/schematics/library/library.spec.ts
index 3e70c1b413..77cfed51d7 100644
--- a/packages/react/src/schematics/library/library.spec.ts
+++ b/packages/react/src/schematics/library/library.spec.ts
@@ -92,6 +92,7 @@ describe('lib', () => {
 
     it('should generate files', async () => {
       const tree = await runSchematic('lib', { name: 'myLib' }, appTree);
+      expect(tree.exists('libs/my-lib/package.json')).toBeFalsy();
       expect(tree.exists(`libs/my-lib/jest.config.js`)).toBeTruthy();
       expect(tree.exists('libs/my-lib/src/index.ts')).toBeTruthy();
       expect(tree.exists('libs/my-lib/src/lib/my-lib.tsx')).toBeTruthy();
diff --git a/packages/react/src/schematics/library/library.ts b/packages/react/src/schematics/library/library.ts
index 7b0d2534fe..484726021f 100644
--- a/packages/react/src/schematics/library/library.ts
+++ b/packages/react/src/schematics/library/library.ts
@@ -96,7 +96,7 @@ export default function(schema: Schema): Rule {
             pascalCaseFiles: options.pascalCaseFiles
           })
         : noop(),
-      updateLibPackageNpmScope(options),
+      options.publishable ? updateLibPackageNpmScope(options) : noop(),
       updateAppRoutes(options, context),
       formatFiles(options)
     ])(host, context);