From b97a295fadf30deb24b6e1476d41b75e93868b5f Mon Sep 17 00:00:00 2001 From: Colum Ferry Date: Mon, 3 Jun 2024 14:12:40 +0100 Subject: [PATCH] fix(vite): ensure installed version matches defined peer in package.json (#26324) ## Current Behavior Our `@nx/vite` package has a peer dep on `vite@^5.0.0` but we only install `vite@~5.0.0` creating a conflict in dependencies. ## Expected Behavior The version we install should match the peerDep range we specify in the package.json ## Related Issue(s) Fixes # --- .../vite/src/generators/init/__snapshots__/init.spec.ts.snap | 2 +- packages/vite/src/utils/versions.ts | 2 +- .../src/generators/library/__snapshots__/library.spec.ts.snap | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/vite/src/generators/init/__snapshots__/init.spec.ts.snap b/packages/vite/src/generators/init/__snapshots__/init.spec.ts.snap index cd122bb659..0065aafd35 100644 --- a/packages/vite/src/generators/init/__snapshots__/init.spec.ts.snap +++ b/packages/vite/src/generators/init/__snapshots__/init.spec.ts.snap @@ -10,7 +10,7 @@ exports[`@nx/vite:init dependencies for package.json should add required package "@nx/web": "0.0.1", "@vitest/ui": "^1.3.1", "existing": "1.0.0", - "vite": "~5.0.0", + "vite": "^5.0.0", "vitest": "^1.3.1", }, "name": "@proj/source", diff --git a/packages/vite/src/utils/versions.ts b/packages/vite/src/utils/versions.ts index bc7e61da39..f121493edb 100644 --- a/packages/vite/src/utils/versions.ts +++ b/packages/vite/src/utils/versions.ts @@ -1,5 +1,5 @@ export const nxVersion = require('../../package.json').version; -export const viteVersion = '~5.0.0'; +export const viteVersion = '^5.0.0'; export const vitestVersion = '^1.3.1'; export const vitePluginReactVersion = '^4.2.0'; export const vitePluginReactSwcVersion = '^3.5.0'; diff --git a/packages/vue/src/generators/library/__snapshots__/library.spec.ts.snap b/packages/vue/src/generators/library/__snapshots__/library.spec.ts.snap index d617136f3d..f7d6bd24f6 100644 --- a/packages/vue/src/generators/library/__snapshots__/library.spec.ts.snap +++ b/packages/vue/src/generators/library/__snapshots__/library.spec.ts.snap @@ -197,7 +197,7 @@ exports[`lib should add vue, vite and vitest to package.json 1`] = ` "jsdom": "~22.1.0", "prettier": "^2.6.2", "typescript": "~5.4.2", - "vite": "~5.0.0", + "vite": "^5.0.0", "vitest": "^1.3.1", "vue-tsc": "^1.8.8", },