miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

chore(repo): disable failing remix tests due to yarn errors (#31301)

Browse Source 
This PR disables Remix+Yarn tests. It looks like the tests aren't set up
correctly, and we're using `yarn` even thought he workspace is set up
with pnpm.
This commit is contained in:
Jack Hsu 2025-05-21 12:17:06 -04:00 committed by GitHub
parent 1ab77c8a55
commit c0f2c4bb53
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
e2e/remix/src/nx-remix.test.ts
View File

@ -103,7 +103,8 @@ describe('Remix E2E Tests', () => {
expect(result).toContain(`Successfully ran target test`); expect(result).toContain(`Successfully ran target test`);
}, 120_000); }, 120_000);
it('should generate a library with jest and test correctly', async () => { // TODO(nicholas): This test is failing. It doesn't look like the yarn usage is correct.
xit('should generate a library with jest and test correctly', async () => {
const reactapp = uniq('react'); const reactapp = uniq('react');
runCLI( runCLI(
`generate @nx/react:application ${reactapp} --unitTestRunner=jest --linter=eslint` `generate @nx/react:application ${reactapp} --unitTestRunner=jest --linter=eslint`
@ -121,7 +122,8 @@ describe('Remix E2E Tests', () => {
}, 120_000); }, 120_000);
}); });
describe('error checking', () => { // TODO(nicholas): These test are failing. It doesn't look like the yarn usage is correct.
xdescribe('error checking', () => {
const plugin = uniq('remix'); const plugin = uniq('remix');
beforeAll(async () => { beforeAll(async () => {
@ -148,7 +150,7 @@ describe('Remix E2E Tests', () => {
// This is expecting yarn v1, or else there will be complaints of lockfile errors. // This is expecting yarn v1, or else there will be complaints of lockfile errors.
// TODO(nicholas): The workspace is created with npm, but we're running `yarn nx` which causes lockfile errors in yarn 2/3/4. I think we need to create with yarn instead? // TODO(nicholas): The workspace is created with npm, but we're running `yarn nx` which causes lockfile errors in yarn 2/3/4. I think we need to create with yarn instead?
xit('should pass un-escaped dollar signs in routes with skipChecks flag', async () => { it('should pass un-escaped dollar signs in routes with skipChecks flag', async () => {
await runCommandAsync( await runCommandAsync(
`someWeirdUseCase=route-segment && yarn nx generate @nx/remix:route --path="apps/${plugin}/app/routes/my.route.$someWeirdUseCase.tsx" --force` `someWeirdUseCase=route-segment && yarn nx generate @nx/remix:route --path="apps/${plugin}/app/routes/my.route.$someWeirdUseCase.tsx" --force`
); );
@ -176,7 +178,7 @@ describe('Remix E2E Tests', () => {
).not.toThrow(); ).not.toThrow();
}, 120000); }, 120000);
xit('should pass un-escaped dollar signs in resource routes with skipChecks flag', async () => { it('should pass un-escaped dollar signs in resource routes with skipChecks flag', async () => {
await runCommandAsync( await runCommandAsync(
`someWeirdUseCase=route-segment && yarn nx generate @nx/remix:resource-route --path="apps/${plugin}/app/routes/my.route.$someWeirdUseCase.ts" --force` `someWeirdUseCase=route-segment && yarn nx generate @nx/remix:resource-route --path="apps/${plugin}/app/routes/my.route.$someWeirdUseCase.ts" --force`
); );