miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(linter): restore rules to match previous @typescript-eslint/recommended (#21424)

Browse Source
This commit is contained in:
James Henry 2024-01-30 20:56:56 +04:00 committed by GitHub
parent bfb0520930
commit c286a6e799
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 37 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
packages/eslint-plugin/src/configs/javascript.ts
View File

@ -18,9 +18,6 @@ const isPrettierAvailable =
* it should yield a performance improvement but could introduce subtle
* breaking changes - we should also look to replace all the @typescript-eslint
* related plugins and rules below.
*
* TODO: Reevaluate stylistic plugin and added specific rules in the next major
* version of Nx. Related to https://github.com/nrwl/nx/pull/21066
*/
export default {
env: {
@ -37,33 +34,12 @@ export default {
'eslint:recommended',
'plugin:@typescript-eslint/eslint-recommended',
'plugin:@typescript-eslint/recommended',
/**
* This was added to preserve the linting rules that were previously
* defined v5 of @typescript-eslint. v6 of @typescript-eslint changed
* how configurations are defined. This should be reevaluated in the
* next major version of Nx.
*/
'plugin:@typescript-eslint/stylistic',
...(isPrettierAvailable ? ['prettier'] : []),
],
rules: {
'@typescript-eslint/explicit-member-accessibility': 'off',
'@typescript-eslint/explicit-module-boundary-types': 'off',
'@typescript-eslint/explicit-function-return-type': 'off',
/**
* These 3 rules:
* `no-extra-semi`
* `@typescript-eslint/no-extra-semi`
* `@typescript-eslint/no-non-null-assertion`
* were added to preserve the linting rules that were
* previously defined v5 of `@typescript-eslint`. v6 of `@typescript-eslint`
* changed how configurations are defined. This should be reevaluated in
* the next major version of Nx.
*/
'no-extra-semi': 'off',
'@typescript-eslint/no-extra-semi': 'error',
'@typescript-eslint/no-non-null-assertion': 'warn',
'@typescript-eslint/no-parameter-properties': 'off',
/**
* Until ESM usage in Node matures, using require in e.g. JS config files
@ -71,5 +47,26 @@ export default {
* having to frequently use "eslint-disable-next-line" in their configs.
*/
'@typescript-eslint/no-var-requires': 'off',
/**
* From https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/#updated-configuration-rules
*
* The following rules were added to preserve the linting rules that were
* previously defined v5 of `@typescript-eslint`. v6 of `@typescript-eslint`
* changed how configurations are defined.
*
* TODO(v19): re-evalute these deviations from @typescript-eslint/recommended in v19 of Nx
*/
'no-extra-semi': 'off',
'@typescript-eslint/no-extra-semi': 'error',
'@typescript-eslint/no-non-null-assertion': 'warn',
'@typescript-eslint/adjacent-overload-signatures': 'error',
'@typescript-eslint/prefer-namespace-keyword': 'error',
'no-empty-function': 'off',
'@typescript-eslint/no-empty-function': 'error',
'@typescript-eslint/no-inferrable-types': 'error',
'@typescript-eslint/no-unused-vars': 'warn',
'@typescript-eslint/no-empty-interface': 'error',
'@typescript-eslint/no-explicit-any': 'warn',
},
};

34
packages/eslint-plugin/src/configs/typescript.ts
View File

@ -10,9 +10,6 @@ const isPrettierAvailable =
*
* It should therefore NOT contain any rules or plugins which are specific
* to one ecosystem, such as React, Angular, Node etc.
*
* TODO: Reevaluate stylistic plugin and added specific rules in the next major
* version of Nx. Related to https://github.com/nrwl/nx/pull/21066
*/
export default {
parser: '@typescript-eslint/parser',
@ -26,32 +23,33 @@ export default {
'eslint:recommended',
'plugin:@typescript-eslint/eslint-recommended',
'plugin:@typescript-eslint/recommended',
/**
* This was added to preserve the linting rules that were previously
* defined v5 of @typescript-eslint. v6 of @typescript-eslint changed
* how configurations are defined. This should be reevaluated in the
* next major version of Nx.
*/
'plugin:@typescript-eslint/stylistic',
...(isPrettierAvailable ? ['prettier'] : []),
],
rules: {
'@typescript-eslint/explicit-member-accessibility': 'off',
'@typescript-eslint/explicit-module-boundary-types': 'off',
'@typescript-eslint/explicit-function-return-type': 'off',
'@typescript-eslint/no-parameter-properties': 'off',
/**
* These 3 rules:
* `no-extra-semi`
* `@typescript-eslint/no-extra-semi`
* `@typescript-eslint/no-non-null-assertion`
* were added to preserve the linting rules that were
* From https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/#updated-configuration-rules
*
* The following rules were added to preserve the linting rules that were
* previously defined v5 of `@typescript-eslint`. v6 of `@typescript-eslint`
* changed how configurations are defined. This should be reevaluated in
* the next major version of Nx.
* changed how configurations are defined.
*
* TODO(v19): re-evalute these deviations from @typescript-eslint/recommended in v19 of Nx
*/
'no-extra-semi': 'off',
'@typescript-eslint/no-extra-semi': 'error',
'@typescript-eslint/no-non-null-assertion': 'warn',
'@typescript-eslint/no-parameter-properties': 'off',
'@typescript-eslint/adjacent-overload-signatures': 'error',
'@typescript-eslint/prefer-namespace-keyword': 'error',
'no-empty-function': 'off',
'@typescript-eslint/no-empty-function': 'error',
'@typescript-eslint/no-inferrable-types': 'error',
'@typescript-eslint/no-unused-vars': 'warn',
'@typescript-eslint/no-empty-interface': 'error',
'@typescript-eslint/no-explicit-any': 'warn',
},
};