miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

chore(repo): ensure playwright is installed before running e2e tests (#29006)

Browse Source 
We're using Playwright by default, but the e2e test is ensuring Cypress
installation.

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
This commit is contained in:
Jack Hsu 2024-11-20 09:48:01 -05:00 committed by GitHub
parent a0d760f790
commit ce6caba1f9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.nx/workflows/agents.yaml
View File

@ -38,7 +38,7 @@ launch-templates:
- name: Install Browsers - name: Install Browsers
script: | script: |
pnpm exec cypress install pnpm exec cypress install
pnpm exec playwright install pnpm exec playwright install --with-deps
- name: Install Rust - name: Install Rust
script: | script: |
@ -95,7 +95,7 @@ launch-templates:
- name: Install Browsers - name: Install Browsers
script: | script: |
pnpm exec cypress install pnpm exec cypress install
pnpm exec playwright install pnpm exec playwright install --with-deps
- name: Install Rust - name: Install Rust
script: | script: |

2
e2e/next/src/next.test.ts
View File

@ -184,7 +184,7 @@ describe('Next.js Applications', () => {
runCLI(`generate @nx/next:app ${appName} --no-interactive --style=css`); runCLI(`generate @nx/next:app ${appName} --no-interactive --style=css`);
if (runE2ETests('cypress')) { if (runE2ETests('playwright')) {
const e2eResults = runCLI(`e2e-ci ${appName}-e2e --verbose`, { const e2eResults = runCLI(`e2e-ci ${appName}-e2e --verbose`, {
verbose: true, verbose: true,
env: { env: {