miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(graph): encode id in project node tooltip (#14530)

Browse Source
This commit is contained in:
Anton Fedorov 2023-01-23 19:53:30 +03:00 committed by GitHub
parent e7f065e6b3
commit d43d6b6de9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
graph/client/src/app/ui-tooltips/project-node-actions.tsx
View File

@ -11,6 +11,7 @@ export function ProjectNodeActions({ id }: ProjectNodeToolTipProps) {
projectGraphService.getSnapshot().context.tracing; projectGraphService.getSnapshot().context.tracing;
const routeConstructor = useRouteConstructor(); const routeConstructor = useRouteConstructor();
const navigate = useNavigate(); const navigate = useNavigate();
const encodedId = encodeURIComponent(id);
function onExclude() { function onExclude() {
projectGraphService.send({ projectGraphService.send({
@ -21,17 +22,13 @@ export function ProjectNodeActions({ id }: ProjectNodeToolTipProps) {
} }
function onStartTrace() { function onStartTrace() {
navigate( navigate(routeConstructor(`/projects/trace/${encodedId}`, true));
routeConstructor(`/projects/trace/${encodeURIComponent(id)}`, true)
);
} }
function onEndTrace() { function onEndTrace() {
navigate( navigate(
routeConstructor( routeConstructor(
`/projects/trace/${encodeURIComponent(start)}/${encodeURIComponent( `/projects/trace/${encodeURIComponent(start)}/${encodedId}`,
id
)}`,
true true
) )
); );
@ -39,7 +36,7 @@ export function ProjectNodeActions({ id }: ProjectNodeToolTipProps) {
return ( return (
<div className="grid grid-cols-3 gap-4"> <div className="grid grid-cols-3 gap-4">
<TooltipLinkButton to={routeConstructor(`/projects/${id}`, true)}> <TooltipLinkButton to={routeConstructor(`/projects/${encodedId}`, true)}>
Focus Focus
</TooltipLinkButton> </TooltipLinkButton>
<TooltipButton onClick={onExclude}>Exclude</TooltipButton> <TooltipButton onClick={onExclude}>Exclude</TooltipButton>