miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(core): daemon spinner should show text (#29448)

Browse Source 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
Daemon spinner doesn't show up

## Expected Behavior
Daemon spinner shows properly

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
This commit is contained in:
Craigory Coppola 2024-12-20 14:10:15 -05:00 committed by GitHub
parent 81c66eca73
commit d7ffba8f76
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/nx/src/utils/delayed-spinner.ts
View File

@ -31,12 +31,12 @@ export class DelayedSpinner {
this.timeouts.push( this.timeouts.push(
setTimeout(() => { setTimeout(() => {
this.ready = true; this.ready = true;
this.lastMessage = message;
if (!SHOULD_SHOW_SPINNERS) { if (!SHOULD_SHOW_SPINNERS) {
console.warn(this.lastMessage); console.warn(this.lastMessage);
} else { } else {
this.spinner = ora(this.lastMessage).start(); this.spinner = ora(this.lastMessage).start();
} }
this.lastMessage = message;
}, delay).unref() }, delay).unref()
); );
} }