miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(core): create nodes plugin fixes (#20134)

Browse Source
This commit is contained in:
Katerina Skroumpelou 2023-11-09 11:49:20 +02:00 committed by GitHub
parent b4faf2dd3b
commit dc51a90745
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/devkit/src/utils/replace-project-configuration-with-plugin.ts
View File

@ -54,7 +54,7 @@ export function replaceProjectConfigurationsWithPlugin<T = unknown>(
for (const [targetName, targetConfig] of Object.entries(node.targets)) { for (const [targetName, targetConfig] of Object.entries(node.targets)) {
const targetFromProjectConfig = projectConfig.targets[targetName]; const targetFromProjectConfig = projectConfig.targets[targetName];
if (targetFromProjectConfig.executor !== targetConfig.executor) { if (targetFromProjectConfig?.executor !== targetConfig.executor) {
continue; continue;
} }

2
tools/workspace-plugin/src/generators/create-nodes-plugin/__snapshots__/generator.spec.ts.snap
View File

@ -79,7 +79,7 @@ export const createNodes: CreateNodes<EslintPluginOptions> = [
const projectRoot = dirname(configFilePath); const projectRoot = dirname(configFilePath);
// Do not create a project if package.json and project.json isn't there. // Do not create a project if package.json and project.json isn't there.
const siblingFiles = readdirSync(projectRoot); const siblingFiles = readdirSync(join(context.workspaceRoot, projectRoot));
if ( if (
!siblingFiles.includes('package.json') && !siblingFiles.includes('package.json') &&
!siblingFiles.includes('project.json') !siblingFiles.includes('project.json')

2
tools/workspace-plugin/src/generators/create-nodes-plugin/files/src/plugins/plugin.ts.template
View File

@ -22,7 +22,7 @@ export const createNodes: CreateNodes<<%= className %>PluginOptions> = [
const projectRoot = dirname(configFilePath); const projectRoot = dirname(configFilePath);
// Do not create a project if package.json and project.json isn't there. // Do not create a project if package.json and project.json isn't there.
const siblingFiles = readdirSync(projectRoot); const siblingFiles = readdirSync(join(context.workspaceRoot, projectRoot));
if ( if (
!siblingFiles.includes('package.json') && !siblingFiles.includes('package.json') &&
!siblingFiles.includes('project.json') !siblingFiles.includes('project.json')