miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(core): improve tui task_list bottom section responsive design (#30993)

Browse Source
This commit is contained in:
James Henry 2025-05-02 17:30:54 +04:00 committed by GitHub
parent 87a00da7e5
commit ed3788fd2b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
33 changed files with 950 additions and 312 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/nx/src/native/tui/components/help_text.rs
View File

@ -92,7 +92,7 @@ impl HelpText {
];
f.render_widget(
Paragraph::new(Line::from(shortcuts)).alignment(Alignment::Center),
Paragraph::new(Line::from(shortcuts)).alignment(Alignment::Right),
safe_area,
);
}

2
packages/nx/src/native/tui/components/snapshots/nx__native__tui__components__tasks_list__tests__cloud_message_rendering.snap
View File

@ -16,4 +16,4 @@ expression: terminal.backend()
" "
" "
" "
" ← 1/1 → quit: q help: ? View results at https://nx.app/runs/123"
" ← 1/1 → View logs and run details at https://nx.app/runs/KnGk4A47qk quit: q help: ?"

19
packages/nx/src/native/tui/components/snapshots/nx__native__tui__components__tasks_list__tests__cloud_message_two_line_layout.snap Normal file
View File

@ -0,0 +1,19 @@
---
source: packages/nx/src/native/tui/components/tasks_list.rs
expression: terminal.backend()
---
" "
" NX Completed Test Tasks Duration"
" "
" ✔ task1 ..."
"> ✔ task2 ..."
" ✔ task3 ..."
" "
" "
" "
" "
" "
" "
" https://nx.app/runs/KnGk4A47qk "
" "
" ← 1/1 → quit: q help: ?"

19
packages/nx/src/native/tui/components/snapshots/nx__native__tui__components__tasks_list__tests__cloud_message_without_url.snap Normal file
View File

@ -0,0 +1,19 @@
---
source: packages/nx/src/native/tui/components/tasks_list.rs
expression: terminal.backend()
---
" "
" NX Running Test Tasks... Cache Duration"
" "
" "
"> · task1 ... ..."
" · task2 ... ..."
" · task3 ... ..."
" "
" "
" "
" "
" "
" "
" "
" ← 1/1 → This is some warning from Nx Cloud quit: q help: ?"

19
packages/nx/src/native/tui/components/snapshots/nx__native__tui__components__tasks_list__tests__cloud_message_without_url_super_wide.snap Normal file
View File

@ -0,0 +1,19 @@
---
source: packages/nx/src/native/tui/components/tasks_list.rs
expression: terminal.backend()
---
" "
" NX Running Test Tasks... Cache Duration"
" "
" "
"> · task1 ... ..."
" · task2 ... ..."
" · task3 ... ..."
" "
" "
" "
" "
" "
" "
" "
" ← 1/1 → This is some warning from Nx Cloud quit: q help: ? navigate: ↑ ↓ filter: / pin output: 1 or 2 show output: <enter>"

4
packages/nx/src/native/tui/components/snapshots/nx__native__tui__components__tasks_list__tests__medium_width_rendering.snap
View File

@ -15,5 +15,5 @@ expression: terminal.backend()
" "
" "
" "
" ← 1/1 → "
" quit: q help: ? "
" "
" ← 1/1 → quit: q help: ?"

4
packages/nx/src/native/tui/components/snapshots/nx__native__tui__components__tasks_list__tests__narrow_width_rendering.snap
View File

@ -15,5 +15,5 @@ expression: terminal.backend()
" "
" "
" "
" ← 1/1 → "
" quit: q help: ? "
" "
" ← 1/1 → quit: q help: ?"

10
packages/nx/src/native/tui/components/snapshots/nx__native__tui__components__tasks_list__tests__pagination_many_pages_narrow.snap Normal file
View File

@ -0,0 +1,10 @@
---
source: packages/nx/src/native/tui/components/tasks_list.rs
expression: terminal.backend()
---
" "
" NX Running Many Page Duration"
" "
"> · task52 ..."
" "
" ← 50/101 → quit: q help: ?"

10
packages/nx/src/native/tui/components/snapshots/nx__native__tui__components__tasks_list__tests__pagination_many_pages_narrow_with_cloud_message.snap Normal file
View File

@ -0,0 +1,10 @@
---
source: packages/nx/src/native/tui/components/tasks_list.rs
expression: terminal.backend()
---
" "
" NX Running Many Page Duration"
" "
" The remote cache will not be read f..."
" "
" ← 50/101 → quit: q help: ?"

10
packages/nx/src/native/tui/components/snapshots/nx__native__tui__components__tasks_list__tests__pagination_many_pages_wide.snap Normal file
View File

@ -0,0 +1,10 @@
---
source: packages/nx/src/native/tui/components/tasks_list.rs
expression: terminal.backend()
---
" "
" NX Running Many Pages Test... Cache Duration"
" "
"> · task52 ... ..."
" "
" ← 50/101 → quit: q help: ? navigate: ↑ ↓ filter: / pin output: 1 or 2 show output: <enter>"

10
packages/nx/src/native/tui/components/snapshots/nx__native__tui__components__tasks_list__tests__pagination_many_pages_wide_with_cloud_message.snap Normal file
View File

@ -0,0 +1,10 @@
---
source: packages/nx/src/native/tui/components/tasks_list.rs
expression: terminal.backend()
---
" "
" NX Running Many Pages Test... Cache Duration"
" "
"> · task52 ... ..."
" "
" ← 50/101 → The remote cache will not be read from or written to during this run. quit: q help: ?"

2
packages/nx/src/native/tui/components/snapshots/nx__native__tui__components__tasks_list__tests__short_height_rendering.snap
View File

@ -11,4 +11,4 @@ expression: terminal.backend()
"> · task2 ... ..."
" · task3 ... ..."
" "
" ← 1/1 → quit: q help: ? "
" ← 1/1 → quit: q help: ? navigate: ↑ ↓ filter: / pin output: 1 or 2 show output: <enter>"

19
packages/nx/src/native/tui/components/snapshots/nx__native__tui__components__tasks_list__tests__very_narrow_pag_help_handling.snap Normal file
View File

@ -0,0 +1,19 @@
---
source: packages/nx/src/native/tui/components/tasks_list.rs
expression: terminal.backend()
---
" "
" NX Ru Duration"
" "
" ⠋ ta ..."
" "
"> · ta ..."
" · ta ..."
" "
" "
" "
" "
" "
" "
" "
" ← 1/1 → "

19
packages/nx/src/native/tui/components/snapshots/nx__native__tui__components__tasks_list__tests__very_narrow_pag_help_handling_with_cloud_message.snap Normal file
View File

@ -0,0 +1,19 @@
---
source: packages/nx/src/native/tui/components/tasks_list.rs
expression: terminal.backend()
---
" "
" NX Ru Duration"
" "
" ⠋ ta ..."
" "
"> · ta ..."
" · ta ..."
" "
" "
" "
" "
" "
" The remote cache wil..."
" "
" ← 1/1 → "

2
packages/nx/src/native/tui/components/snapshots/nx__native__tui__components__tasks_list__tests__very_narrow_width_rendering.snap
View File

@ -15,5 +15,5 @@ expression: terminal.backend()
" "
" "
" "
" "
" ← 1/1 → "
" quit: q help: ? "

14
packages/nx/src/native/tui/components/snapshots/nx__native__tui__components__tasks_list__tests__wide_and_short_rendering.snap Normal file
View File

@ -0,0 +1,14 @@
---
source: packages/nx/src/native/tui/components/tasks_list.rs
expression: terminal.backend()
---
" "
" NX Running Test Tasks... Cache Duration"
" "
" ⠋ task1 ... ..."
" "
"> · task2 ... ..."
" · task3 ... ..."
" "
" "
" ← 1/1 → quit: q help: ? navigate: ↑ ↓ filter: / pin output: 1 or 2 show output: <enter>"

1030
packages/nx/src/native/tui/components/tasks_list.rs
View File

File diff suppressed because it is too large Load Diff

1
packages/nx/src/native/tui/lifecycle.rs
View File

@ -1,4 +1,3 @@
use hashbrown::HashSet;
use napi::bindgen_prelude::*;
use napi::threadsafe_function::{ErrorStrategy, ThreadsafeFunction};
use napi::JsObject;