miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(core): do not mutate target defaults (#26941)

Browse Source 
## Current Behavior
<!-- This is the behavior we have today -->

Target defaults is mutated when the target is normalized. Subsequent
targets are normalized with the mutated version yielding the incorrect
projects configuration.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Target defaults is not mutated and all targets are correct.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
This commit is contained in:
Jason Jean 2024-07-15 11:12:36 -05:00 committed by GitHub
parent 33d2bece53
commit f3fa705b82
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 42 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
packages/nx/src/project-graph/utils/project-configuration-utils.spec.ts
View File

@ -1524,6 +1524,41 @@ describe('project-configuration-utils', () => {
}
`);
});
it('should not mutate the target', () => {
const config = {
name: 'project',
root: 'libs/project',
targets: {
foo: {
executor: 'nx:noop',
options: {
config: '{projectRoot}/config.json',
},
configurations: {
prod: {
config: '{projectRoot}/config.json',
},
},
},
bar: {
command: 'echo {projectRoot}',
options: {
config: '{projectRoot}/config.json',
},
configurations: {
prod: {
config: '{projectRoot}/config.json',
},
},
},
},
};
const originalConfig = JSON.stringify(config, null, 2);
normalizeTarget(config.targets.foo, config);
normalizeTarget(config.targets.bar, config);
expect(JSON.stringify(config, null, 2)).toEqual(originalConfig);
});
});
describe('createProjectConfigurations', () => {

8
packages/nx/src/project-graph/utils/project-configuration-utils.ts
View File

@ -1105,6 +1105,13 @@ export function normalizeTarget(
target: TargetConfiguration,
project: ProjectConfiguration
) {
target = {
...target,
configurations: {
...target.configurations,
},
};
target = resolveCommandSyntacticSugar(target, project.root);
target.options = resolveNxTokensInOptions(
@ -1113,7 +1120,6 @@ export function normalizeTarget(
`${project.root}:${target}`
);
target.configurations ??= {};
for (const configuration in target.configurations) {
target.configurations[configuration] = resolveNxTokensInOptions(
target.configurations[configuration],