From f9d461e663c6e174e493f2aad50effc2e18b03a1 Mon Sep 17 00:00:00 2001
From: Nicholas Cunningham <ndcunningham@gmail.com>
Date: Thu, 1 May 2025 16:47:35 -0600
Subject: [PATCH] feat(react-native): update executor and schema files for expo
 and react-native to be continuous (#30985)

WIP

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
---
 docs/generated/packages/expo/executors/run.json              | 1 +
 docs/generated/packages/expo/executors/serve.json            | 1 +
 docs/generated/packages/expo/executors/start.json            | 1 +
 .../packages/react-native/executors/run-android.json         | 1 +
 docs/generated/packages/react-native/executors/run-ios.json  | 1 +
 docs/generated/packages/react-native/executors/start.json    | 1 +
 e2e/utils/global-setup.ts                                    | 5 +++--
 nx.json                                                      | 5 ++++-
 packages/expo/src/executors/run/schema.json                  | 1 +
 packages/expo/src/executors/serve/schema.json                | 1 +
 packages/expo/src/executors/start/schema.json                | 1 +
 packages/react-native/src/executors/run-android/schema.json  | 1 +
 packages/react-native/src/executors/run-ios/schema.json      | 1 +
 packages/react-native/src/executors/start/schema.json        | 1 +
 14 files changed, 19 insertions(+), 3 deletions(-)

diff --git a/docs/generated/packages/expo/executors/run.json b/docs/generated/packages/expo/executors/run.json
index 64e9dd7442..87553b772f 100644
--- a/docs/generated/packages/expo/executors/run.json
+++ b/docs/generated/packages/expo/executors/run.json
@@ -3,6 +3,7 @@
   "implementation": "/packages/expo/src/executors/run/run.impl.ts",
   "schema": {
     "version": 2,
+    "continuous": true,
     "outputCapture": "direct-nodejs",
     "cli": "nx",
     "$id": "NxExpoRun",
diff --git a/docs/generated/packages/expo/executors/serve.json b/docs/generated/packages/expo/executors/serve.json
index 87d39cc148..9c38885c55 100644
--- a/docs/generated/packages/expo/executors/serve.json
+++ b/docs/generated/packages/expo/executors/serve.json
@@ -3,6 +3,7 @@
   "implementation": "/packages/expo/src/executors/serve/serve.impl.ts",
   "schema": {
     "version": 2,
+    "continuous": true,
     "outputCapture": "direct-nodejs",
     "cli": "nx",
     "$id": "NxExpoServe",
diff --git a/docs/generated/packages/expo/executors/start.json b/docs/generated/packages/expo/executors/start.json
index 693bd4f1f3..47f7b69b16 100644
--- a/docs/generated/packages/expo/executors/start.json
+++ b/docs/generated/packages/expo/executors/start.json
@@ -3,6 +3,7 @@
   "implementation": "/packages/expo/src/executors/start/start.impl.ts",
   "schema": {
     "version": 2,
+    "continuous": true,
     "outputCapture": "direct-nodejs",
     "cli": "nx",
     "$id": "NxExpoStart",
diff --git a/docs/generated/packages/react-native/executors/run-android.json b/docs/generated/packages/react-native/executors/run-android.json
index dff691543f..28931ba051 100644
--- a/docs/generated/packages/react-native/executors/run-android.json
+++ b/docs/generated/packages/react-native/executors/run-android.json
@@ -3,6 +3,7 @@
   "implementation": "/packages/react-native/src/executors/run-android/run-android.impl.ts",
   "schema": {
     "version": 2,
+    "continuous": true,
     "outputCapture": "direct-nodejs",
     "cli": "nx",
     "$id": "NxReactNativeRunAndroid",
diff --git a/docs/generated/packages/react-native/executors/run-ios.json b/docs/generated/packages/react-native/executors/run-ios.json
index 9028c9954a..6dd5c42f3a 100644
--- a/docs/generated/packages/react-native/executors/run-ios.json
+++ b/docs/generated/packages/react-native/executors/run-ios.json
@@ -3,6 +3,7 @@
   "implementation": "/packages/react-native/src/executors/run-ios/run-ios.impl.ts",
   "schema": {
     "version": 2,
+    "continuous": true,
     "outputCapture": "direct-nodejs",
     "cli": "nx",
     "$id": "NxReactNativeRunIos",
diff --git a/docs/generated/packages/react-native/executors/start.json b/docs/generated/packages/react-native/executors/start.json
index aa6acdbd0b..4886f289ad 100644
--- a/docs/generated/packages/react-native/executors/start.json
+++ b/docs/generated/packages/react-native/executors/start.json
@@ -3,6 +3,7 @@
   "implementation": "/packages/react-native/src/executors/start/start.impl.ts",
   "schema": {
     "version": 2,
+    "continuous": true,
     "outputCapture": "direct-nodejs",
     "cli": "nx",
     "$id": "NxReactNativeStart",
diff --git a/e2e/utils/global-setup.ts b/e2e/utils/global-setup.ts
index 39aa17f136..a212a42ac4 100644
--- a/e2e/utils/global-setup.ts
+++ b/e2e/utils/global-setup.ts
@@ -12,11 +12,12 @@ export default async function (globalConfig: Config.ConfigGlobals) {
       process.env.NX_VERBOSE_LOGGING === 'true' || !!globalConfig.verbose;
 
     /**
-     * For e2e-ci we populate the verdaccio storage up front, but for other workflows we need
+     * For e2e-ci & macos-local-e2e we populate the verdaccio storage up front, but for other workflows we need
      * to run the full local release process before running tests.
      */
     const requiresLocalRelease =
-      !process.env.NX_TASK_TARGET_TARGET?.startsWith('e2e-ci');
+      !process.env.NX_TASK_TARGET_TARGET?.startsWith('e2e-ci') &&
+      !process.env.NX_TASK_TARGET_TARGET?.startsWith('e2e-macos-local');
 
     const listenAddress = 'localhost';
     const port = process.env.NX_LOCAL_REGISTRY_PORT ?? '4873';
diff --git a/nx.json b/nx.json
index cb64ef9b4d..539c159690 100644
--- a/nx.json
+++ b/nx.json
@@ -136,7 +136,10 @@
     "e2e-macos-local": {
       "cache": true,
       "inputs": ["e2eInputs", "^production"],
-      "parallelism": false
+      "dependsOn": [
+        "@nx/nx-source:populate-local-registry-storage",
+        "@nx/nx-source:local-registry"
+      ]
     },
     "e2e-macos-ci": {
       "inputs": ["e2eInputs", "^production"]
diff --git a/packages/expo/src/executors/run/schema.json b/packages/expo/src/executors/run/schema.json
index 96f0385776..f66db137cb 100644
--- a/packages/expo/src/executors/run/schema.json
+++ b/packages/expo/src/executors/run/schema.json
@@ -1,5 +1,6 @@
 {
   "version": 2,
+  "continuous": true,
   "outputCapture": "direct-nodejs",
   "cli": "nx",
   "$id": "NxExpoRun",
diff --git a/packages/expo/src/executors/serve/schema.json b/packages/expo/src/executors/serve/schema.json
index 9bb416beec..50ed2d7e22 100644
--- a/packages/expo/src/executors/serve/schema.json
+++ b/packages/expo/src/executors/serve/schema.json
@@ -1,5 +1,6 @@
 {
   "version": 2,
+  "continuous": true,
   "outputCapture": "direct-nodejs",
   "cli": "nx",
   "$id": "NxExpoServe",
diff --git a/packages/expo/src/executors/start/schema.json b/packages/expo/src/executors/start/schema.json
index 29f4fb3ced..9f80320e00 100644
--- a/packages/expo/src/executors/start/schema.json
+++ b/packages/expo/src/executors/start/schema.json
@@ -1,5 +1,6 @@
 {
   "version": 2,
+  "continuous": true,
   "outputCapture": "direct-nodejs",
   "cli": "nx",
   "$id": "NxExpoStart",
diff --git a/packages/react-native/src/executors/run-android/schema.json b/packages/react-native/src/executors/run-android/schema.json
index 8a9a1a3c5c..90653df9d7 100644
--- a/packages/react-native/src/executors/run-android/schema.json
+++ b/packages/react-native/src/executors/run-android/schema.json
@@ -1,5 +1,6 @@
 {
   "version": 2,
+  "continuous": true,
   "outputCapture": "direct-nodejs",
   "cli": "nx",
   "$id": "NxReactNativeRunAndroid",
diff --git a/packages/react-native/src/executors/run-ios/schema.json b/packages/react-native/src/executors/run-ios/schema.json
index 50f9b38548..fd902fb4f2 100644
--- a/packages/react-native/src/executors/run-ios/schema.json
+++ b/packages/react-native/src/executors/run-ios/schema.json
@@ -1,5 +1,6 @@
 {
   "version": 2,
+  "continuous": true,
   "outputCapture": "direct-nodejs",
   "cli": "nx",
   "$id": "NxReactNativeRunIos",
diff --git a/packages/react-native/src/executors/start/schema.json b/packages/react-native/src/executors/start/schema.json
index e05587d85b..2544e4e4f9 100644
--- a/packages/react-native/src/executors/start/schema.json
+++ b/packages/react-native/src/executors/start/schema.json
@@ -1,5 +1,6 @@
 {
   "version": 2,
+  "continuous": true,
   "outputCapture": "direct-nodejs",
   "cli": "nx",
   "$id": "NxReactNativeStart",