This commit checks if the target dev server supports the watch option before forwarding it to, this is relevant for running Cypress against dev server target that does not support this option, for instance "@nguniversal/builders:ssr-dev-server".
* feat(angular): upgrade Angular to v12.0.0-rc.3
* feat(angular): target Nx v12.4.0-beta.0 for Angular v12.0.0-rc.0 upgrade
* fix(angular): use defaultConfiguration if no other configuration is passed
* cleanup(angular): sync migration folder name to target version
* fix(repo): creating custom schema flattener for docs
* chore(repo): amend yarn.lock
* feat(angular): update angular storybook to use webpack 5
* fix(angular): add legacy peer deps for angular+jest
* fix(angular): move migrations to 12.3.0-rc.0
Co-authored-by: Zack DeRose <zack.derose@gmail.com>
Co-authored-by: Jason Jean <jasonjean1993@gmail.com>
* feat(core): add --discardExistingLintConfig option to lint conversion generators
* fixup! feat(core): add --discardExistingLintConfig option to lint conversion generators
* chore(core): address PR feedback
* fix(linter): properly store defualts for converting tslint to eslint
* fix(linter): fix tests for set defaults
Co-authored-by: Jason Jean <jasonjean1993@gmail.com>
- Single char alternation (e.g. a|b|c|d) in a RegExp can be simplified to use a character class ([abcd]) instead.
This usually also provides slightly better matching performance.
- Character escapes that are replaceable with the unescaped character without a change in meaning. Inside the square brackets of a character class, many escapes are unnecessary that would be necessary outside of a character class. For example the regex [\.] is identical to [.]
- If several qualified expressions occur after the qualifier having been checked for nullable, they can be replaced with optional chaining
* feat(linter): convert-tslint-to-eslint generators
* fix(core): remove generators in collection for ng and nest
* fix(core): update tao to support mixed generators and schematics
* fix(core): update tao to support mixed generators and schematics
* fix(core): address some PR feedback
* fix(core): fix snapshots after syncing up with master
* feat(core): store user preference for removeTSLintIfNoMoreTSLintTargets
* fix(linter): unit tests
* feat(core): apply root tslint.json conversion to root .eslintrc.json
The builder currently supports skipping the serve step by passing an empty value
for
devServerTarget. This is not intuitive and makes configuring this via the command line messy.
This
flag has the same behavior as passing an empty devServerTarget but is more user-friendly.
This
option can be useful for CI purposes where applications are previously built and want to use
the
same configuration for e2e testing but the serve step is unnecessary.
ISSUES CLOSED: #3744
* chore(core): increase coverage of eslint config file contents
* fix(core): always use project level tsconfigs with eslint
* chore(core): enhance depcheck to ignore type only imports
* chore(linter): migration always-use-project-level-tsconfigs-with-eslint
* fix(core): snapshots
* feat(core): thin wrapper around tseslint parser
* fix(core): depcheck for eslint-plugin-nx
* fix(core): revert wrapped parser
* fix(linter): add tsconfig root dir to allow for normalized paths for project configs
* fix(linter): move migration to 11.5.0
* fix(linter): add dependency on to @nrwl/workspace
Co-authored-by: Jason Jean <jasonjean1993@gmail.com>
* feat(linter): add explicit file extension to config files
* feat(linter): update references to .eslintrc for new projects
* fix(linter): fix quotes in global eslint config
When Cypress was invoked using `ng`, it was throwing errors because no additional properties were allowed.
When allowed, all the extra options are passed as array in the `--` key, which is not currently handled.
This commit allows additional properties and makes sure that if any adittional options are passed they are parsed and incorporated correctly.
ISSUES CLOSED: #3571
* fix(core): resolve webpack loaders with `require.resolve()`
With strict package managers such as pnpm or Yarn PnP, transitive
dependencies are *not* hoisted to the root node_modules folder. This
means that a webpack config defined within a package like
'@nrwl/cypress' cannot resolve loaders like 'ts-loader', unless
'ts-loader' is declared in the workspace's own package.json.
This is a problem because the workspace might define a different version
of 'ts-loader', incompatible with the version declared by
'@nrwl/cypress/package.json'. The workspace should not need to declare
a dependency on 'ts-loader' anyway.
See also:
* https://github.com/pnpm/pnpm/issues/801
* https://github.com/webpack/webpack/issues/5087
* fix(core): resolve absolute 'raw-loader' path
When replacing the 'raw-loader' rule in the `getStylesPartial` function,
check for the absolute path of 'raw-loader' rather than just the name.
With strict package managers such as pnpm or Yarn PnP, transitive
dependencies are *not* hoisted to the root node_modules folder. This
means that a webpack config defined within a package like
'@nrwl/cypress' cannot resolve loaders like 'ts-loader', unless
'ts-loader' is declared in the workspace's own package.json.
This is a problem because the workspace might define a different version
of 'ts-loader', incompatible with the version declared by
'@nrwl/cypress/package.json'. The workspace should not need to declare
a dependency on 'ts-loader' anyway.
See also:
* https://github.com/pnpm/pnpm/issues/801
* https://github.com/webpack/webpack/issues/5087
