13462 Commits

Author SHA1 Message Date
Colum Ferry
e06b787e63
feat(react): support react 18.3.1 (#23166)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
We currently generate react projects with version 18.2.0


## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
We generate react projects with version 18.3.1
We migrate existing users to version 18.3.1

This will prepare for the breaking changes coming in React 19


## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-05-03 10:26:45 -04:00
Jason Jean
2cb62c6177
chore(repo): update nx to 19.0.0-beta.11 (#23133)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

This repo is using Nx `19.0.0-beta.8`

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

This repo is using Nx `19.0.0-beta.11`

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-05-03 10:21:26 -04:00
Colum Ferry
21d7e9221d
fix(testing): convert-to-inferred generators should add includes only when needed (#23159)
- fix(devkit): executor-to-plugin-migrator should remove includes when
all config files are handled
- fix(testing): cypress convert-to-inferred should add
ciWebServerCommand correctly

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
`includes` are being added to all new plugins that are being added to
nx.json.
It should only be added when not all config files are addressed by the
plugin to be added.

Cypress Convert To Inferred is not creating a `ciWebServerCommand` when
it is possible to do so.


## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Ensure `includes` is added only when required.
Ensure `cypress:convert-to-inferred` is adding a ciWebServerCommand
correctly


## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-05-03 09:50:08 -04:00
Colum Ferry
acd0993f1a
feat(linter): add convert-to-inferred migration generator (#23142) 2024-05-03 17:23:01 +04:00
Leosvel Pérez Espinosa
1d2c843c26
fix(angular): ensure buildable libraries in-process tsconfig file extends from the correct path (#23165)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #23091
2024-05-03 14:41:58 +02:00
Colum Ferry
e5c02062db
fix(remix): use remix-serve for static-serve (#23164)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
For `e2e-ci` with Remix projects, we needed a `static-serve` target that
would work for Remix.
We didn't have one as it cannot be served via a basic file server.


## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
For non-plugin usage, create a target in project.json using
`remix-serve`.
For plugin usage, create a target via `@nx/remix/plugin` for
`remix-serve`.


## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-05-03 13:18:27 +01:00
Colum Ferry
dc54b5584d
fix(remix): pin testing-library/jest-dom to compatible version (#23161)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
@testing-library/jest-dom released a version that is broken currently
and it was being found by our version string.



## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Pin the version of the package to the latest working versions


## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-05-03 13:03:04 +01:00
Colum Ferry
dbad02afe4
fix(testing): convert-to-inferred generator should handle legacy cypress executor (#23151)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
The `convert-to-inferred` generator does not handle
`@nrwl/cypress:cypress`.


## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
The generator should handle the legacy executor

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-05-02 18:05:59 -04:00
Jason Jean
eddd0d61c1
fix(gradle): fix gradle github ci workflow (#23154)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

Gradle github CI workflow has an extra unnecessary step.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Gradle github CI workflow does not have the unnecessary step.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-05-02 16:51:03 -04:00
Craigory Coppola
64b4814c65
fix(core): projectName should not be interpolated as undefined (#23145)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
Tokens are interpolated into arguments while merging things into the
root map. Unfortunately, this means `{projectName}` is sometimes
interpolated as `undefined` because the project's name isn't known yet.

## Expected Behavior
Tokens are interpolated after the root map has been constructed, but
still during `createProjectConfigurations` s.t. we can know that we have
final project configurations afterwards.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-05-02 16:30:12 -04:00
Emily Xiong
11f30f638f
fix(gradle): add namedInputs to nx.json in gradle init (#23152)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-05-02 16:15:51 -04:00
Emily Xiong
bacdc799b4
fix(graph): remove redux and useState and useContext hook (#23085)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-05-02 13:38:23 -04:00
Jack Hsu
2e621f324c
feat(misc): v19 cleanup for Nx plugins (#23104)
This PR removes deprecated code that's been slated for removal in Nx 19
- mentioned as `TODO(v19)` comments.

## Breaking Changes

- **CNW:** `create-nx-workspace` no longer support `--preset=empty` and
`--preset=core`, use `--preset=apps` and `--preset=npm` respectively.
Deprecated in Nx 15.9.
- **Next.js:** `NX_` environment variables are no longer bundled into
Next.js apps, use `NEXT_PUBLIC` instead. Deprecated in Nx 16.8.
- **Webpack, Storybook, Esbuild:** `NX_` environment variables are no
longer bundled into browser bundles, use `NX_PUBLIC` instead. This
removes the possibility of intentional bundling of `NX_` variables.
Deprecated in Nx 18.
- **Cypress:** `cypressComponentConfiguration` generator removed from
`@nx/cypress`, use `configurationGenerator`instead. Deprecated in Nx
16.8.
- **Cypress:** `cypressProjectGenerator` generator removed from
`@nx/cypress`, use `configurationGenerator` instead. Deprecated in Nx
15.9.
- **Expo:** `withNxWebpack` removed from `@nx/expo`, use [metro
bundler](https://docs.expo.dev/guides/customizing-metro/)
(https://docs.expo.dev/guides/customizing-metro/) in app.json instead.
There is a migration to handle this in Nx 19. Deprecated in Nx 15.8.

## Deferred to v20

- **JS:** `classProperties.loose` option removed from `@nx/js/babel`
preset, use `loose` instead. Deprecated in Nx 17.0.
- **ESLint:** Low priority task to "deviations from
@typescript-eslint/recommended" for our lint rules. @JamesHenry will
look at this later before Nx 20, but it is unimportant.
- **React:** component testing does not work with Project Crystal, and
we need the executor + built-in webpack configs to run CT. Will do a
follow-up on this after Nx 19 release. Related issue:
https://github.com/nrwl/nx/issues/21546
- **Next.js:** `withStylus` removal from `@nx/next`, use SASS instead.
It hasn't worked, but we kept the file to throw an error when used.
Deprecated in Nx 17.0.
- **Next.js**: `@nx/next:component` and `@nx/next:page` generators to
not derive the `components` and `app`/`pages` directory. Use `nx g
@nx/next:component apps/myapp/components/button` instead. Deprecated in
Nx 17.0.
- **Webpack:** `isolatedConfig` option removal from
`@nx/webpack:webpack` executor. There is a migration to handle this in
Nx 19. Deprecated in in Nx 17.2.
- **Angular:** `executeWebpackDevServerBuilder` removal from
`@nx/angular/executors`, use `executeDevServerBuilder` instead.
Deprecated in Nx 17.0.
2024-05-02 13:37:12 -04:00
Emily Xiong
35f0618347
fix(gradle): fix gradle not working for spring (#23130)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-05-02 13:11:00 -04:00
Miroslav Jonaš
e15720ba4f
fix(core): remove obsolete git track from ci generators (#23134)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-05-02 12:25:41 -04:00
Jason Jean
9da9f4220d
feat(gradle): add ci-workflow generator (#23125)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

There is no generator to setup a CI workflow for a Gradle workspace.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

`./nx g ci-workflow` sets up a CI workflow for either Github Actions or
CircleCI. More will be added later.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-05-02 12:25:18 -04:00
MaxKless
2e85b1dbe5
fix(graph): remove dangling - and move button when PDV is rendered in console (#23144) 2024-05-02 18:24:51 +02:00
Colum Ferry
11fec5a4e8
fix(devkit): run callback for forEachProjectConfig when target.options is undefined (#23143)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
`forEachExecutorOptions` will not run the callback if `target.options`
is undefined.
This means that even if a target exists with an executor, the target is
not being processed if it does not have `options`.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Run the callback anyway even if `target.options` is undefined

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-05-02 12:20:07 -04:00
MaxKless
44fcb1a59c
fix(core): catch workspace validity check errors (#23138)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
Errors thrown by `assertWorkspaceValidity` aren't handled and lead to
the nx process' exit

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Errors are properly caught and handled with the ability to recover a
partial project graph like other errors.
2024-05-02 11:46:58 -04:00
pmariglia
b898dd58e4
docs(nx-cloud): document arm resource classes (#23116)
## Update Nx Cloud Resource Class Documentation

Documents the docker_linux_arm resource classes in
`launch-templates.md`. No changes to the images are required.
2024-05-02 11:35:19 -04:00
Johanna Pearce
9c02175098 docs(nx-cloud): warn about rate limiting with ADO integration 2024-05-02 16:05:04 +01:00
MaxKless
2002a7872f
feat(graph): log errors in console in graph watch mode (#23136) 2024-05-02 10:14:11 -04:00
Craigory Coppola
0fbd2f80a9
fix(core): ensure project with name undefined is not created (#23097)
* fix(core): ensure workspaces config is updated when daemon running

* fix(core): properly error when projects have no name but with a package.json
2024-05-02 10:09:25 -04:00
Jason Jean
5ded713c3c
fix(repo): set version of pnpm for docker publishes (#23129)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

The version of pnpm changed with the docker image.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

The version of pnpm is installed over the one in the docker image to
ensure the right version is being used.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-05-01 18:40:53 -04:00
Nicholas Cunningham
02a8602607
docs(core): Update styles for enterprise page on small screens (#23126)
Addresses some styles for smaller screens. 

Fixes #
2024-05-01 20:18:36 +00:00
Nicholas Cunningham
b0ee75e6af
docs(core): Update meterics and customer background on enterprise page (#23123) 2024-05-01 14:01:47 -04:00
Phillip Barta
9b12d188c2
cleanup(core): remove deprecated command-line reexports (#19914)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-05-01 13:36:49 -04:00
Isaac Mann
9a06a76fa7
fix(nx-dev): header styles fix (#23122) 2024-05-01 12:33:44 -04:00
Jason Jean
a64a7e2db9
feat(core): cleanup for v19 (#22993) 2024-05-01 12:12:32 -04:00
Denis Bendrikov
307f8d4624
fix(core): align padding for output with failed tasks (#23119) 2024-05-01 12:12:06 -04:00
Isaac Mann
e38df31ee6
Revert "chore(nx-dev): fix header styles (#23120)" (#23121) 2024-05-01 11:27:06 -04:00
Isaac Mann
ba8ba3d7ea
chore(nx-dev): fix header styles (#23120) 2024-05-01 11:14:37 -04:00
Emily Xiong
4f4f77c68f
fix(graph): use class sticky for sticky header (#23082) 2024-05-01 11:10:19 -04:00
Jack Hsu
8cf7191809
feat(graph): show tooltips that were previously hidden due to upublished docs (#23099) 2024-05-01 10:57:18 -04:00
Chabbey François
877b37dac3
fix(core): add import for performance to increase compatibility (#23109)
Co-authored-by: U812320 <francoisjulien.chabbey@mobi.ch>
2024-05-01 10:30:39 -04:00
Benjamin Cabanes
22ef42a475
feat(nx-dev): add ui-enterprise library (#23086) 2024-05-01 06:45:51 -04:00
Craigory Coppola
abd80cf3f1
fix(core): local plugins should be able to use {projectRoot} in options block (#23068) 2024-04-30 18:41:27 -04:00
Craigory Coppola
16e3f83d46
Revert "chore(repo): enable plugin isolation for nx repo (#22785)" (#23103) 2024-04-30 16:55:43 -04:00
Craigory Coppola
c09f70f9a0
fix(js): copy assets handler should handle ignore globs on windows (#23065) 2024-04-30 14:14:54 -04:00
Michal Jez
8631b40d54
feat(core): validate that outputs is an array of strings (#22371) 2024-04-30 13:53:19 -04:00
Craigory Coppola
063a5d464f
chore(repo): enable plugin isolation for nx repo (#22785)
Co-authored-by: Jason Jean <jasonjean1993@gmail.com>
2024-04-30 12:47:44 -04:00
Colum Ferry
44820f2c4b
feat(testing): add convert-to-inferred migration generator for cypress (#22884) 2024-04-30 12:47:12 -04:00
Leosvel Pérez Espinosa
4ef832f4d5
fix(core): do not forward --updatePackageScripts flag to init generators that are not from nx core plugins (#23064) 2024-04-30 11:59:54 -04:00
MaxKless
73ab6d35ff
feat(graph): enable watch mode by default (#23092) 2024-04-30 11:55:57 -04:00
Emily Xiong
30a3875a0d
fix(gradle): fix gradlew exec path for root project (#23094) 2024-04-30 11:54:50 -04:00
MaxKless
c8d44b0355
feat(graph): show partial project graph & errors in graph app (#22838) 2024-04-30 11:35:07 -04:00
Jason Jean
0ceea2f7da
chore(repo): update nx to 19.0.0-beta.8 (#23087) 2024-04-30 11:15:30 -04:00
Jack Hsu
458f2cc1e8
feat(nx-dev): add nx blog (#22828)
Co-authored-by: Juri <juri.strumpflohner@gmail.com>
Co-authored-by: Nicholas Cunningham <ndcunningham@gmail.com>
Co-authored-by: Benjamin Cabanes <3447705+bcabanes@users.noreply.github.com>
2024-04-29 17:04:37 -04:00
Nicholas Cunningham
1f6aba03a1
fix(js): Correct file path for cjs.js (#23081) 2024-04-29 19:54:09 +00:00
Craigory Coppola
cd7f3df3de
fix(core): ensure daemon socket dir exists when specified in env (#23071) 2024-04-29 13:54:09 -04:00