5294 Commits

Author SHA1 Message Date
hellivan
3824eebc23
fix(node): npm modules are not resolved correctly (#9284)
The current implementation of the node executor resolves all npm
modules that are referenced by the application from the root
node_modules folder. This behavior leads to runtime errors if any of
the project dependencies requires a different version of a package
than the project itself.

For example, if we have a project that depends on `express` in version
`4.17.3` (which on the other hand depends on `path-to-regexp` version
`0.1.7`) as well as on `path-to-regexp` in version `6.2.0`. In such
case `express` will throw a runtime error since it would load
`path-to-regexp` version `6.2.0` which is not API compatible.

For this reason, this commit changes the behavior of the node-executor
so that it completely ignores npm dependencies when calculating
resolve mappings.
2022-03-18 16:40:37 -04:00
Andrew Luca
ad54978328
docs(core): fix using-executors example import (#9321) 2022-03-18 20:37:59 +00:00
Miroslav Jonaš
f50f0bc845
chore(core): split hasher filter types for node and workspace project (#9293)
* chore(core): split hasher filter types for node and workspace project

* fix(core): change leftover hash filter to node hash filter
2022-03-18 16:26:37 -04:00
Matthias Stemmler
dff05dcbde
fix(web): fix handling of buildLibsFromSource: false in dev-server executor (#9326)
* modify buildOptions.tsConfig before creating Webpack config
* do not join buildOptions.tsConfig to root path as it is already an absolute path
2022-03-18 16:21:56 -04:00
Sorin Davidoi
75f9ece440
fix(core): don't allow arbitrary code execution when manipulating cache (#9329)
The Node documentation for `exec` states:

> Never pass unsanitized user input to this function. Any input containing shell metacharacters may be used to trigger arbitrary command execution.

The `folder` variable comes directly from the `NX_CACHE_DIRECTORY` environment variable (or from `nx.json`). Careful crafting of this variable can result in NX executing arbitrary commands.

This patch fixes this by using `execFile`, which does not spawn a shell.
2022-03-18 16:19:12 -04:00
Sorin Davidoi
f5dfb837a2
fix(web): don't allow arbitrary code execution in file-server (#9330)
The Node documentation for `exec` states:

> Never pass unsanitized user input to this function. Any input containing shell metacharacters may be used to trigger arbitrary command execution.

The `outputPath`, `options.buildTarget` and `options.maxParallel` come from `nx.json`. Careful crafting of these fields can result in NX executing arbitrary commands.

This patch fixes this by using `execFile`, which does not spawn a shell.
2022-03-18 16:16:31 -04:00
K. Golbang
cd8c9b0313
feat(testing): support for memory leaks detection for jest added [logHeapUsage, detectLeaks] (#9339) 2022-03-18 16:10:28 -04:00
Craigory Coppola
05f72c96ea
fix(core): targets referred to by targetDependencies should be optional by default (#9344) 2022-03-18 15:30:48 -04:00
Juri Sinitson
36aa5ce5fb
docs(angular): change --defaults to --no-interactive (#9376)
When using the flag `--defaults` I get `Use --no-interactive instead of --defaults. The --defaults option will be removed in Nx 13` although I'm already using Nx 13.7.1. When using `--no-interactive`, no message is showing up.
2022-03-18 15:28:16 -04:00
Craigory Coppola
b3914bda90
chore(misc): update add-nx ci (#9398) 2022-03-18 15:22:09 -04:00
Amarnath Reddy Dornala
6a601b9959
Fixed issue with webpack plugin (#8231)
feat(npm): resolved issue with live reload failing

Fixed the issue with live reload when adding scripts in project.json

Closes #8230
2022-03-18 12:55:53 -04:00
Jason Jean
949498f5ac
fix(core): remove @nrwl/cli bin setting (#9394) 2022-03-18 12:06:59 -04:00
Colum Ferry
a8ede441eb
feat(angular): support angular v13.3.0 (#9311) 2022-03-18 14:59:04 +00:00
Craigory Coppola
75ad30ca18
feat(core): ability to run local nx plugins w/o build step (#9116)
* feat(core): ability to run local nx plugins generators and executors

* feat(core): support for project inference and graph extension local plugins

* chore(core): cleanup after package relocation

* chore(core): changes for review
2022-03-18 14:10:06 +00:00
Katerina Skroumpelou
483115ba06
fix(storybook): when building set node_env (#9390)
ISSUES CLOSED: #8403
2022-03-18 14:00:40 +00:00
Colum Ferry
08c6b02e50
fix(angular): set tsconfig path correctly (#9386) 2022-03-18 11:43:24 +00:00
Craigory Coppola
19e9b462ec
chore(repo): move add-nx into main nx repo (#9382)
* chore(repo): move add-nx into main nx repo

* fix(misc): fix publishing of add nx projects

Co-authored-by: Jason Jean <jasonjean1993@gmail.com>
2022-03-17 18:38:06 -04:00
Emily Xiong
3627c3a38c
feat(react-native): upgrade metro-resolver to 0.69.1 (#9381) 2022-03-17 13:46:01 -04:00
Emily Xiong
83acbafa7c
bugfix(storybook): should add @storybook/react-native to devDependencies (#9364) 2022-03-17 00:38:17 +00:00
Jason Jean
d7150e6d36
chore(repo): update nx to 13.9.1 (#9362) 2022-03-16 23:24:51 +00:00
Jason Jean
731e57098e chore(core): fix snapshots 2022-03-16 17:26:16 -04:00
Jason Jean
74980db347
fix(core): undo removal of @nrwl/cli and add warning when it is imported (#9370) 2022-03-16 17:24:36 -04:00
Emily Xiong
17fe648d5f
chore(angular): disable failing storybook test (#9367) 2022-03-16 15:56:21 -04:00
Benjamin Cabanes
5245202628
docs(nxdev): update workspace example with nx cmd (#9360) 2022-03-16 15:22:10 -04:00
Benjamin Cabanes
651d25c0d3
docs(nxdev): add tutorial next step links (#9365) 2022-03-16 18:22:54 +00:00
Emily Xiong
615bd73c59
bugfix(react-native): add ENTRY_FILE relative to PROJECT_DIR in iOS shell script (#9222) 2022-03-16 13:03:37 -04:00
Giora Guttsait
f44165d993
feat(js): infer tslib as a dependency when using importHelpers (#9350) 2022-03-16 12:47:39 -04:00
Benjamin Cabanes
5da76a9a13
docs(nxdev): update nextjs plugin description (#9361) 2022-03-16 15:23:02 +00:00
Leosvel Pérez Espinosa
39554b9035
fix(core): fix migrate command to properly handle the packages consolidation (#9352) 2022-03-16 11:19:24 -04:00
DEO
b9bc67f552
docs(shared): update packagejson.md (#9132) 2022-03-16 11:19:10 -04:00
Miroslav Jonaš
fe159210e2
docs(nxdev): add info for BASE_SHA calculation on Azure CI (#9357) 2022-03-16 14:39:04 +01:00
Miroslav Jonaš
eb2fa0cd24
docs(nxdev): update circleci and github ci docs (#9355) 2022-03-16 14:20:52 +01:00
Colum Ferry
a26caaa288
feat(angular): add component generator (#9351) 2022-03-16 12:48:27 +00:00
Leosvel Pérez Espinosa
fd980443f2
chore(repo): update out of sync yarn.lock (#9349) 2022-03-16 10:29:16 +00:00
Miroslav Jonaš
996e2decc7
fix(linter): ensure eslint fixes are stored before results are filtered (#9348) 2022-03-16 09:59:08 +00:00
Colum Ferry
2d0871932c
feat(angular): add withModuleFederation helper (#9289)
* feat(angular): withModuleFederation helper
2022-03-16 09:47:03 +00:00
Miroslav Jonaš
3c17e80bde
fix(linter): check for both nrwl/nx and eslint for terminal runs (#9340) 2022-03-16 08:42:29 +00:00
Jason Jean
1b7a3b2b74 Release 13.9.0 2022-03-15 17:42:37 -04:00
Rares Matei
a667a21065
docs(core): point runner docs to default runner (#9106) 2022-03-15 16:13:10 -04:00
Austin
48d32acca3
feat(web): add proxy config support to file-server executor (#9225) 2022-03-15 16:11:17 -04:00
Jason Jean
5d5be04865 chore(core): format tao re-exports 2022-03-15 15:54:49 -04:00
Victor Savkin
0f7cf3464e
fix(misc): reexport tokens that from nx 2022-03-15 15:20:49 -04:00
Victor Savkin
419131838f
fix(misc): handle tsx files correctly when excluding specs 2022-03-15 13:52:56 -04:00
Leosvel Pérez Espinosa
7ae6d48f94
cleanup(angular): ban imports from @nrwl/workspace entry point (#9341) 2022-03-15 17:02:57 +00:00
Victor Savkin
86aaeb635a
fix(core): reexport package-manager 2022-03-15 12:22:17 -04:00
Leosvel Pérez Espinosa
a82edb1bc4
feat(angular): add buildLibsFromSource option to @nrwl/angular:webpack-browser executor (#9334) 2022-03-15 15:33:56 +00:00
Caleb Ukle
ac464b957f
docs(testing): provide performance tips for jest (#9128)
explain which flags to use when running tests for the best performance in jest

ISSUES CLOSED: #8964
2022-03-15 11:11:20 -04:00
Victor Savkin
9c25cd9f59
chore(repo): reenable tests 2022-03-15 09:52:43 -04:00
Colum Ferry
c4f96467c3
feat(angular): default export of scams to true (#9331) 2022-03-15 13:39:57 +00:00
Miroslav Jonaš
f5a0f7ea73
chore(repo): update nx orb version in circleci config (#9327) 2022-03-15 10:36:44 +00:00