26 Commits

Author SHA1 Message Date
MaxKless
499300fd76
fix(core): repair SIGINT signals on windows (#28496)
using `windowsHide: true` is causing an issue on windows: Ctrl + C
handling isn't enabled and no `SIGINT` is sent to the child process when
users exit the process. See https://github.com/nodejs/node/issues/29837
and https://github.com/nodejs/node-v0.x-archive/issues/5054 for
reference. This will cause leftover processes throughout nx.

This PR sets `windowsHide: false` everywhere except for the plugin
workers and some short-lived utils. They `spawn` child processes but
have explicit handling to make sure they kill themselves when the parent
process dies, so the missing Ctrl + C handling doesn't cause issues.

We will follow up to make sure any other culprits that still cause
windows popups (especially when used through Nx Console) are handled.
Leaving no leftover processes running is more important for now, though.

Keep in mind the underlying tooling (like vite) might have some windows
popups themselves that Nx will inherit.
2024-10-17 15:03:37 -04:00
MaxKless
b73f1e0e00
fix(core): set windowsHide: true wherever possible (#28073)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-09-24 11:31:22 -04:00
Jason Jean
155e69b946
fix(devkit): detect package manager based on install location (#27127)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

The package manager is detected based off of the relative `cwd` which in
most cases is `''`. This incorrectly goes off of the `cwd` of the
command rather than the location of the `package.json` file being
modified.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

The package manager is detected based off the absolute path of the
directory containing the `package.json` file being modified. So if this
is the root, it will detect the package manager at the root rather than
the `cwd`

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes https://github.com/nrwl/nx/issues/19831
2024-07-25 14:40:57 -05:00
Jason Jean
a64a7e2db9
feat(core): cleanup for v19 (#22993) 2024-05-01 12:12:32 -04:00
Miroslav Jonaš
80ade9354b
fix(core): ensure CNW works without .yarnrc with custom registry (#18937) 2023-10-18 09:15:55 -04:00
Miroslav Jonaš
adb39c464d
fix(core): ensure preinstall is only run once on repo (#18671) 2023-08-18 17:30:33 -04:00
Miroslav Jonaš
10fc4dd4d8
fix(core): ensure proper yarn version detection even for nested projects (#18052) 2023-07-17 10:35:18 -04:00
Craigory Coppola
0370794e63
feat(core): add --quiet option to suppress generate output (#15802) 2023-03-21 19:53:21 -04:00
Jason Jean
1d773c0d35
fix(devkit): make devkit backwards compatible back to nx 14.1 (#14854) 2023-02-09 12:48:57 -05:00
Jason Jean
5e23c07077
fix(core): automatically add root to the project.json projects (#9977)
* fix(core): automatically add root to the project.json projects

* chore(core): move project-configuration generator utils to nx package

* fix(core): add migrations to remove root
2022-04-28 13:24:35 -04:00
Jason Jean
3d563685d1
fix(core): fix having multiple versions of nx/devkit (#9998) 2022-04-26 14:39:18 -04:00
Victor Savkin
428106f6be
cleanup(core): create more meaningful file structure in nx package (#9621) 2022-03-31 09:07:22 -04:00
Victor Savkin
d4b5c30eba
cleanup(core): remove the indirection left after inlining ta… (#9469) 2022-03-23 22:18:17 -04:00
Victor Savkin
6f038e7a4a feat(core): reorganize packges to consolidate all cli-related code in nx 2022-03-14 16:42:51 -04:00
Jason Jean
89a4ac29b2
cleanup(devkit): rename all variable names of host to tree (#6541) 2021-07-29 15:46:41 -04:00
Phillip Barta
6c6e8b36b7 feat(devkit): refactoring for stricter types and better performance 2021-05-27 13:37:29 -04:00
Phillip Barta
52e3083a19
feat(core): added encoding param in Tree.read() (#5668)
feat(core): added encoding param in Tree.read()
2021-05-17 21:03:04 -04:00
Phillip Barta
6bd6e1485f
feat(core): added package manager union type (#5378)
cleanup(misc): add package manager union type
2021-04-19 15:24:02 -04:00
Jason Jean
33acb41afb
cleanup(react): cleanup generators for react and next (#4769) 2021-02-12 15:29:31 -05:00
Tasos Bekos
57c6bacfb4
fix(core): fix install packages task on Windows (#4752)
Changing to forward slashes was causing failures on Windows if execting from volume other than C:/.

Closes #4727
2021-02-10 11:09:33 -05:00
Jason Jean
82ee3227af fix(core): fix workspace creation not working on windows 2021-02-04 01:31:47 +02:00
Jason Jean
09c78c4750 feat(core): migrate create-nx-workspace to devkit 2021-01-13 08:51:50 -05:00
Jason Jean
4bc9bbda22
feat(testing): move jest to nrwl devkit (#4454) 2021-01-08 15:07:27 -05:00
Tasos Bekos
c6cb176218 cleanup(core): remove duplicate code about package manager 2020-12-01 12:43:23 +02:00
victor savkin
234ca36385 cleanup(misc): clean up devkit 2020-11-26 10:19:13 -05:00
Victor Savkin
4a17b7339f feat(core): use the new schematics api for workspace schematics 2020-11-17 19:31:08 -05:00