13 Commits

Author SHA1 Message Date
Phillip Barta
fe97444d78
feat(core): migrate prettier to v2.3.1 (#5623) 2021-06-17 16:44:30 +02:00
Vivek More 🧐
212fb00548 cleanup(misc): use more es6 features
- Single char alternation (e.g. a|b|c|d) in a RegExp can be simplified to use a character class ([abcd]) instead.
  This usually also provides slightly better matching performance.
- Character escapes that are replaceable with the unescaped character without a change in meaning. Inside the square brackets of a character class, many escapes are unnecessary that would be necessary outside of a character class. For example the regex [\.] is identical to [.]
- If several qualified expressions occur after the qualifier having been checked for nullable, they can be replaced with optional chaining
2021-03-24 20:11:32 -04:00
Spencer Elliott
5b6df632cb
fix(core): resolve webpack loaders with require.resolve() (#3436)
* fix(core): resolve webpack loaders with `require.resolve()`

With strict package managers such as pnpm or Yarn PnP, transitive
dependencies are *not* hoisted to the root node_modules folder. This
means that a webpack config defined within a package like
'@nrwl/cypress' cannot resolve loaders like 'ts-loader', unless
'ts-loader' is declared in the workspace's own package.json.

This is a problem because the workspace might define a different version
of 'ts-loader', incompatible with the version declared by
'@nrwl/cypress/package.json'. The workspace should not need to declare
a dependency on 'ts-loader' anyway.

See also:
* https://github.com/pnpm/pnpm/issues/801
* https://github.com/webpack/webpack/issues/5087

* fix(core): resolve absolute 'raw-loader' path

When replacing the 'raw-loader' rule in the `getStylesPartial` function,
check for the absolute path of 'raw-loader' rather than just the name.
2020-08-08 17:53:00 -04:00
Jack Hsu
ed8bd2bbe8
Revert "fix(core): resolve webpack loaders with require.resolve() (#3341)" (#3371)
This reverts commit d74ab4e9d6eae6d83c3bb76072b45f7a4c7a6305.
2020-07-20 16:24:47 -04:00
Spencer Elliott
d74ab4e9d6
fix(core): resolve webpack loaders with require.resolve() (#3341)
With strict package managers such as pnpm or Yarn PnP, transitive
dependencies are *not* hoisted to the root node_modules folder. This
means that a webpack config defined within a package like
'@nrwl/cypress' cannot resolve loaders like 'ts-loader', unless
'ts-loader' is declared in the workspace's own package.json.

This is a problem because the workspace might define a different version
of 'ts-loader', incompatible with the version declared by
'@nrwl/cypress/package.json'. The workspace should not need to declare
a dependency on 'ts-loader' anyway.

See also:
* https://github.com/pnpm/pnpm/issues/801
* https://github.com/webpack/webpack/issues/5087
2020-07-15 13:55:38 -04:00
Jason Jean
e06822da7e
chore(repo): update prettier to v2 (#2934)
this is just for the repo, and not the workspace

Co-authored-by: Rares Matei <matei.rar@gmail.com>
2020-04-29 01:09:37 -04:00
Victor Savkin
d27cb3aa42
feat(misc): support customizing cypress webpack config (#2503)
Co-authored-by: Spencer Elliott <me@elliottsj.com>
2020-02-19 09:26:49 -05:00
Benjamin Cabanes
02e95d9f8c fix(testing): cypress & fork ts checker plugin (#2316) 2020-01-23 22:10:09 -05:00
Benjamin Cabanes
08f3844007 feat(nx): cypress supportFile handling (#1920)
This update the Cypress schematic to handle by default the `supportFile` option
in `cypress.json` with an example for _custom commands_.

Related to #1609
2019-11-15 16:16:27 -05:00
Thomas Skalnik
d3d5417a09 feat(testing): set transpileOnly=true ...
... and use the ForkTsCheckerWebpackPlugin
for the cypress test execution.

Closes #1871
2019-09-23 13:01:00 -04:00
Victor Savkin
70d71b3516 feat(nx): add support for migrations 2019-09-02 14:33:56 -04:00
Jason Jean
889d13f3aa enhancement(testing): do not bundle node_modules for cypress files 2019-06-27 16:31:55 -04:00
Jason Jean
6dd7353636 feat(testing): rework how typescript is loaded into cypress 2019-06-24 12:12:06 -04:00