Emily Xiong 79b75ad140
fix(detox): fix name with camel case (#27602)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
- when create an app with `--appName <app name in camel case>`, it
currently has an error. it is caused by line:
```
  const { root: appRoot } = readProjectConfiguration(
    host,
    names(options.appProject).fileName
  );
```
it should not convert appProject to fileName, it should just take the
appProject as it is:
```
const { root: appRoot } = readProjectConfiguration(host, options.appProject);
```

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes https://github.com/nrwl/nx/issues/24080
2024-08-29 16:54:39 -04:00

140 lines
3.8 KiB
TypeScript

import {
formatFiles,
GeneratorCallback,
joinPathFragments,
output,
readJson,
runTasksInSerial,
Tree,
} from '@nx/devkit';
import { initGenerator as jsInitGenerator } from '@nx/js';
import { logShowProjectCommand } from '@nx/devkit/src/utils/log-show-project-command';
import { addLinting } from '../../utils/add-linting';
import { addJest } from '../../utils/add-jest';
import { chmodAndroidGradlewFilesTask } from '../../utils/chmod-android-gradle-files';
import { runPodInstall } from '../../utils/pod-install-task';
import { webConfigurationGenerator } from '../web-configuration/web-configuration';
import { normalizeOptions } from './lib/normalize-options';
import initGenerator from '../init/init';
import { addProject } from './lib/add-project';
import { createApplicationFiles } from './lib/create-application-files';
import { addE2e } from './lib/add-e2e';
import { Schema } from './schema';
import { ensureDependencies } from '../../utils/ensure-dependencies';
import { syncDeps } from '../../executors/sync-deps/sync-deps.impl';
import { PackageJson } from 'nx/src/utils/package-json';
export async function reactNativeApplicationGenerator(
host: Tree,
schema: Schema
): Promise<GeneratorCallback> {
return await reactNativeApplicationGeneratorInternal(host, {
addPlugin: false,
projectNameAndRootFormat: 'derived',
...schema,
});
}
export async function reactNativeApplicationGeneratorInternal(
host: Tree,
schema: Schema
): Promise<GeneratorCallback> {
const options = await normalizeOptions(host, schema);
const tasks: GeneratorCallback[] = [];
const jsInitTask = await jsInitGenerator(host, {
...schema,
skipFormat: true,
});
tasks.push(jsInitTask);
const initTask = await initGenerator(host, { ...options, skipFormat: true });
tasks.push(initTask);
if (!options.skipPackageJson) {
tasks.push(ensureDependencies(host));
}
await createApplicationFiles(host, options);
addProject(host, options);
const lintTask = await addLinting(host, {
...options,
projectRoot: options.appProjectRoot,
tsConfigPaths: [
joinPathFragments(options.appProjectRoot, 'tsconfig.app.json'),
],
});
tasks.push(lintTask);
const jestTask = await addJest(
host,
options.unitTestRunner,
options.projectName,
options.appProjectRoot,
options.js,
options.skipPackageJson,
options.addPlugin
);
tasks.push(jestTask);
const webTask = await webConfigurationGenerator(host, {
...options,
project: options.name,
skipFormat: true,
});
tasks.push(webTask);
const e2eTask = await addE2e(host, options);
tasks.push(e2eTask);
const chmodTaskGradlewTask = chmodAndroidGradlewFilesTask(
joinPathFragments(host.root, options.androidProjectRoot)
);
tasks.push(chmodTaskGradlewTask);
const podInstallTask = runPodInstall(
joinPathFragments(host.root, options.iosProjectRoot)
);
if (options.install) {
const projectPackageJsonPath = joinPathFragments(
options.appProjectRoot,
'package.json'
);
const workspacePackageJson = readJson<PackageJson>(host, 'package.json');
const projectPackageJson = readJson<PackageJson>(
host,
projectPackageJsonPath
);
await syncDeps(
options.name,
projectPackageJson,
projectPackageJsonPath,
workspacePackageJson
);
tasks.push(podInstallTask);
} else {
output.log({
title: 'Skip `pod install`',
bodyLines: [
`run 'nx run ${options.name}:pod-install' to install native modules before running iOS app`,
],
});
}
if (!options.skipFormat) {
await formatFiles(host);
}
tasks.push(() => {
logShowProjectCommand(options.projectName);
});
return runTasksInSerial(...tasks);
}
export default reactNativeApplicationGenerator;