2d9a673ec8
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior Currently there doesn't seem to be support for pnpm catalogs in the dependency check which throws an error. ## Expected Behavior Catalog should be supported and at least not throw an error since its a default rule in some generators. I noticed that also that only `workspace:*` was implemented so I added the other possible options. https://pnpm.io/workspaces#publishing-workspace-packages I copy and pasted a test twice to add tests for this. I mean ideally I guess we would check the `pnpm-workspace` file and say is this catalog defined, I don't think that's up my ally for this purpose and I'm not sure if how its implemented does that for the workspace protocols as well. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # closed #29903, #29959 Gave it a shot, not sure if this is gonna be comprehensive enough. But let me know! happy to try and get this right. --------- Co-authored-by: Jack Hsu <jack.hsu@gmail.com>
{{links}}
Nx: Smart Monorepos · Fast CI
Nx is a build system, optimized for monorepos, with plugins for popular frameworks and tools and advanced CI capabilities including caching and distribution.
This package is an ESLint plugin for Nx.
{{content}}