nx/packages/js/src/utils/npm-config.ts
MaxKless b73f1e0e00
fix(core): set windowsHide: true wherever possible (#28073)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-09-24 11:31:22 -04:00

122 lines
4.4 KiB
TypeScript

import { exec } from 'child_process';
import { existsSync } from 'fs';
import { PackageJson } from 'nx/src/utils/package-json';
import { join, relative } from 'path';
export async function parseRegistryOptions(
cwd: string,
pkg: {
packageRoot: string;
packageJson: PackageJson;
},
options: {
registry?: string;
tag?: string;
},
logWarnFn: (message: string) => void = console.warn
): Promise<{ registry: string; tag: string; registryConfigKey: string }> {
const npmRcPath = join(pkg.packageRoot, '.npmrc');
if (existsSync(npmRcPath)) {
const relativeNpmRcPath = relative(cwd, npmRcPath);
logWarnFn(
`\nIgnoring .npmrc file detected in the package root: ${relativeNpmRcPath}. Nested .npmrc files are not supported by npm. Only the .npmrc file at the root of the workspace will be used. To customize the registry or tag for specific packages, see https://nx.dev/recipes/nx-release/configure-custom-registries\n`
);
}
const scope = pkg.packageJson.name.startsWith('@')
? pkg.packageJson.name.split('/')[0]
: '';
// If the package is scoped, then the registry argument that will
// correctly override the registry in the .npmrc file must be scoped.
const registryConfigKey = scope ? `${scope}:registry` : 'registry';
const publishConfigRegistry =
pkg.packageJson.publishConfig?.[registryConfigKey];
// Even though it won't override the actual registry that's actually used,
// the user might think otherwise, so we should still warn if the user has
// set a 'registry' in 'publishConfig' for a scoped package.
if (publishConfigRegistry || pkg.packageJson.publishConfig?.registry) {
const relativePackageJsonPath = relative(
cwd,
join(pkg.packageRoot, 'package.json')
);
if (options.registry) {
logWarnFn(
`\nRegistry detected in the 'publishConfig' of the package manifest: ${relativePackageJsonPath}. This will override your registry option set in the project configuration or passed via the --registry argument, which is why configuring the registry with 'publishConfig' is not recommended. For details, see https://nx.dev/recipes/nx-release/configure-custom-registries\n`
);
} else {
logWarnFn(
`\nRegistry detected in the 'publishConfig' of the package manifest: ${relativePackageJsonPath}. Configuring the registry in this way is not recommended because it prevents the registry from being overridden in project configuration or via the --registry argument. To customize the registry for specific packages, see https://nx.dev/recipes/nx-release/configure-custom-registries\n`
);
}
}
const registry =
// `npm publish` will always use the publishConfig registry if it exists, even over the --registry arg
publishConfigRegistry ||
options.registry ||
(await getNpmRegistry(cwd, scope));
const tag = options.tag || (await getNpmTag(cwd));
return { registry, tag, registryConfigKey };
}
/**
* Returns the npm registry that is used for publishing.
*
* @param scope the scope of the package for which to determine the registry
* @param cwd the directory where the npm config should be read from
*/
export async function getNpmRegistry(
cwd: string,
scope?: string
): Promise<string> {
let registry: string | undefined;
if (scope) {
registry = await getNpmConfigValue(`${scope}:registry`, cwd);
}
if (!registry) {
registry = await getNpmConfigValue('registry', cwd);
}
return registry;
}
/**
* Returns the npm tag that is used for publishing.
*
* @param cwd the directory where the npm config should be read from
*/
export async function getNpmTag(cwd: string): Promise<string> {
// npm does not support '@scope:tag' in the npm config, so we only need to check for 'tag'.
return getNpmConfigValue('tag', cwd);
}
async function getNpmConfigValue(key: string, cwd: string): Promise<string> {
try {
const result = await execAsync(`npm config get ${key}`, cwd);
return result === 'undefined' ? undefined : result;
} catch (e) {
return Promise.resolve(undefined);
}
}
async function execAsync(command: string, cwd: string): Promise<string> {
// Must be non-blocking async to allow spinner to render
return new Promise<string>((resolve, reject) => {
exec(command, { cwd, windowsHide: true }, (error, stdout, stderr) => {
if (error) {
return reject(error);
}
if (stderr) {
return reject(stderr);
}
return resolve(stdout.trim());
});
});
}